Issue metadata
Sign in to add a comment
|
Regression: Print preview abruptly closes on sheets |
||||||||||||||||||||||||
Issue descriptionVersion: 56.0.2924.0 dev OS: Ubuntu 14.04,Windows What steps will reproduce the problem? (1)Open any Google sheet and hit ctrl+p for print preview >> Click on print button and observe for preview Expected: Print preview should stay on clicking print. Actual: Instead print preview closes abruptly. This is a regression issue broken in M56. Manual Bisect Info: =================== Good Build:56.0.2920.0 dev Bad Build:56.0.2922.0 dev
,
Nov 18 2016
Using the per-revision bisect providing the bisect results, Good build: 56.0.2920.0 (Revision: 432057). Bad build: 56.0.2922.0 (Revision: 432511). You are probably looking for a change made after 432352 (known good), but no later than 432353 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/e299953842a5913ea92cfeb6f0079acfb22ea407..aaa2bba38197c0bcaa7cbcf15281ef4f9d568818 @thestig -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Thank You.
,
Nov 18 2016
Able to reproduce the issue on Mac OS 10.12 using chrome latest Dev M56-56.0.2924.0. Observed print-preview crashes on google sheets. Since this is a recent regression marking it as Release block Dev, please feel free to edit if this is not the case.
,
Nov 18 2016
+ reed@. As per c#1, this seems to be similar to crbug/666154 ? Thank you!
,
Nov 18 2016
I'll take a look just to be sure.
,
Nov 19 2016
After ruling out all the other bugs, this is still happening due to r432775. This only reproduces on Chrome because Google Sheets does some user agent detection. I'm pretty sure from the browser's perspective, this is just printing a PDF in some way. Maybe related to one of ekaramad's bugs that I have yet to look at.
,
Nov 19 2016
The behavior is very similar. I will build locally with my patch and see if it fixes it.
,
Nov 19 2016
This is the same as the issue 666432 . The problem is that |print_preview_rfh_| in PrintViewManager is not properly set in response to the IPC PrintHostMsg_RequestPrintPreview. Also, the fix in CL https://codereview.chromium.org/2517493002/ will not fix this since that one is only for guests (MimeHandlerViewGuest). We have to generalize that fix. I can take another look at this over the weekend to find the right way to address that IPC, in case no one else is interested. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by thestig@chromium.org
, Nov 18 2016