New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666674 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Compat



Sign in to add a comment

Font-size-adjust locks font-size when zooming

Reported by tom.by...@digital.cabinet-office.gov.uk, Nov 18 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.98 Safari/537.36

Steps to reproduce the problem:
1. go to www.gov.uk in chrome with the 'Experimental Web Platform Features' flag enabled
2. zoom the page to 200%

What is the expected behavior?
All the font sizes should zoom to 200% the size of the display size set in the CSS.

What went wrong?
Text using the font-size-adjust property is not being zoomed. Instead it is staying the size set in the CSS.

Did this work before? N/A 

Chrome version: 54.0.2840.98  Channel: stable
OS Version: OS X 10.11.6
Flash Version: 

I checked in the latest Chrome Canary (56.0.2924.0) too and saw the same results.
 
govuk-200-percent.png
3.1 MB View Download
Components: -UI Blink>CSS
Labels: M-54 Needs-Triage-M54

Comment 2 by samli@chromium.org, Nov 21 2016

Labels: Needs-Bisect
Labels: -Type-Bug -Pri-2 -M-54 -Needs-Bisect -Needs-Triage-M54 M-57 has-Bisect Pri-1 Type-Bug-Regression
Owner: e...@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Mac 10.11.6 using chrome reported version #54.0.2840.98 and latest canary #57.0.2926.0.

Bisect Information:
=====================
Good build: 43.0.2343.0  Revision(321961)
Bad Build : 43.0.2345.0  Revision(322258)

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/f82e8f7c7ab63b38b715c664f3bb23a608b5d28b..d05209674f5bf7bad0e37fa07247e2dbf9684642

Blink Change Log:
https://chromium.googlesource.com/chromium/src/+/c8ef53f19e3f0d35652472cedc029a1d253a7989

From the above change log suspecting below change

Review url: https://codereview.chromium.org/1028943002

Note: Not assigning this issue to the author as he/she is related to gmail.com. Hence, assigning it to the reviewer(eae).

eae@ - Could you please help us in assigning it to the right owner.

Thanks...!!
Labels: Needs-Triage-M54

Comment 5 by e...@chromium.org, Dec 13 2016

Labels: -Pri-1 Pri-2
Owner: pdr@chromium.org
pdr, would you mind commenting on this?

(lowering priority as this has been around for over a year)

Comment 6 by pdr@chromium.org, Dec 14 2016

Cc: pdr@chromium.org shivami...@gmail.com changseo...@collabora.com
Owner: e...@chromium.org
This feels a lot like  https://crbug.com/626670 . This looks like a font-size-adjust bug, but shivamidow didn't respond on the other bug (they may be OOO, last patch in Sept).

Despite their similar names, font-size-adjust is different from the text-size-adjust property. The latter is https://developer.mozilla.org/en-US/docs/Web/CSS/font-size-adjust.

Do we plan to move font-size-adjust out of experimental? If so, who should this be assigned to? If not, we should remove the code to prevent confusion (e.g., gov.uk folks).

Comment 7 by e...@chromium.org, Dec 14 2016

Cc: -pdr@chromium.org drott@chromium.org kojii@chromium.org
Labels: -Type-Bug-Regression Type-Compat
Owner: ----
Status: Available (was: Assigned)
Thanks for clarifying that pdr, I had completely forgotten that they are different.

drott/kojii: Is font-size-adjust something we want to support going forward?

Comment 8 by drott@chromium.org, Dec 14 2016

I don't know what we should do with this feature, I haven't seen much enthusiasm for it after the initial contribution, but this might not be so hard to fix, font-size-adjust probably doesn't handle scale factors correctly.

Comment 9 by kojii@chromium.org, Dec 14 2016

Only 1 impl and some people are discussing to extend it further[1]. Maybe this is better fit to Houdini, unless someone is motivated to work on this?

[1] https://github.com/w3c/csswg-drafts/issues/750

Comment 10 by meade@chromium.org, Feb 13 2017

Labels: Update-Quarterly
Labels: -Update-Quarterly
Project Member

Comment 12 by sheriffbot@chromium.org, Dec 6

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)

Sign in to add a comment