New issue
Advanced search Search tips

Issue 666672 link

Starred by 2 users
Status: Fixed
Owner:
thestig@chromium.org
Closed: Nov 2016
Cc:
skau@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Print preview hangs when selecting a printer without capabilities

Project Member Reported by thestig@chromium.org, Nov 18 2016 
What steps will reproduce the problem?
(1) Have a dummy printer that CUPS cannot fetch the capabilities for.
(2) Try to select it in print preview

What is the expected result?

Print preview assumes it's a b&w printer

What happens instead?

Print preview spews JS errors.


This is due to a combination of r426311, r427206, r430139, and r431051.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92a1b39f7a3fc31aedcf3ebfc50a297b95882bae

commit 92a1b39f7a3fc31aedcf3ebfc50a297b95882bae
Author: thestig <thestig@chromium.org>
Date: Fri Nov 18 19:28:52 2016

Print Preview: Fix handling of printers without capabilities.

BUG= 666672 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2509983006
Cr-Commit-Position: refs/heads/master@{#433263}

[modify] https://crrev.com/92a1b39f7a3fc31aedcf3ebfc50a297b95882bae/chrome/browser/resources/print_preview/data/destination_store.js
[modify] https://crrev.com/92a1b39f7a3fc31aedcf3ebfc50a297b95882bae/chrome/browser/ui/webui/print_preview/printer_capabilities.cc

Comment 2 by thestig@chromium.org, Nov 21 2016

Labels: Merge-Request-56

Comment 3 by dimu@chromium.org, Nov 21 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 21 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/524114b5aed6ba009d00a9dfd4bae0c6382389f8

commit 524114b5aed6ba009d00a9dfd4bae0c6382389f8
Author: Lei Zhang <thestig@chromium.org>
Date: Mon Nov 21 07:10:22 2016

M56: Print Preview: Fix handling of printers without capabilities.

BUG= 666672 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2509983006
Cr-Commit-Position: refs/heads/master@{#433263}
(cherry picked from commit 92a1b39f7a3fc31aedcf3ebfc50a297b95882bae)

Review URL: https://codereview.chromium.org/2517063002 .

Cr-Commit-Position: refs/branch-heads/2924@{#20}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/524114b5aed6ba009d00a9dfd4bae0c6382389f8/chrome/browser/resources/print_preview/data/destination_store.js
[modify] https://crrev.com/524114b5aed6ba009d00a9dfd4bae0c6382389f8/chrome/browser/ui/webui/print_preview/printer_capabilities.cc

Comment 5 by thestig@chromium.org, Nov 21 2016

Status: Fixed (was: Started)
►

Sign in to add a comment