New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666664 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Buried. Ping if important.
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 662930



Sign in to add a comment

Pull `worker-src` back behind the experimental flag.

Project Member Reported by mkwst@chromium.org, Nov 18 2016

Issue description

Based on discussion at https://github.com/w3c/webappsec-csp/issues/146, we should change two small things first.
 

Comment 1 by mkwst@chromium.org, Nov 18 2016

Blocking: 662930
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8071e0fb15f256d446f5483f4e7457d842a16800

commit 8071e0fb15f256d446f5483f4e7457d842a16800
Author: mkwst <mkwst@chromium.org>
Date: Fri Nov 18 08:54:09 2016

Pull 'worker-src' back behind the experimental flag.

Good discussion at https://github.com/w3c/webappsec-csp/issues/146
suggests that we might want to modify `worker-src` before shipping it.
So let's work that out first.

BUG=666664

Review-Url: https://codereview.chromium.org/2503213005
Cr-Commit-Position: refs/heads/master@{#433152}

[modify] https://crrev.com/8071e0fb15f256d446f5483f4e7457d842a16800/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp

Comment 3 by mkwst@chromium.org, Nov 18 2016

Labels: Merge-Request-56
Hello, friendly release managers! I'd like to merge this back to 56, which doesn't exist yet! :)

Comment 4 by rbyers@chromium.org, Nov 18 2016

Components: Blink>SecurityFeature

Comment 5 by dimu@chromium.org, Nov 19 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 29 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8df270c5cd722fec11ca761fa877ddd3ebfa86a

commit a8df270c5cd722fec11ca761fa877ddd3ebfa86a
Author: Mike West <mkwst@google.com>
Date: Tue Nov 29 12:38:46 2016

Pull 'worker-src' back behind the experimental flag.

Good discussion at https://github.com/w3c/webappsec-csp/issues/146
suggests that we might want to modify `worker-src` before shipping it.
So let's work that out first.

BUG=666664

Review-Url: https://codereview.chromium.org/2503213005
Cr-Commit-Position: refs/heads/master@{#433152}
(cherry picked from commit 8071e0fb15f256d446f5483f4e7457d842a16800)

Review URL: https://codereview.chromium.org/2541443003 .

Cr-Commit-Position: refs/branch-heads/2924@{#151}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/a8df270c5cd722fec11ca761fa877ddd3ebfa86a/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp

Comment 7 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt

Comment 8 by est...@chromium.org, Feb 18 2018

Labels: -Hotlist-EnamelAndFriendsFixIt

Sign in to add a comment