New issue
Advanced search Search tips

Issue 666663 link

Starred by 2 users
Status: Fixed
Owner:
thestig@chromium.org
Closed: Nov 2016
Cc:
art-sn...@yandex-team.ru
spelc...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

No progress bar when loading a PDF off of disk

Project Member Reported by thestig@chromium.org, Nov 18 2016 
What steps will reproduce the problem?
(1) Load a large (e.g. 100 MB) PDF off of disk
(2) Watch it load

What is the expected result?

Blue progress bar animation

What happens instead?

No progress bar

Regressed in r433051. Hopefully fixed with https://codereview.chromium.org/2516453003/
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c819909fea9b392532a6750f6c1559e796a5ac5

commit 2c819909fea9b392532a6750f6c1559e796a5ac5
Author: thestig <thestig@chromium.org>
Date: Fri Nov 18 23:29:05 2016

PDF: Fix progress bar for files of unknown size.

BUG= 666663 

Review-Url: https://codereview.chromium.org/2516453003
Cr-Commit-Position: refs/heads/master@{#433330}

[modify] https://crrev.com/2c819909fea9b392532a6750f6c1559e796a5ac5/pdf/pdfium/pdfium_engine.cc

Comment 2 by thestig@chromium.org, Nov 21 2016

Labels: Merge-Request-56

Comment 3 by dimu@chromium.org, Nov 21 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 21 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60ff1478a69c24d49ee16ad3d95e722b1a1cb80d

commit 60ff1478a69c24d49ee16ad3d95e722b1a1cb80d
Author: Lei Zhang <thestig@chromium.org>
Date: Mon Nov 21 07:22:02 2016

M56: PDF: Fix progress bar for files of unknown size.

BUG= 666663 

Review-Url: https://codereview.chromium.org/2516453003
Cr-Commit-Position: refs/heads/master@{#433330}
(cherry picked from commit 2c819909fea9b392532a6750f6c1559e796a5ac5)

Review URL: https://codereview.chromium.org/2514313002 .

Cr-Commit-Position: refs/branch-heads/2924@{#21}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/60ff1478a69c24d49ee16ad3d95e722b1a1cb80d/pdf/pdfium/pdfium_engine.cc

Comment 5 by thestig@chromium.org, Nov 21 2016

Status: Fixed (was: Started)
►

Sign in to add a comment