Make #ifdefs NDEBUG/IS_DCHEK_ON/ASSERT consistent. |
||
Issue descriptionChrome is not buildable in debug configuration without DCHECK macro. The problem is that different #ifdefs are not consistent in headers and sources.
,
Nov 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf362660fce245a3bf521fa2caca26b00e2f055a commit bf362660fce245a3bf521fa2caca26b00e2f055a Author: alemate <alemate@chromium.org> Date: Wed Nov 23 12:18:26 2016 WebKit: make #if DCHECK_IS_ON consistent in third_party/WebKit/Source/platform/ This CL addresses a few problems with #ifdefs: 1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON() evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON() is true, its usage must be guarded the same way. 2) If debug method in base class is defined only when DCHECK_IS_ON() is true, its descendants must be guarded with the same check. BUG= 666660 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2530493002 Cr-Commit-Position: refs/heads/master@{#434149} [modify] https://crrev.com/bf362660fce245a3bf521fa2caca26b00e2f055a/third_party/WebKit/Source/platform/Timer.cpp [modify] https://crrev.com/bf362660fce245a3bf521fa2caca26b00e2f055a/third_party/WebKit/Source/platform/Timer.h [modify] https://crrev.com/bf362660fce245a3bf521fa2caca26b00e2f055a/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp [modify] https://crrev.com/bf362660fce245a3bf521fa2caca26b00e2f055a/third_party/WebKit/Source/platform/graphics/GraphicsContext.h [modify] https://crrev.com/bf362660fce245a3bf521fa2caca26b00e2f055a/third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.h [modify] https://crrev.com/bf362660fce245a3bf521fa2caca26b00e2f055a/third_party/WebKit/Source/platform/graphics/paint/ClipPathDisplayItem.h [modify] https://crrev.com/bf362660fce245a3bf521fa2caca26b00e2f055a/third_party/WebKit/Source/platform/graphics/paint/CompositingDisplayItem.h [modify] https://crrev.com/bf362660fce245a3bf521fa2caca26b00e2f055a/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h [modify] https://crrev.com/bf362660fce245a3bf521fa2caca26b00e2f055a/third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.h [modify] https://crrev.com/bf362660fce245a3bf521fa2caca26b00e2f055a/third_party/WebKit/Source/platform/graphics/paint/FloatClipDisplayItem.h [modify] https://crrev.com/bf362660fce245a3bf521fa2caca26b00e2f055a/third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.h [modify] https://crrev.com/bf362660fce245a3bf521fa2caca26b00e2f055a/third_party/WebKit/Source/platform/graphics/paint/SubsequenceDisplayItem.h [modify] https://crrev.com/bf362660fce245a3bf521fa2caca26b00e2f055a/third_party/WebKit/Source/platform/graphics/paint/Transform3DDisplayItem.h [modify] https://crrev.com/bf362660fce245a3bf521fa2caca26b00e2f055a/third_party/WebKit/Source/platform/graphics/paint/TransformDisplayItem.h [modify] https://crrev.com/bf362660fce245a3bf521fa2caca26b00e2f055a/third_party/WebKit/Source/platform/heap/PersistentNode.cpp [modify] https://crrev.com/bf362660fce245a3bf521fa2caca26b00e2f055a/third_party/WebKit/Source/platform/heap/PersistentNode.h
,
Nov 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/debb83ad61b8ba4beb3e0508e06e2cb4e0a9e25f commit debb83ad61b8ba4beb3e0508e06e2cb4e0a9e25f Author: schenney <schenney@chromium.org> Date: Wed Nov 30 16:11:51 2016 Convert GraphicsLayer from ASSERT to DCHECK Presubmit is complaining about this file, so convert it now as a separate change. Also add missing braces. R=chrishtr@chromium.org BUG= 666660 Review-Url: https://codereview.chromium.org/2541633002 Cr-Commit-Position: refs/heads/master@{#435275} [modify] https://crrev.com/debb83ad61b8ba4beb3e0508e06e2cb4e0a9e25f/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp [modify] https://crrev.com/debb83ad61b8ba4beb3e0508e06e2cb4e0a9e25f/third_party/WebKit/Source/platform/graphics/GraphicsLayer.h
,
Dec 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5dd87e237131833c489f0b3ce5b231526318b37c commit 5dd87e237131833c489f0b3ce5b231526318b37c Author: alemate <alemate@chromium.org> Date: Fri Dec 02 05:49:29 2016 Make ifdefs consistent in WebKit/Source/core/ . This CL addresses a few problems with #ifdefs: 1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON() evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON() is true, its usage must be guarded the same way. 2) If debug method in base class is defined only when DCHECK_IS_ON() is true, its descendants must be guarded with the same check. BUG= 666660 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2513893002 Cr-Commit-Position: refs/heads/master@{#435865} [modify] https://crrev.com/5dd87e237131833c489f0b3ce5b231526318b37c/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp [modify] https://crrev.com/5dd87e237131833c489f0b3ce5b231526318b37c/third_party/WebKit/Source/core/layout/LayoutObject.cpp [modify] https://crrev.com/5dd87e237131833c489f0b3ce5b231526318b37c/third_party/WebKit/Source/core/layout/LayoutObject.h [modify] https://crrev.com/5dd87e237131833c489f0b3ce5b231526318b37c/third_party/WebKit/Source/core/svg/SVGScriptElement.cpp [modify] https://crrev.com/5dd87e237131833c489f0b3ce5b231526318b37c/third_party/WebKit/Source/core/svg/SVGScriptElement.h
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9600cd059f7aa0231a89fa2817c4ffca0454122 commit c9600cd059f7aa0231a89fa2817c4ffca0454122 Author: alemate <alemate@chromium.org> Date: Tue Dec 06 00:45:30 2016 WebKit: remove DCHECK_IS_ON from FileWriterSync. This CL removes checks for DCHECK_IS_ON in FileWriterSync as they are not used. (DCHECK macro requires its arguments to be buildable even if check itself is disabled.) So this CL fixes build in case we want debug build with DCHECKs disabled. R=nhiroki@chromium.org BUG= 666660 Review-Url: https://codereview.chromium.org/2524813003 Cr-Commit-Position: refs/heads/master@{#436473} [modify] https://crrev.com/c9600cd059f7aa0231a89fa2817c4ffca0454122/third_party/WebKit/Source/modules/filesystem/FileWriterSync.cpp [modify] https://crrev.com/c9600cd059f7aa0231a89fa2817c4ffca0454122/third_party/WebKit/Source/modules/filesystem/FileWriterSync.h
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e0e9921800ee9af57aa927e67c082db3b1f9d44 commit 4e0e9921800ee9af57aa927e67c082db3b1f9d44 Author: alemate <alemate@chromium.org> Date: Tue Dec 06 17:45:19 2016 Make ifdefs consistent in WebKit/Source/core/paint/ . This CL addresses a few problems with #ifdefs: 1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON() evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON() is true, its usage must be guarded the same way. 2) If debug method in base class is defined only when DCHECK_IS_ON() is true, its descendants must be guarded with the same check. BUG= 666660 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2550113004 Cr-Commit-Position: refs/heads/master@{#436630} [modify] https://crrev.com/4e0e9921800ee9af57aa927e67c082db3b1f9d44/third_party/WebKit/Source/core/paint/FramePainter.cpp
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/509b031245c26901d8536aff3c6f207469142101 commit 509b031245c26901d8536aff3c6f207469142101 Author: alemate <alemate@chromium.org> Date: Tue Dec 06 21:14:33 2016 Make ifdefs consistent in WebKit/Source/core/layout/ . This CL addresses a few problems with #ifdefs: 1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON() evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON() is true, its usage must be guarded the same way. 2) If debug method in base class is defined only when DCHECK_IS_ON() is true, its descendants must be guarded with the same check. BUG= 666660 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2553653003 Cr-Commit-Position: refs/heads/master@{#436725} [modify] https://crrev.com/509b031245c26901d8536aff3c6f207469142101/third_party/WebKit/Source/core/layout/LayoutBox.cpp [modify] https://crrev.com/509b031245c26901d8536aff3c6f207469142101/third_party/WebKit/Source/core/layout/LayoutObject.cpp [modify] https://crrev.com/509b031245c26901d8536aff3c6f207469142101/third_party/WebKit/Source/core/layout/LayoutObject.h [modify] https://crrev.com/509b031245c26901d8536aff3c6f207469142101/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp [modify] https://crrev.com/509b031245c26901d8536aff3c6f207469142101/third_party/WebKit/Source/core/layout/SubtreeLayoutScope.cpp [modify] https://crrev.com/509b031245c26901d8536aff3c6f207469142101/third_party/WebKit/Source/core/layout/SubtreeLayoutScope.h [modify] https://crrev.com/509b031245c26901d8536aff3c6f207469142101/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57fbc20f3f7558560780cc44a8b993f4f17d593a commit 57fbc20f3f7558560780cc44a8b993f4f17d593a Author: alemate <alemate@chromium.org> Date: Tue Dec 06 21:15:40 2016 Make ifdefs consistent in WebKit/Source/platform This CL addresses a few problems with #ifdefs: 1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON() evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON() is true, its usage must be guarded the same way. 2) If debug method in base class is defined only when DCHECK_IS_ON() is true, its descendants must be guarded with the same check. BUG= 666660 Review-Url: https://codereview.chromium.org/2552233002 Cr-Commit-Position: refs/heads/master@{#436726} [modify] https://crrev.com/57fbc20f3f7558560780cc44a8b993f4f17d593a/third_party/WebKit/Source/platform/WebThreadSupportingGC.cpp [modify] https://crrev.com/57fbc20f3f7558560780cc44a8b993f4f17d593a/third_party/WebKit/Source/platform/weborigin/SecurityPolicy.cpp
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/930defe2fb5074c1898c0d221c6d22e0d9a289b2 commit 930defe2fb5074c1898c0d221c6d22e0d9a289b2 Author: alemate <alemate@chromium.org> Date: Tue Dec 06 21:16:35 2016 Make ifdefs consistent in WebKit/Source/modules/accessibility/. This CL addresses a few problems with #ifdefs: 1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON() evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON() is true, its usage must be guarded the same way. 2) If debug method in base class is defined only when DCHECK_IS_ON() is true, its descendants must be guarded with the same check. BUG= 666660 Review-Url: https://codereview.chromium.org/2550413002 Cr-Commit-Position: refs/heads/master@{#436727} [modify] https://crrev.com/930defe2fb5074c1898c0d221c6d22e0d9a289b2/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a6c04dde993b8357457b2e2bbbd19eefc53b2ad commit 0a6c04dde993b8357457b2e2bbbd19eefc53b2ad Author: alemate <alemate@chromium.org> Date: Tue Dec 06 21:17:32 2016 Make ifdefs consistent in WebKit/Source/core/frame/. This CL addresses a few problems with #ifdefs: 1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON() evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON() is true, its usage must be guarded the same way. 2) If debug method in base class is defined only when DCHECK_IS_ON() is true, its descendants must be guarded with the same check. BUG= 666660 Review-Url: https://codereview.chromium.org/2556723002 Cr-Commit-Position: refs/heads/master@{#436728} [modify] https://crrev.com/0a6c04dde993b8357457b2e2bbbd19eefc53b2ad/third_party/WebKit/Source/core/frame/FrameView.cpp
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8302c9619f5f769c1e0b1b1f6c6afd812b0ec63f commit 8302c9619f5f769c1e0b1b1f6c6afd812b0ec63f Author: alemate <alemate@chromium.org> Date: Tue Dec 06 21:43:40 2016 spdy: DCHECK parameters should depend on DCHECK_IS_ON() macro. This CL makes the code that is used only in DCHECK to depend on DCHECK_IS_ON() macro. BUG= 666660 Review-Url: https://codereview.chromium.org/2556603003 Cr-Commit-Position: refs/heads/master@{#436744} [modify] https://crrev.com/8302c9619f5f769c1e0b1b1f6c6afd812b0ec63f/net/spdy/hpack/hpack_huffman_decoder.cc
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac4ace1275f955ff70420065fa35e0ed565281b3 commit ac4ace1275f955ff70420065fa35e0ed565281b3 Author: alemate <alemate@chromium.org> Date: Fri Dec 09 09:23:21 2016 Make ifdefs consistent in WebKit/Source/wtf/ . This CL addresses a few problems with #ifdefs: 1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON() evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON() is true, its usage must be guarded the same way. 2) If debug method in base class is defined only when DCHECK_IS_ON() is true, its descendants must be guarded with the same check. BUG= 666660 Review-Url: https://codereview.chromium.org/2550403002 Cr-Commit-Position: refs/heads/master@{#437501} [modify] https://crrev.com/ac4ace1275f955ff70420065fa35e0ed565281b3/third_party/WebKit/Source/wtf/StdLibExtras.h
,
Apr 13 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Nov 22 2016