New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666654 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

6.7%-25.2% regression in webrtc_perf_tests at 15105:15106

Project Member Reported by hlundin@chromium.org, Nov 18 2016

Issue description

Comment 2 by rbyers@chromium.org, Nov 18 2016

Labels: Performance
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/c7805dbd0ea99df91ed4c4a7fccbfeab5bafd6bc

commit c7805dbd0ea99df91ed4c4a7fccbfeab5bafd6bc
Author: sprang <sprang@webrtc.org>
Date: Fri Nov 25 16:09:43 2016

Fix perf regression in screenshare temporal layer bitrate allocation

A recent cl (https://codereview.webrtc.org/2510583002) introduced an
issue where temporal layers may return incorrect bitrates, given that
they are stateful and that the GetPreferredBitrateBps is called.
The fix is to use a temporary simulcast rate allocator instance, without
temporal layers, and get the preferred bitrate from that.

Additionally, some regression in bitrate allocated stems from overly
often reconfiguring the encoder, which yields suboptimal rate control.
The fix here is to limit encoder updates to when values have actually
changed.

As a bonus, dchecks added by this cl found a bug in the (unused) RealtimeTemporalLayers implementation. Fixed that as well.

BUG= webrtc:6301 ,  chromium:666654 

Review-Url: https://codereview.webrtc.org/2529073003
Cr-Commit-Position: refs/heads/master@{#15250}

[modify] https://crrev.com/c7805dbd0ea99df91ed4c4a7fccbfeab5bafd6bc/webrtc/modules/video_coding/codecs/vp8/realtime_temporal_layers.cc
[modify] https://crrev.com/c7805dbd0ea99df91ed4c4a7fccbfeab5bafd6bc/webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc
[modify] https://crrev.com/c7805dbd0ea99df91ed4c4a7fccbfeab5bafd6bc/webrtc/modules/video_coding/codecs/vp8/screenshare_layers.h
[modify] https://crrev.com/c7805dbd0ea99df91ed4c4a7fccbfeab5bafd6bc/webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc
[modify] https://crrev.com/c7805dbd0ea99df91ed4c4a7fccbfeab5bafd6bc/webrtc/modules/video_coding/utility/simulcast_rate_allocator.cc
[modify] https://crrev.com/c7805dbd0ea99df91ed4c4a7fccbfeab5bafd6bc/webrtc/modules/video_coding/utility/simulcast_rate_allocator_unittest.cc

Comment 4 by ivoc@chromium.org, Nov 28 2016

Cc: ivoc@chromium.org
Labels: -M-54 M-57
It looks like some of the stats made a partial recovery toward the old levels, but not completely. Is that expected? I attached the new alerts to this bug.
Status: WontFix (was: Assigned)
This has recovered, closing.

Sign in to add a comment