New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 666628 link

Starred by 1 user
Status: Fixed
Owner:
█ kozyatinskiy@chromium.org
Last visit > 30 days ago
Closed: Jun 2017
Cc:
█ mgiuca@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: ----
Type: ----



Sign in to add a comment

console-stack-overflow-source-url.html flaky (text diff)

Project Member Reported by mgiuca@chromium.org, Nov 18 2016 
webkit_tests failing on chromium.webkit/WebKit Mac10.9

Type: build-failure

Builders failed on: 
- WebKit Mac10.9: 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9

This is suspiciously similar to  Issue 666602  but it's a different file failing:
third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-stack-overflow-source-url.html

It's failing with a text diff. It seems to have started fairly recently but I can't find any recent CL that might have caused it.

I'm going to disable the test and ask kozyatinskiy@ to look at it. Thanks!
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5530d72b25717cbdfd3a37150cacb6db688bf0c5

commit 5530d72b25717cbdfd3a37150cacb6db688bf0c5
Author: mgiuca <mgiuca@chromium.org>
Date: Fri Nov 18 05:54:45 2016

Had to remove a previous line for the same file and just merge it in.

Disabled layout test console-stack-overflow-source-url.html for flake.

BUG= 666628 
NOTRY=true
TBR=kozyatinskiy@chromium.org

Review-Url: https://codereview.chromium.org/2512113002
Cr-Commit-Position: refs/heads/master@{#433126}

[modify] https://crrev.com/5530d72b25717cbdfd3a37150cacb6db688bf0c5/third_party/WebKit/LayoutTests/TestExpectations

Comment 2 by mgiuca@chromium.org, Nov 18 2016

Labels: -Sheriff-Chromium
That should take care of the failure.

Comment 3 by wangxianzhu@chromium.org, Dec 2 2016

Labels: OS-Linux
Summary: console-stack-overflow-source-url.html flaky (text diff) (was: console-stack-overflow-source-url.html flaky (text diff) on chromium.webkit/WebKit Mac10.9)
The test produced different result on the try bots than the build bots, after rebaseline. See https://codereview.chromium.org/2549843002/.

It seems to produce one of the two actual results on different bots in different runs:

Actual result 1 (on linux_chromium_rel_ng, :
CONSOLE ERROR: line 2: Uncaught RangeError: Maximum call stack size exceeded
Tests that when stack overflow happens before inspector is open source url is correctly shown in console.

foo2.js:2 Uncaught RangeError: Maximum call stack size exceeded
    at boo (foo2.js:2:2)
    ...
TEST COMPLETE

Actual result 2:
CONSOLE ERROR: line 1: Uncaught RangeError: Maximum call stack size exceeded
Tests that when stack overflow happens before inspector is open source url is correctly shown in console.

foo2.js:1 Uncaught RangeError: Maximum call stack size exceeded
    at boo (foo2.js:1:13)
    at boo (foo2.js:2:2)
    ...
TEST COMPLETE

Here are the actual results on different bots:
linux_chromium_rel_ng    1
linux_trusty_blink_rel   2
mac_chromium_rel_ng      2
mac_10.9_blink_rel       1
windows                  2

I'm not sure how "maximum stack size exceeded" works, but based on the test, stack overflow may occur either before or after the recursive call. Should the test be modified not to output text dump but to just check if there is "Maximum call stack size exceeded"?
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7fa62c57b78c4c0433f7570fe34ad16a323db47

commit e7fa62c57b78c4c0433f7570fe34ad16a323db47
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Fri Dec 02 22:09:05 2016

Manually rebaseline NeedsRebaselines on or before 12/1

This is done in the following steps:
1. Replace [ NeedsRebaseline ] with [ Rebaseline ]
2. run webkit-patch rebaseline-expectations
3. Remove the [ PRECISE ] lines from TestExpectations (caused by 660580).

For console-stack-overflow-source-url.html, because it's flaky, marked it
flaky instead of rebaselining.

BUG= 662722 , 666628 , 664782 ,475556
TBR=rebaseline under webexposed/ as the NeedsRebaselines have already been approved.

Review-Url: https://codereview.chromium.org/2549843002
Cr-Commit-Position: refs/heads/master@{#436042}

[modify] https://crrev.com/e7fa62c57b78c4c0433f7570fe34ad16a323db47/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/e7fa62c57b78c4c0433f7570fe34ad16a323db47/third_party/WebKit/LayoutTests/images/huge-image-viewport-scale-expected.txt
[modify] https://crrev.com/e7fa62c57b78c4c0433f7570fe34ad16a323db47/third_party/WebKit/LayoutTests/platform/linux/css1/pseudo/anchor-expected.png
[modify] https://crrev.com/e7fa62c57b78c4c0433f7570fe34ad16a323db47/third_party/WebKit/LayoutTests/platform/linux/svg/wicd/test-scalable-background-image2-expected.png
[delete] https://crrev.com/56c90a89889693bd6e1a7d7bb4b8f49c69bab2fd/third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/e7fa62c57b78c4c0433f7570fe34ad16a323db47/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css1/pseudo/anchor-expected.png
[delete] https://crrev.com/56c90a89889693bd6e1a7d7bb4b8f49c69bab2fd/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css1/basic/grouping-expected.png
[modify] https://crrev.com/e7fa62c57b78c4c0433f7570fe34ad16a323db47/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css1/box_properties/border_left_width-expected.png
[delete] https://crrev.com/56c90a89889693bd6e1a7d7bb4b8f49c69bab2fd/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css1/box_properties/border_top_inline-expected.png
[modify] https://crrev.com/e7fa62c57b78c4c0433f7570fe34ad16a323db47/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css1/pseudo/anchor-expected.png
[modify] https://crrev.com/e7fa62c57b78c4c0433f7570fe34ad16a323db47/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/wicd/test-scalable-background-image1-expected.png
[modify] https://crrev.com/e7fa62c57b78c4c0433f7570fe34ad16a323db47/third_party/WebKit/LayoutTests/platform/mac/css1/pseudo/anchor-expected.png
[delete] https://crrev.com/56c90a89889693bd6e1a7d7bb4b8f49c69bab2fd/third_party/WebKit/LayoutTests/platform/mac/http/tests/inspector-enabled/console-stack-overflow-source-url-expected.txt
[modify] https://crrev.com/e7fa62c57b78c4c0433f7570fe34ad16a323db47/third_party/WebKit/LayoutTests/platform/mac/svg/wicd/test-scalable-background-image2-expected.png
[modify] https://crrev.com/e7fa62c57b78c4c0433f7570fe34ad16a323db47/third_party/WebKit/LayoutTests/platform/win/css1/pseudo/anchor-expected.png
[modify] https://crrev.com/e7fa62c57b78c4c0433f7570fe34ad16a323db47/third_party/WebKit/LayoutTests/platform/win/svg/wicd/test-scalable-background-image1-expected.png
[modify] https://crrev.com/e7fa62c57b78c4c0433f7570fe34ad16a323db47/third_party/WebKit/LayoutTests/platform/win/svg/wicd/test-scalable-background-image2-expected.png
[modify] https://crrev.com/e7fa62c57b78c4c0433f7570fe34ad16a323db47/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[delete] https://crrev.com/56c90a89889693bd6e1a7d7bb4b8f49c69bab2fd/third_party/WebKit/LayoutTests/platform/win7/svg/wicd/test-scalable-background-image1-expected.png
[delete] https://crrev.com/56c90a89889693bd6e1a7d7bb4b8f49c69bab2fd/third_party/WebKit/LayoutTests/platform/win7/svg/wicd/test-scalable-background-image2-expected.png
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e617fa946919277991e615907e2617872e423c6

commit 0e617fa946919277991e615907e2617872e423c6
Author: qyearsley <qyearsley@chromium.org>
Date: Fri Apr 07 18:39:43 2017

Update test expectations for tests are recently not flaky.

This change was made automatically with update-test-expectations.

Flakiness dashboard:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=media/autoplay-muted.html,http/tests/inspector/service-workers/service-worker-manager.html,fast/text/international/inline-plaintext-relayout-with-leading-neutrals.html,http/tests/inspector/resource-tree/resource-tree-non-unique-url.html,http/tests/inspector-enabled/console-stack-overflow-source-url.html,virtual/mojo-loading/http/tests/inspector-enabled/console-stack-overflow-source-url.html,virtual/mojo-loading/http/tests/security/link-crossorigin-preload-no-cors.html,http/tests/inspector/tracing/timeline-script-parse.html,http/tests/media/media-source/mediasource-seek-beyond-duration.html,virtual/mojo-loading/http/tests/media/media-source/mediasource-seek-beyond-duration.html,external/wpt/fetch/api/redirect/redirect-location-worker.html,external/wpt/fetch/api/redirect/redirect-location.html,external/wpt/fetch/api/redirect/redirect-origin-worker.html,external/wpt/fetch/api/request/request-cache-default-conditional.html,external/wpt/service-workers/service-worker/registration-iframe.https.html

BUG= 691045 , 564403 ,651343, 581468 , 666628 ,664839, 678489 , 678490 ,705490, 697087 

Review-Url: https://codereview.chromium.org/2800123002
Cr-Commit-Position: refs/heads/master@{#462938}

[modify] https://crrev.com/0e617fa946919277991e615907e2617872e423c6/third_party/WebKit/LayoutTests/TestExpectations

Comment 6 by kozyatinskiy@chromium.org, Jun 15 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment