New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666625 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Misplaced notification bar overlay is seen on clicking notification icon

Project Member Reported by sandeepkumars@chromium.org, Nov 18 2016

Issue description

Version: Started Working on 56.0.2923.0/8999.0 dev-channel Falco,Gnawty and Blaze
OS: Chrome

What steps will reproduce the problem?
(1) Sign in to user>> go to notification bar overlay on bottom right>> click on it>> and observe

Expected: Misplaced notification bar overlay should not be seen on clicking
Actual: Instead misplacement is seen 

This is a Regression issue as no misplacement is seen in M55: 55.0.2883.54/8872.54.0 beta-channel Gnawty

Issue is not applicable to Linux and Windows

@Yoshiki: Please confirm the behavior

 
Expected notifi.png
238 KB View Download
Actual Notifi.png
257 KB View Download
Cc: sgabr...@chromium.org
Status: WontFix (was: Assigned)
I think the change was intended: http://crrev.com/432567

+Sebastien, could you let me know if this change is not intended?
Cc: est...@chromium.org
Status: Assigned (was: WontFix)
Re-opening this. 

So at the time I wanted the panel to be aligned to the right edge, and didn't understood that the notification panel would be affected.

Can we keep this behavior for panels but make an exception for the notification center only, re-aligning it as before?

Sorry for the back and forth.

Comment 3 by est...@chromium.org, Nov 29 2016

Cc: dhadd...@chromium.org sdantul...@chromium.org xiy...@chromium.org
 Issue 667842  has been merged into this issue.

Comment 4 by est...@chromium.org, Nov 29 2016

Owner: est...@chromium.org
ok.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cda46b04bb3184f699ad9dd44dcebe94fd6f5a59

commit cda46b04bb3184f699ad9dd44dcebe94fd6f5a59
Author: estade <estade@chromium.org>
Date: Thu Dec 01 22:06:16 2016

Justify the message center to the right of the screen (i.e. the same
place as the system menu).

BUG= 666625 

Review-Url: https://codereview.chromium.org/2540053002
Cr-Commit-Position: refs/heads/master@{#435733}

[modify] https://crrev.com/cda46b04bb3184f699ad9dd44dcebe94fd6f5a59/ash/common/system/web_notification/web_notification_tray.cc

Status: Started (was: Assigned)
Labels: Proj-MaterialDesign-CrOS Merge-Request-56
Labels: Merge-Approved-56

Comment 9 by dimu@chromium.org, Dec 2 2016

Labels: -Merge-Request-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Verified in 57.0.2939.0 canary.
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 2 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f56dd541d1b1ee78c0a1c34910b204e440f0d293

commit f56dd541d1b1ee78c0a1c34910b204e440f0d293
Author: Terry Anderson <tdanderson@chromium.org>
Date: Fri Dec 02 22:30:41 2016

Justify the message center to the right of the screen (i.e. the same place as the system menu).

BUG= 666625 

Review-Url: https://codereview.chromium.org/2540053002
Cr-Commit-Position: refs/heads/master@{#435733}
(cherry picked from commit cda46b04bb3184f699ad9dd44dcebe94fd6f5a59)

Review URL: https://codereview.chromium.org/2551443003 .

Cr-Commit-Position: refs/branch-heads/2924@{#305}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/f56dd541d1b1ee78c0a1c34910b204e440f0d293/ash/common/system/web_notification/web_notification_tray.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on 56.0.2924.26/9000.26.0   57.0.29460/9065.0.0

Status: Assigned (was: Verified)
Reopening as issue is still seen on the lock screen
IMG_6959.JPG
125 KB View Download
Project Member

Comment 15 by bugdroid1@chromium.org, Dec 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8522fd00254ba2e136b89f60efb0bb6da4b7b707

commit 8522fd00254ba2e136b89f60efb0bb6da4b7b707
Author: estade <estade@chromium.org>
Date: Mon Dec 19 21:43:42 2016

CrOS - Fix position of notification bubble for lock screen.

In this case the alignment enum value is SHELF_ALIGNMENT_BOTTOM_LOCKED.

BUG= 666625 

Review-Url: https://codereview.chromium.org/2589493007
Cr-Commit-Position: refs/heads/master@{#439577}

[modify] https://crrev.com/8522fd00254ba2e136b89f60efb0bb6da4b7b707/ash/common/system/web_notification/web_notification_tray.cc

Labels: -Hotlist-Merge-Approved -merge-merged-2924 Merge-Request-56
merge request for https://crrev.com/8522fd00254ba2e136b89f60efb0bb6da4b7b707

Comment 17 by dimu@chromium.org, Dec 29 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 18 by bugdroid1@chromium.org, Dec 29 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b30a3f73963c02bfc081e0178af9e3a27b5b65d

commit 6b30a3f73963c02bfc081e0178af9e3a27b5b65d
Author: Evan Stade <estade@chromium.org>
Date: Thu Dec 29 21:43:37 2016

CrOS - Fix position of notification bubble for lock screen.

In this case the alignment enum value is SHELF_ALIGNMENT_BOTTOM_LOCKED.

BUG= 666625 

Review-Url: https://codereview.chromium.org/2589493007
Cr-Commit-Position: refs/heads/master@{#439577}
(cherry picked from commit 8522fd00254ba2e136b89f60efb0bb6da4b7b707)

Review-Url: https://codereview.chromium.org/2602143002 .
Cr-Commit-Position: refs/branch-heads/2924@{#633}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/6b30a3f73963c02bfc081e0178af9e3a27b5b65d/ash/common/system/web_notification/web_notification_tray.cc

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment