New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666619 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Integer-overflow in sfntly::LocaTable::GlyphLength

Project Member Reported by ClusterFuzz, Nov 18 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6066599279984640

Fuzzer: libfuzzer_sfntly_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  sfntly::LocaTable::GlyphLength
  ResolveCompositeGlyphs
  sfntly::SubsetterImpl::SubsetFont
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=417039:417261

Minimized Testcase (0.82 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96hhmZ4RLYFeq_r78wICabHcdMFwBQSlXfMwp_Cl5BgoQ3XJs6apUzT6iYBtTuIPmVJ_qmWHioVUONEIgj4hILxEaQgLS2BekTPCgLFLFCZj-1KGiY3OOSrTE1hc4SnMymasq35PyJdEIPp-ncA_SPQFBEcTw?testcase_id=6066599279984640

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 

Comment 1 by ajha@chromium.org, Nov 18 2016

Labels: M-55
Project Member

Comment 2 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: msrchandra@chromium.org
Components: Infra>Git
Labels: Test-Predator-Wrong-CLs
Owner: thestig@chromium.org
Status: Assigned (was: Untriaged)
Unable to find the possible suspect from Find it.
Using the regression assigning to the concern owner, below is the regressed range -
https://chromium.googlesource.com/chromium/src/+log/c5746d7187c438798396fa2a5148de199ec7a4bb..10bcb7faee41e73e6d9396948a7b75a44a1c2038?pretty=fuller

Suspecting the Commit# 
https://chromium.googlesource.com/chromium/src/+/8fe11cb88b21b7e1c3a8830249ab30c72d556bd7

@thestig -- Could you please look into the issue, kindly re-assign if this is not related to your change.
Thank You.
Components: -Infra>Git Internals>Skia>PDF

Comment 5 Deleted

Status: Started (was: Assigned)
https://github.com/googlei18n/sfntly/pull/75
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83d38421f79045fef26de00d4c76198c06067852

commit 83d38421f79045fef26de00d4c76198c06067852
Author: thestig <thestig@chromium.org>
Date: Tue Mar 28 19:27:17 2017

Roll DEPS for sfntly de3cce5..04740d2

04740d2 Merge pull request #75 from leizleiz/morefixes
0c9b2fd Fix nits in OTFBasicEditing test.
3723ffd Fix ReadableFontData::ReadDateTimeAsLong().
126f3b3 Fix assert failures in HorizontalMetricsTable.
8fcbf51 Check offsets in FontFactory::LoadCollectionForBuilding().
b95a8f4 Avoid integer overflow in LocaTable::GlyphLength().
cccd3aa Check for integer overflow in SetupGlyfBuilders.
f1384b2 Fix more NULL pointer derefs in sfntly::Font::Builder.
7525f24 Revert commit 3e3a91a.

BUG= 659936 ,663737, 666619 , 669806 , 699510 , 705357 
TBR=behdad@chromium.org,jshin@chromium.org

Review-Url: https://codereview.chromium.org/2784563002
Cr-Commit-Position: refs/heads/master@{#460186}

[modify] https://crrev.com/83d38421f79045fef26de00d4c76198c06067852/DEPS

Status: Fixed (was: Started)
Project Member

Comment 9 by ClusterFuzz, Mar 29 2017

ClusterFuzz has detected this issue as fixed in range 460148:460187.

Detailed report: https://clusterfuzz.com/testcase?key=6066599279984640

Fuzzer: libfuzzer_sfntly_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  sfntly::LocaTable::GlyphLength
  ResolveCompositeGlyphs
  sfntly::SubsetterImpl::SubsetFont
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=417039:417261
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=460148:460187

Reproducer Testcase: https://clusterfuzz.com/download/AMIfv9679G7D35_ai9ARoGZcUu8So0_cz3QxxQYhzTrdQFrhLZLdbGFJqzR5aZgvO5oWb_vem0w-_Jf80nppIaBTtNVhfEmUxli35yqDm6n8QfCbNeKqJ-DD_LEKa9wEhtnWnOwMAu5YcpEMbO3lXG9vVM1LWtZ_vWRzqT6fGELhus89kqYH2Q_MSiSmPQalSOl6jSm2gSC59gYvd5rc5Ig3_HHNrKuNgDbAOt_SMQFCjVPrk2Z0cW9faTBE6u_JWNA_a1lNPujZF4S7CtVaFJglTCRh5y731gvQriS__uOpyNtlnyB9mINq52WmnpHW54RFLEAEUOd1pwvKmtRoBbumLtmKivcO_G6Dy1wTaDMuH1TPz6PIeO0?testcase_id=6066599279984640


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Sign in to add a comment