https://chromium.googlesource.com/chromium/src/+log/9c48d1d4786798ab90251e4131a2e808faffe525..6d799882e49984de8620d41c53893101eaed92f6 -> r420238. r420233 is in the regression range too, but it's only got 1 CL in the roll and that's not it.

I bisected with: tools/bisect-builds.py -a linux64 -g 414607 -b 423768 --use-local-cache --verify-range -p /tmp/foobar

I would repeat about 10 times before declaring a build to be "good". Sometimes I hit this error on the first try.

See also  bug 666426 .

Given how often I can hit this on Chrome 55, if I repeatedly print preview, we definitely want to fix this before it goes to stable channel.

A friendly reminder that M55 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!

Also due to Thanksgiving holidays in US, please make sure fix is ready and merged to M55 latest by 5:00 PM PT Wednesday, 11/23/16 (sooner the better).

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b12aba73d3525867511b315a45d2dbc65acd2647

commit b12aba73d3525867511b315a45d2dbc65acd2647
Author: rbpotter <rbpotter@chromium.org>
Date: Sat Nov 19 07:09:57 2016

Fix CrOS reverting to Save as PDF and random PDF preview fail

Increasing number of saved destinations caused a bug on Chrome OS -
destination always reverted to Save as PDF.

Also caused random "PDF failed to load" preview errors. This occurred
since the destinations were modified one after the other too quickly,
which caused a race condition that crashed PDF preview. This error
occurred ~1 in 10 times.

BUG= 665455 , 666426 , 666595 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2516523002
Cr-Commit-Position: refs/heads/master@{#433408}

[modify] https://crrev.com/b12aba73d3525867511b315a45d2dbc65acd2647/chrome/browser/resources/print_preview/data/app_state.js
[modify] https://crrev.com/b12aba73d3525867511b315a45d2dbc65acd2647/chrome/browser/resources/print_preview/data/destination_store.js

**** Bulk edit -  please ignore if not applicable ****

A friendly reminder that M55 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch latest by November 25th, 5:00 PM PST in order to make into the desktop Stable final build cut. Thank you!

 Issue 666426  has been merged into this issue.

I confirmed in a local build that the PDF plugin used for print preview is no longer getting multiple preview requests. Thus no more race condition.

I imagine this is really OS-All, but I haven't tested on Win/Mac. I will likely merge  bug 665455  (ChromeOS) into this bug as well as soon as I confirm it's fixed.

Your change meets the bar and is auto-approved for M56 (branch: 2924)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/889ca692836950b471a5bdc08608e2edcdf4696a

commit 889ca692836950b471a5bdc08608e2edcdf4696a
Author: Lei Zhang <thestig@chromium.org>
Date: Mon Nov 21 06:58:39 2016

M56: Fix CrOS reverting to Save as PDF and random PDF preview fail

Increasing number of saved destinations caused a bug on Chrome OS -
destination always reverted to Save as PDF.

Also caused random "PDF failed to load" preview errors. This occurred
since the destinations were modified one after the other too quickly,
which caused a race condition that crashed PDF preview. This error
occurred ~1 in 10 times.

BUG= 665455 , 666426 , 666595 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2516523002
Cr-Commit-Position: refs/heads/master@{#433408}
(cherry picked from commit b12aba73d3525867511b315a45d2dbc65acd2647)

Review URL: https://codereview.chromium.org/2514303002 .

Cr-Commit-Position: refs/branch-heads/2924@{#19}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/889ca692836950b471a5bdc08608e2edcdf4696a/chrome/browser/resources/print_preview/data/app_state.js
[modify] https://crrev.com/889ca692836950b471a5bdc08608e2edcdf4696a/chrome/browser/resources/print_preview/data/destination_store.js

Let's try a M56 build in a day or two, verify this is fixed and then merge to M55.

Thank you Lei. Please request a merge to M55 as soon as change looks good in Canary and on M56 (I'm not sure there will be M56 dev release this week or not as it is a no release week).

As long as there are M56 builds being built, then there should be one today or tomorrow that have the merge from above. We can grab that and test it out locally.

M56 build scheduled to trigger @ 6:00 PM PT daily. So you can test tomorrow on M56.

Rechecked this issues on chrome version 56.0.2924.3 on Ubuntu 14.04, followed the below steps:

(1) Launched chrome and navigated to sample pdf file and did a Print preview
(2) Signed in to get access to cloud print printers
(3) Selected the "Save to Google Drive" cloud destination
(4) Cancel print preview
(5) Tried print preview again
(6) Repeated cancel operation and print preview operation for 15 to 20 times 

Every time preview showed up without showing any error message. Repeated the same for a website as well. No issues observed.

Fix is working as intended, adding TE-Verified labels.

Your change meets the bar and is auto-approved for M55 (branch: 2883)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03dfb68a8d7f607a19a3a5f53319c02b899f7d3f

commit 03dfb68a8d7f607a19a3a5f53319c02b899f7d3f
Author: Lei Zhang <thestig@chromium.org>
Date: Tue Nov 22 10:06:34 2016

M55: Fix CrOS reverting to Save as PDF and random PDF preview fail

Increasing number of saved destinations caused a bug on Chrome OS -
destination always reverted to Save as PDF.

Also caused random "PDF failed to load" preview errors. This occurred
since the destinations were modified one after the other too quickly,
which caused a race condition that crashed PDF preview. This error
occurred ~1 in 10 times.

BUG= 665455 , 666426 , 666595 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2516523002
Cr-Commit-Position: refs/heads/master@{#433408}
(cherry picked from commit b12aba73d3525867511b315a45d2dbc65acd2647)

Review URL: https://codereview.chromium.org/2518303002 .

Cr-Commit-Position: refs/branch-heads/2883@{#646}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/03dfb68a8d7f607a19a3a5f53319c02b899f7d3f/chrome/browser/resources/print_preview/data/app_state.js
[modify] https://crrev.com/03dfb68a8d7f607a19a3a5f53319c02b899f7d3f/chrome/browser/resources/print_preview/data/destination_store.js

 Issue 665455  has been merged into this issue.

Rechecked the issue on Ubuntu 14.04 for chrome M55 version 55.0.2883.70 as followed in comment#15. Merge is working as intended. Adding TE-Verified labels.