New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666593 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

compile failing on ios-*-xcode-clang (/usr/bin/java missing)

Project Member Reported by mgiuca@chromium.org, Nov 18 2016

Issue description

compile failing on 2 builders

Type: build-failure

Builders failed on: 
- ios-device-xcode-clang: 
  https://build.chromium.org/p/chromium.mac/builders/ios-device-xcode-clang
- ios-simulator-xcode-clang: 
  https://build.chromium.org/p/chromium.mac/builders/ios-simulator-xcode-clang

These two bots just spun up (these are builds #0 for both). Not sure what caused that.

It looks like /usr/bin/java is not present on these machines.

Example failure:

[134/20713] ACTION //components/translate/ios/browser:injected_js_compile_js(//build/toolchain/mac:ios_clang_x64)
FAILED: gen/components/translate/ios/browser/translate_ios.js 
python ../../build/util/java_action.py -jar ../../third_party/closure_compiler/compiler/compiler.jar --compilation_level SIMPLE_OPTIMIZATIONS --jscomp_error=checkTypes --jscomp_error=checkVars --jscomp_error=missingProperties --jscomp_error=undefinedVars --jscomp_error=accessControls --jscomp_error=ambiguousFunctionDecl --jscomp_error=constantProperty --jscomp_error=deprecated --jscomp_error=externsValidation --jscomp_error=globalThis --jscomp_error=invalidCasts --jscomp_error=missingReturn --jscomp_error=nonStandardJsDocs --jscomp_error=suspiciousCode --jscomp_error=undefinedNames --jscomp_error=unknownDefines --jscomp_error=uselessCode --jscomp_error=visibility --module_output_path_prefix gen/components/translate/ios/browser/ --js ../../ios/web/web_state/js/resources/base.js --module base_module:1 --js ../../ios/web/web_state/js/resources/common.js --module common_module:1:base_module --js ../../ios/web/web_state/js/resources/message.js --module message_module:1:common_module --js ../../components/translate/ios/browser/resources/translate_ios.js --module translate_ios:1:common_module:message_module
No Java runtime present, requesting install.
Traceback (most recent call last):
  File "../../build/util/java_action.py", line 82, in <module>
    sys.exit(main())
  File "../../build/util/java_action.py", line 78, in main
    return subprocess.check_call([java_path] + args)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/usr/bin/java', '-jar', '../../third_party/closure_compiler/compiler/compiler.jar', '--compilation_level', 'SIMPLE_OPTIMIZATIONS', '--jscomp_error=checkTypes', '--jscomp_error=checkVars', '--jscomp_error=missingProperties', '--jscomp_error=undefinedVars', '--jscomp_error=accessControls', '--jscomp_error=ambiguousFunctionDecl', '--jscomp_error=constantProperty', '--jscomp_error=deprecated', '--jscomp_error=externsValidation', '--jscomp_error=globalThis', '--jscomp_error=invalidCasts', '--jscomp_error=missingReturn', '--jscomp_error=nonStandardJsDocs', '--jscomp_error=suspiciousCode', '--jscomp_error=undefinedNames', '--jscomp_error=unknownDefines', '--jscomp_error=uselessCode', '--jscomp_error=visibility', '--module_output_path_prefix', 'gen/components/translate/ios/browser/', '--js', '../../ios/web/web_state/js/resources/base.js', '--module', 'base_module:1', '--js', '../../ios/web/web_state/js/resources/common.js', '--module', 'common_module:1:base_module', '--js', '../../ios/web/web_state/js/resources/message.js', '--module', 'message_module:1:common_module', '--js', '../../components/translate/ios/browser/resources/translate_ios.js', '--module', 'translate_ios:1:common_module:message_module']' returned non-zero exit status 1

 

Comment 1 by ddoman@chromium.org, Nov 18 2016

/usr/bin/java exists in vm108-m1

vm108-m1:$ which java
/usr/bin/java

Comment 2 by mgiuca@chromium.org, Nov 18 2016

Labels: -Sheriff-Chromium
Removing from sheriff queue (this is an infra issue).

Comment 3 by mgiuca@chromium.org, Nov 18 2016

Owner: smut@chromium.org
And assigning to smut@ who configured these bots I believe.

Comment 4 by s...@google.com, Nov 18 2016

Cc: d...@chromium.org chrome-labs@google.com
Components: Infra>Labs
Owner: ----
Status: Untriaged (was: Available)
These were set up in https://crbug.com/664700. Can we get Java installed? Thanks.
Cc: fsam...@chromium.org est...@chromium.org
 Issue 666667  has been merged into this issue.

Comment 6 by d...@chromium.org, Nov 18 2016

Owner: d...@chromium.org
Status: Fixed (was: Untriaged)
Was under the impression Java wasn't a requirement anymore on Macs in a previous ticket ( bug 616804 ), guess that's not the case.

Both VMs now have java now.


Cc: friedman@chromium.org
Status: Assigned (was: Fixed)
Fixing these as a one-off kinda sucks.  Can we install Java via puppet?
dba@ do you want me to do this with cipd on all macs?
Ping - please provide an update to your high priority bug. This bug is stale. Is it really P-1?

Comment 10 by d...@chromium.org, Feb 14 2017

Labels: -Pri-1 Pri-3
Owner: friedman@chromium.org
No, I never put this as a P1, it was re-opened as such.

friedman - This was a minimal change (java was only removed for a short time) but if you want to go through making this distributed through puppet + cipd go for it.
This is a little tricky with cipd+puppet.  The dmg would go in a cipd package, then puppet could run some execs to install it, but then the cipd resource should go away, and puppet doesn't like that.  I don't know if this is worth it if the java install is going to be defined in setup.sh anyway.
Status: Archived (was: Assigned)

Sign in to add a comment