"Display overscan" on-screen arrows remain on screen indefinitely after exiting the page |
||||
Issue descriptionNot sure whether this is specific to CrOS on Linux, but: 1. chrome://md-settings/display 2. Tap to adjust overscan borders 3. Exit the page (back arrow, close the browser window, navigate to another website) without hitting "Save" or "Reset" on the overscan dialog Expected: Overscan border arrows should disappears after leaving the Display sub-page Actual: Overscan border arrows don't disappear even after closing the entire tab
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f2b71add2ce71f468fb8274c20d7ea41d36886b commit 8f2b71add2ce71f468fb8274c20d7ea41d36886b Author: stevenjb <stevenjb@chromium.org> Date: Fri Dec 09 03:21:11 2016 SystemDisplayApi: Introdice OverscanTracker The system.display.overscanCalibrationStart method displays an overlay for adjusting overscan when called. If the web context initiating the call is deleted before overscanCalibrationComplete is called, the overaly will remain with no way to remove it (without running Settings or an app that shows and removes the overaly correctly). This change creates a tracker so that if the render frame is deleted before overscanCalibrationComplete is called, the calibration will be reset and completed to remove the overlay. BUG= 666590 Review-Url: https://codereview.chromium.org/2558453004 Cr-Commit-Position: refs/heads/master@{#437448} [modify] https://crrev.com/8f2b71add2ce71f468fb8274c20d7ea41d36886b/extensions/browser/api/system_display/BUILD.gn [modify] https://crrev.com/8f2b71add2ce71f468fb8274c20d7ea41d36886b/extensions/browser/api/system_display/system_display_api.cc [modify] https://crrev.com/8f2b71add2ce71f468fb8274c20d7ea41d36886b/extensions/browser/api/system_display/system_display_apitest.cc [add] https://crrev.com/8f2b71add2ce71f468fb8274c20d7ea41d36886b/extensions/test/data/system/display/overscan/manifest.json [add] https://crrev.com/8f2b71add2ce71f468fb8274c20d7ea41d36886b/extensions/test/data/system/display/overscan/test_overscan.js [add] https://crrev.com/8f2b71add2ce71f468fb8274c20d7ea41d36886b/extensions/test/data/system/display/overscan_no_complete/manifest.json [add] https://crrev.com/8f2b71add2ce71f468fb8274c20d7ea41d36886b/extensions/test/data/system/display/overscan_no_complete/test_overscan_no_complete.js
,
Dec 9 2016
,
Mar 4 2017
,
Apr 6 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by steve...@chromium.org
, Dec 1 2016Status: Started (was: Assigned)