Some subpages cause the main page to scroll to top when they're opened |
||||
Issue description1. chrome://md-settings 2. tap "Manage search engines" 3. section begins expanding to fill the page Expected: Animation plays smoothly. Actual: The main page immediately jumps to the top when the animation starts. Explanation: Some subpages, like "Manage search engines", have an <iron-list> whose scroll-target gets set to the global scroll target -- the paper header panel's #mainContainer. When one of these subpages come into existence, its iron-list gets resized, which triggers the iron-list#scrollToIndex() method, which resets the global scroll target to 0. This may also repro with the Passwords list, but you might need to actually have passwords added?
,
Dec 1 2016
Issue 670228 has been merged into this issue.
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b681a62a2606b9cd7299df02b150f1cf349dbbf1 commit b681a62a2606b9cd7299df02b150f1cf349dbbf1 Author: hcarmona <hcarmona@chromium.org> Date: Tue Dec 06 18:44:16 2016 Fix issue caused by updating list that references global scroll target. An iron-list in a subpage should only look at the global scroll target when the subpage has been navigated to. Scroll position of the basic/advanced page could be lost when an iron-list was updated if it wasn't visible. BUG= 666582 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2538183008 Cr-Commit-Position: refs/heads/master@{#436658} [modify] https://crrev.com/b681a62a2606b9cd7299df02b150f1cf349dbbf1/chrome/browser/resources/settings/compiled_resources2.gyp [modify] https://crrev.com/b681a62a2606b9cd7299df02b150f1cf349dbbf1/chrome/browser/resources/settings/global_scroll_target_behavior.html [modify] https://crrev.com/b681a62a2606b9cd7299df02b150f1cf349dbbf1/chrome/browser/resources/settings/global_scroll_target_behavior.js [modify] https://crrev.com/b681a62a2606b9cd7299df02b150f1cf349dbbf1/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html [modify] https://crrev.com/b681a62a2606b9cd7299df02b150f1cf349dbbf1/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js [modify] https://crrev.com/b681a62a2606b9cd7299df02b150f1cf349dbbf1/chrome/browser/resources/settings/search_engines_page/search_engines_list.html [modify] https://crrev.com/b681a62a2606b9cd7299df02b150f1cf349dbbf1/chrome/browser/resources/settings/search_engines_page/search_engines_list.js
,
Dec 9 2016
,
Dec 14 2016
Verified on 9083.0.0, 57.0.2950.0
,
Dec 14 2016
comment #5 is on ChromeOS |
||||
►
Sign in to add a comment |
||||
Comment 1 by dbeam@chromium.org
, Nov 22 2016Status: Assigned (was: Untriaged)