New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666561 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 621383
issue 651282



Sign in to add a comment

Replace TypeConverters in device/bluetooth

Project Member Reported by mbrunson@chromium.org, Nov 18 2016

Issue description

device/bluetooth/adapter.cc uses
device/bluetooth/public/interfaces/connect_result_type_converter.h
to convert between 
 bluetooth::mojom::ConnectResult and 
 device::BluetoothDevice::ConnectErrorCode.

device/bluetooth/device.cc uses
device/bluetooth/public/interfaces/gatt_result_type_converter.h
to convert between
 bluetooth::mojom::GattResult and
 device::BluetoothGattService::GattErrorCode.

These TypeConverters should be replaced as soon as possible as TypeConverter is deprecated.

The code currently uses TypeConverters because mojom values are a superset of the corresponding C++ enum.

E.g. GattResult has more values than GattErrorCode: SUCCESS (and possibly
more such as SERVICE_NOT_FOUND, CHARACTERISTIC_NOT_FOUND, or
DESCRIPTOR_NOT_FOUND.
 
Blocking: 651282
Summary: Replace TypeConverters in device/bluetooth (was: Replace ConnectResult TypeConverters)
Description: Show this description

Comment 4 by scheib@chromium.org, Jan 24 2017

Description: Show this description

Comment 5 by scheib@chromium.org, Jan 24 2017

Blocking: 621383
Cc: scheib@chromium.org ortuno@chromium.org

Comment 7 by scheib@chromium.org, Feb 16 2017

Status: Available (was: Untriaged)

Comment 8 Deleted

Hi,
I am interested to work on this.
IIUC, we need to remove typeconverters and use EnumTriats.
Please let me know if i can work on this.
Cc: -scheib@chromium.org
Status: Assigned (was: Available)
Owner: ----

Sign in to add a comment