Paladin masters that fail emit links to the slaves that failed. These are buildbot links. Instead, we can start experiment with using milo instead and replace them with milo links. This probably means we go to cbuildbot and rewrite the GetDashboardURL method so that it knows to construct a milo url like https://luci-milo.appspot.com/buildbot/chromeos/auron-paladin/8815 instead of a buildbot one like https://uberchromegw.corp.google.com/i/chromeos/builders/auron-paladin/builds/8815
Blocking issue: if we do this, developers who have never logged in to milo are going to see 404s are be confused. hinoka@ how do we solve the first-time-login problem?
Aviv, please find a right owner of this bug.
First time login issue is in review: https://codereview.chromium.org/2525493002 Fix is just to customize the 404 page
Ok, I have a CL that will turn on milo links that we can land after that. https://chromium-review.googlesource.com/#/c/413003/
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/2b85e2e02789e4f20bfd0200569382e0faeb872c commit 2b85e2e02789e4f20bfd0200569382e0faeb872c Author: hinoka <hinoka@google.com> Date: Thu Dec 01 21:13:53 2016 Milo: Add themed page for errors This way people navigating to 404's will still see the "sign in" link. BUG= 666551 Review-Url: https://codereview.chromium.org/2525493002 [modify] https://crrev.com/2b85e2e02789e4f20bfd0200569382e0faeb872c/milo/appengine/buildbot/build.go [modify] https://crrev.com/2b85e2e02789e4f20bfd0200569382e0faeb872c/milo/appengine/buildbot/build_test.go [modify] https://crrev.com/2b85e2e02789e4f20bfd0200569382e0faeb872c/milo/appengine/buildbot/builder.go [modify] https://crrev.com/2b85e2e02789e4f20bfd0200569382e0faeb872c/milo/appengine/buildbot/html.go [modify] https://crrev.com/2b85e2e02789e4f20bfd0200569382e0faeb872c/milo/appengine/buildbot/master.go [modify] https://crrev.com/2b85e2e02789e4f20bfd0200569382e0faeb872c/milo/appengine/frontend/expectations/buildbot-buildbot.TestableBuild-Debug_page-_CrWinGoma_30608.html [modify] https://crrev.com/2b85e2e02789e4f20bfd0200569382e0faeb872c/milo/appengine/frontend/expectations/buildbot-buildbot.TestableBuild-Debug_page-_win_chromium_rel_ng_246309.html [modify] https://crrev.com/2b85e2e02789e4f20bfd0200569382e0faeb872c/milo/appengine/frontend/expectations/buildbot-buildbot.TestableBuilder-Basic_Test_no_builds.html [modify] https://crrev.com/2b85e2e02789e4f20bfd0200569382e0faeb872c/milo/appengine/frontend/expectations/buildbot-buildbot.TestableBuilder-Basic_Test_with_builds.html [modify] https://crrev.com/2b85e2e02789e4f20bfd0200569382e0faeb872c/milo/appengine/frontend/expectations/buildbot-frontend.testableFrontpage-Basic_frontpage.html [modify] https://crrev.com/2b85e2e02789e4f20bfd0200569382e0faeb872c/milo/appengine/frontend/expectations/buildbot-settings.TestableSettings-Settings.html [modify] https://crrev.com/2b85e2e02789e4f20bfd0200569382e0faeb872c/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-Basic_successful_build.html [modify] https://crrev.com/2b85e2e02789e4f20bfd0200569382e0faeb872c/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-canceled.html [modify] https://crrev.com/2b85e2e02789e4f20bfd0200569382e0faeb872c/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-exception.html [modify] https://crrev.com/2b85e2e02789e4f20bfd0200569382e0faeb872c/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-expired.html [modify] https://crrev.com/2b85e2e02789e4f20bfd0200569382e0faeb872c/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-link.html [modify] https://crrev.com/2b85e2e02789e4f20bfd0200569382e0faeb872c/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-nested.html [modify] https://crrev.com/2b85e2e02789e4f20bfd0200569382e0faeb872c/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-patch-failure.html [modify] https://crrev.com/2b85e2e02789e4f20bfd0200569382e0faeb872c/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-pending.html [modify] https://crrev.com/2b85e2e02789e4f20bfd0200569382e0faeb872c/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-running.html [modify] https://crrev.com/2b85e2e02789e4f20bfd0200569382e0faeb872c/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-timeout.html [modify] https://crrev.com/2b85e2e02789e4f20bfd0200569382e0faeb872c/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-unicode.html [modify] https://crrev.com/2b85e2e02789e4f20bfd0200569382e0faeb872c/milo/appengine/frontend/expectations/buildbot-swarming.TestableLog-Basic_log.html [modify] https://crrev.com/2b85e2e02789e4f20bfd0200569382e0faeb872c/milo/appengine/frontend/milo_test.go [add] https://crrev.com/2b85e2e02789e4f20bfd0200569382e0faeb872c/milo/appengine/frontend/templates/bootstrap/pages/error.html [add] https://crrev.com/2b85e2e02789e4f20bfd0200569382e0faeb872c/milo/appengine/frontend/templates/buildbot/pages/error.html [modify] https://crrev.com/2b85e2e02789e4f20bfd0200569382e0faeb872c/milo/appengine/settings/themes.go
Comment 1 by akes...@chromium.org
, Nov 18 2016