New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 666548 link

Starred by 2 users
Status: Fixed
Owner:
weili@chromium.org
Closed: Aug 2017
Cc:
█ nasko@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Rename PrintWebViewHelper to PrintWebFrameHelper

Project Member Reported by thestig@chromium.org, Nov 18 2016 
As of r432775, PrintWebViewHelper is really PrintWebFrameHelper, but I did not want to do the renaming in that CL since renaming requires a lot of churn. Let's do the renaming in a few weeks, when we are sure the CL won't get reverted, and we've done merges for any additional bug fixes that's needed.

Comment 1 by weili@chromium.org, Jul 15 2017

Cc: -weili@chromium.org
Owner: weili@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1324644aa79fd0fde00690ed4220e7cce7782e98

commit 1324644aa79fd0fde00690ed4220e7cce7782e98
Author: Wei Li <weili@chromium.org>
Date: Sat Jul 29 03:13:40 2017

Rename PrintWebViewHelper to PrintRenderFrameHelper (I of II)

PrintWebFrameHelp will be a better name since this class is associated
with render frame, not web view any more. This CL rename the file names
only to prepare for the class name change, since changing file names and
class names at the same time will lost file history.

TBR=jam@chromium.org
BUG= chromium:666548 

Change-Id: I72ed2ec5677ebab37a25ae5b0b79dcb66a5b96da
Reviewed-on: https://chromium-review.googlesource.com/583582
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490602}
[modify] https://crrev.com/1324644aa79fd0fde00690ed4220e7cce7782e98/android_webview/BUILD.gn
[modify] https://crrev.com/1324644aa79fd0fde00690ed4220e7cce7782e98/android_webview/renderer/aw_content_renderer_client.cc
[rename] https://crrev.com/1324644aa79fd0fde00690ed4220e7cce7782e98/android_webview/renderer/aw_print_render_frame_helper_delegate.cc
[rename] https://crrev.com/1324644aa79fd0fde00690ed4220e7cce7782e98/android_webview/renderer/aw_print_render_frame_helper_delegate.h
[modify] https://crrev.com/1324644aa79fd0fde00690ed4220e7cce7782e98/android_webview/renderer/print_render_frame_observer.cc
[modify] https://crrev.com/1324644aa79fd0fde00690ed4220e7cce7782e98/chrome/renderer/BUILD.gn
[modify] https://crrev.com/1324644aa79fd0fde00690ed4220e7cce7782e98/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/1324644aa79fd0fde00690ed4220e7cce7782e98/chrome/renderer/chrome_render_frame_observer.cc
[modify] https://crrev.com/1324644aa79fd0fde00690ed4220e7cce7782e98/chrome/renderer/pepper/chrome_pdf_print_client.cc
[rename] https://crrev.com/1324644aa79fd0fde00690ed4220e7cce7782e98/chrome/renderer/printing/chrome_print_render_frame_helper_delegate.cc
[rename] https://crrev.com/1324644aa79fd0fde00690ed4220e7cce7782e98/chrome/renderer/printing/chrome_print_render_frame_helper_delegate.h
[modify] https://crrev.com/1324644aa79fd0fde00690ed4220e7cce7782e98/components/BUILD.gn
[modify] https://crrev.com/1324644aa79fd0fde00690ed4220e7cce7782e98/components/printing/renderer/BUILD.gn
[rename] https://crrev.com/1324644aa79fd0fde00690ed4220e7cce7782e98/components/printing/renderer/print_render_frame_helper.cc
[rename] https://crrev.com/1324644aa79fd0fde00690ed4220e7cce7782e98/components/printing/renderer/print_render_frame_helper.h
[rename] https://crrev.com/1324644aa79fd0fde00690ed4220e7cce7782e98/components/printing/renderer/print_render_frame_helper_android.cc
[rename] https://crrev.com/1324644aa79fd0fde00690ed4220e7cce7782e98/components/printing/renderer/print_render_frame_helper_linux.cc
[rename] https://crrev.com/1324644aa79fd0fde00690ed4220e7cce7782e98/components/printing/renderer/print_render_frame_helper_mac.mm
[rename] https://crrev.com/1324644aa79fd0fde00690ed4220e7cce7782e98/components/printing/renderer/print_render_frame_helper_pdf_win.cc
[rename] https://crrev.com/1324644aa79fd0fde00690ed4220e7cce7782e98/components/printing/test/print_render_frame_helper_browsertest.cc
[modify] https://crrev.com/1324644aa79fd0fde00690ed4220e7cce7782e98/components/printing/test/print_test_content_renderer_client.cc
[modify] https://crrev.com/1324644aa79fd0fde00690ed4220e7cce7782e98/headless/BUILD.gn
[modify] https://crrev.com/1324644aa79fd0fde00690ed4220e7cce7782e98/headless/lib/renderer/headless_content_renderer_client.cc
[rename] https://crrev.com/1324644aa79fd0fde00690ed4220e7cce7782e98/headless/lib/renderer/headless_print_render_frame_helper_delegate.cc
[rename] https://crrev.com/1324644aa79fd0fde00690ed4220e7cce7782e98/headless/lib/renderer/headless_print_render_frame_helper_delegate.h
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffbf9e15cb4d615a11ce4743027d8fc890ac355d

commit ffbf9e15cb4d615a11ce4743027d8fc890ac355d
Author: Wei Li <weili@chromium.org>
Date: Sat Jul 29 20:55:21 2017

Rename PrintWebViewHelper to PrintRenderFrameHelper (II of II)

PrintWebFrameHelp will be a better name since this class is associated
with render frame, not web view anymore. This CL changes the class name.

BUG= chromium:666548 

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4843fa611509d5def25a838f555a9ab47f37203d
Reviewed-on: https://chromium-review.googlesource.com/583583
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490674}
[modify] https://crrev.com/ffbf9e15cb4d615a11ce4743027d8fc890ac355d/android_webview/renderer/aw_content_renderer_client.cc
[modify] https://crrev.com/ffbf9e15cb4d615a11ce4743027d8fc890ac355d/android_webview/renderer/aw_print_render_frame_helper_delegate.cc
[modify] https://crrev.com/ffbf9e15cb4d615a11ce4743027d8fc890ac355d/android_webview/renderer/aw_print_render_frame_helper_delegate.h
[modify] https://crrev.com/ffbf9e15cb4d615a11ce4743027d8fc890ac355d/android_webview/renderer/print_render_frame_observer.cc
[modify] https://crrev.com/ffbf9e15cb4d615a11ce4743027d8fc890ac355d/chrome/browser/resources/pdf/pdf.js
[modify] https://crrev.com/ffbf9e15cb4d615a11ce4743027d8fc890ac355d/chrome/browser/resources/print_preview/previewarea/preview_area.js
[modify] https://crrev.com/ffbf9e15cb4d615a11ce4743027d8fc890ac355d/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/ffbf9e15cb4d615a11ce4743027d8fc890ac355d/chrome/renderer/chrome_render_frame_observer.cc
[modify] https://crrev.com/ffbf9e15cb4d615a11ce4743027d8fc890ac355d/chrome/renderer/pepper/chrome_pdf_print_client.cc
[modify] https://crrev.com/ffbf9e15cb4d615a11ce4743027d8fc890ac355d/chrome/renderer/printing/chrome_print_render_frame_helper_delegate.cc
[modify] https://crrev.com/ffbf9e15cb4d615a11ce4743027d8fc890ac355d/chrome/renderer/printing/chrome_print_render_frame_helper_delegate.h
[modify] https://crrev.com/ffbf9e15cb4d615a11ce4743027d8fc890ac355d/components/printing/renderer/print_render_frame_helper.cc
[modify] https://crrev.com/ffbf9e15cb4d615a11ce4743027d8fc890ac355d/components/printing/renderer/print_render_frame_helper.h
[modify] https://crrev.com/ffbf9e15cb4d615a11ce4743027d8fc890ac355d/components/printing/renderer/print_render_frame_helper_android.cc
[modify] https://crrev.com/ffbf9e15cb4d615a11ce4743027d8fc890ac355d/components/printing/renderer/print_render_frame_helper_linux.cc
[modify] https://crrev.com/ffbf9e15cb4d615a11ce4743027d8fc890ac355d/components/printing/renderer/print_render_frame_helper_mac.mm
[modify] https://crrev.com/ffbf9e15cb4d615a11ce4743027d8fc890ac355d/components/printing/renderer/print_render_frame_helper_pdf_win.cc
[modify] https://crrev.com/ffbf9e15cb4d615a11ce4743027d8fc890ac355d/components/printing/test/print_mock_render_thread.h
[modify] https://crrev.com/ffbf9e15cb4d615a11ce4743027d8fc890ac355d/components/printing/test/print_render_frame_helper_browsertest.cc
[modify] https://crrev.com/ffbf9e15cb4d615a11ce4743027d8fc890ac355d/components/printing/test/print_test_content_renderer_client.cc
[modify] https://crrev.com/ffbf9e15cb4d615a11ce4743027d8fc890ac355d/content/renderer/pepper/pepper_plugin_instance_impl.h
[modify] https://crrev.com/ffbf9e15cb4d615a11ce4743027d8fc890ac355d/headless/lib/renderer/headless_content_renderer_client.cc
[modify] https://crrev.com/ffbf9e15cb4d615a11ce4743027d8fc890ac355d/headless/lib/renderer/headless_print_render_frame_helper_delegate.cc
[modify] https://crrev.com/ffbf9e15cb4d615a11ce4743027d8fc890ac355d/headless/lib/renderer/headless_print_render_frame_helper_delegate.h
[modify] https://crrev.com/ffbf9e15cb4d615a11ce4743027d8fc890ac355d/ppapi/proxy/pdf_resource.cc

Comment 4 by weili@chromium.org, Aug 2 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment