New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666530 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

squashfs without verity gets corrupted

Project Member Reported by mirman@chromium.org, Nov 17 2016

Issue description

Make chromeos-install work with squashfs when the image was build with noenable_rootfs_verification

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/f3adfd6221631729466d91dd951348f0ef869174

commit f3adfd6221631729466d91dd951348f0ef869174
Author: Matthew Mirman <mirman@chromium.org>
Date: Thu Nov 17 23:26:42 2016

installer: Ensure that the squashfs doesn't written to during install

MakeFileSystemRw only works on filesystems which can be made
writable, but doesn't check ensure that the filesystem is writable at all.
This change checks that if the filesystem has the squashfs
id at the beginning, and if so, does not modify it at all.

Also, it removes the unused "rw" argument from "MakeFileSystemRw"
Given its name, it should always make the filesystem rw,
and is currently always used that way.

BUG=chromium:666530

TEST=I did good things.

Change-Id: I2fc0b8304468aab2757593a56f50e1f0a41fe3b1
Reviewed-on: https://chromium-review.googlesource.com/412271
Commit-Ready: Matthew Mirman <mirman@chromium.org>
Tested-by: Matthew Mirman <mirman@chromium.org>
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>

[modify] https://crrev.com/f3adfd6221631729466d91dd951348f0ef869174/installer/chromeos_setimage.cc
[modify] https://crrev.com/f3adfd6221631729466d91dd951348f0ef869174/installer/inst_util.cc
[modify] https://crrev.com/f3adfd6221631729466d91dd951348f0ef869174/installer/inst_util.h

You started fixing this bug over two years ago. Are you still working on it? You can update the status to "archived", "wontfix", or "closed". You can remove yourself as owner and change status to "untriaged", but if this is still a real bug, please do not sit on it.

Sign in to add a comment