New issue
Advanced search Search tips

Issue 666529 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

Generate java POPUP_ITEM_ID constants from C++ enum

Project Member Reported by lshang@chromium.org, Nov 17 2016

Issue description

And remove manually defined popup item ids in AutofillSuggestion.java and AutofillPopup.java.

 
Labels: -Pri-1 Pri-2
Owner: ----
Status: Available (was: Assigned)

Comment 2 by ajha@chromium.org, Dec 5 2016

Labels: OS-Android
Project Member

Comment 3 by sheriffbot@chromium.org, Dec 11 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: UI>Browser>Autofill
Owner: eui-sang.lim@samsung.com
Status: Started (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a107114fa763a87a27444713803995f0a38eede

commit 0a107114fa763a87a27444713803995f0a38eede
Author: Amos Lim <eui-sang.lim@samsung.com>
Date: Tue Jul 10 22:15:49 2018

Generate java POPUP_ITEM_ID constants from PopupItemId enum

Generate java constants from C++ Enums and remove manually defined
popup item ids in AutofillSuggestion.java and AutofillPopup.java.

Bug:  666529 
Change-Id: If25e3a52385a8b9cee12bd96c80d8ece4df4e568
Reviewed-on: https://chromium-review.googlesource.com/1131355
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Amos Lim <eui-sang.lim@samsung.com>
Cr-Commit-Position: refs/heads/master@{#573944}
[modify] https://crrev.com/0a107114fa763a87a27444713803995f0a38eede/components/autofill/android/BUILD.gn
[modify] https://crrev.com/0a107114fa763a87a27444713803995f0a38eede/components/autofill/android/java/src/org/chromium/components/autofill/AutofillPopup.java
[modify] https://crrev.com/0a107114fa763a87a27444713803995f0a38eede/components/autofill/android/java/src/org/chromium/components/autofill/AutofillSuggestion.java
[modify] https://crrev.com/0a107114fa763a87a27444713803995f0a38eede/components/autofill/core/browser/popup_item_ids.h

Status: Fixed (was: Started)

Sign in to add a comment