Remove WebContentsImpl::GetRoutingID() and GetRenderProcessHost() |
|||||
Issue descriptionHaving these functions on WebContents doesn't make sense anymore in the OOPIF world, where a WebContents may need to interact with multiple renderer processes. Incorrect use of these functions has led to bugs in the past (e.g., see bullet 4 in https://crbug.com/593522#c3, or the fix in r338949). I think we should remove these helpers and clean up the call sites to make it explicit what they are doing. I.e., web_contents->GetRoutingID() becomes web_contents->GetRenderViewHost()->GetRoutingID() web_contents->GetRenderProcessHost() becomes web_contents->GetMainFrame()->GetProcess() Doing this might also reveal OOPIF issues we don't yet know about.
,
Nov 22 2016
All occurences of web_contents->GetRoutingID() have been removed. It should be noted, however, that in content/public/browser/web_contents_observer.cc:63
WebContentsObserver::routing_id() const {
This looks like another bad API that we might want to
remove in a follow-up CL, or at least audit its uses. At the very least it should be named something like render_view_routing_id().
,
Nov 23 2016
This is a great observation! We should definitely rename the method render_view_routing_id(). If we could eliminate its usage, that will be ideal, but I'm not sure we can do it easily/quickly, since it is used by browser_plugin/webview, so maybe rename first and then follow up further.
,
Nov 23 2016
Comment 2: Yes, good idea. Also, it looks like https://codereview.chromium.org/2515823002/ hasn't landed yet, so we haven't quite removed them yet. Very soon, though! :)
,
Nov 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/996be1115fde6db6ff18ed5b03278a6610a5eb38 commit 996be1115fde6db6ff18ed5b03278a6610a5eb38 Author: davidsac <davidsac@chromium.org> Date: Wed Nov 30 08:56:38 2016 Remove WebContents::GetRoutingID(). Replace all definitions, declarations, and uses of WebContents::GetRoutingID() with web_contents->GetRenderViewHost()->GetRoutingID(). This will make it more clear which routing id is being used. Having GetRoutingID() on WebContents is both confusing (WebContents isn't a routable object) and is prone to misuse with OOPIFs. No behaviour changes should be caused by this CL. BUG=666525 Review-Url: https://codereview.chromium.org/2515823002 Cr-Commit-Position: refs/heads/master@{#435182} [modify] https://crrev.com/996be1115fde6db6ff18ed5b03278a6610a5eb38/android_webview/native/aw_contents.cc [modify] https://crrev.com/996be1115fde6db6ff18ed5b03278a6610a5eb38/chrome/browser/android/download/download_controller.cc [modify] https://crrev.com/996be1115fde6db6ff18ed5b03278a6610a5eb38/chrome/browser/android/tab_android.cc [modify] https://crrev.com/996be1115fde6db6ff18ed5b03278a6610a5eb38/chrome/browser/download/download_resource_throttle_unittest.cc [modify] https://crrev.com/996be1115fde6db6ff18ed5b03278a6610a5eb38/chrome/browser/extensions/api/declarative_content/declarative_content_css_condition_tracker_unittest.cc [modify] https://crrev.com/996be1115fde6db6ff18ed5b03278a6610a5eb38/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc [modify] https://crrev.com/996be1115fde6db6ff18ed5b03278a6610a5eb38/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc [modify] https://crrev.com/996be1115fde6db6ff18ed5b03278a6610a5eb38/chrome/browser/ui/search/instant_tab_unittest.cc [modify] https://crrev.com/996be1115fde6db6ff18ed5b03278a6610a5eb38/chrome/browser/ui/search/search_ipc_router_unittest.cc [modify] https://crrev.com/996be1115fde6db6ff18ed5b03278a6610a5eb38/chrome/browser/ui/search/search_tab_helper_unittest.cc [modify] https://crrev.com/996be1115fde6db6ff18ed5b03278a6610a5eb38/content/browser/android/content_view_core_impl.cc [modify] https://crrev.com/996be1115fde6db6ff18ed5b03278a6610a5eb38/content/browser/host_zoom_map_impl.cc [modify] https://crrev.com/996be1115fde6db6ff18ed5b03278a6610a5eb38/content/browser/host_zoom_map_impl_browsertest.cc [modify] https://crrev.com/996be1115fde6db6ff18ed5b03278a6610a5eb38/content/browser/loader/resource_dispatcher_host_unittest.cc [modify] https://crrev.com/996be1115fde6db6ff18ed5b03278a6610a5eb38/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/996be1115fde6db6ff18ed5b03278a6610a5eb38/content/browser/web_contents/web_contents_impl.h [modify] https://crrev.com/996be1115fde6db6ff18ed5b03278a6610a5eb38/content/public/browser/web_contents.h [modify] https://crrev.com/996be1115fde6db6ff18ed5b03278a6610a5eb38/content/public/browser/web_contents_observer.cc [modify] https://crrev.com/996be1115fde6db6ff18ed5b03278a6610a5eb38/content/renderer/visual_state_browsertest.cc [modify] https://crrev.com/996be1115fde6db6ff18ed5b03278a6610a5eb38/content/shell/browser/layout_test/blink_test_controller.cc [modify] https://crrev.com/996be1115fde6db6ff18ed5b03278a6610a5eb38/extensions/browser/guest_view/web_view/web_view_guest.cc
,
Nov 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0cb07a009c9d607d265928ece3ead010a736e2b commit c0cb07a009c9d607d265928ece3ead010a736e2b Author: thestig <thestig@chromium.org> Date: Wed Nov 30 18:50:56 2016 Remove some WebContents::GetRenderViewHost() calls. web_contents->GetRenderViewHost()->GetProcess() becomes web_contents->GetMainFrame()->GetProcess() unless the call is part of a process id + routing id pair. Also remove an obsolete RenderViewGone reference in background_printing_manager.cc. BUG=666525 Review-Url: https://codereview.chromium.org/2527133002 Cr-Commit-Position: refs/heads/master@{#435358} [modify] https://crrev.com/c0cb07a009c9d607d265928ece3ead010a736e2b/chrome/browser/extensions/api/declarative_content/declarative_content_condition_tracker_test.cc [modify] https://crrev.com/c0cb07a009c9d607d265928ece3ead010a736e2b/chrome/browser/extensions/isolated_app_browsertest.cc [modify] https://crrev.com/c0cb07a009c9d607d265928ece3ead010a736e2b/chrome/browser/printing/background_printing_manager.cc [modify] https://crrev.com/c0cb07a009c9d607d265928ece3ead010a736e2b/chrome/browser/printing/print_preview_dialog_controller_unittest.cc [modify] https://crrev.com/c0cb07a009c9d607d265928ece3ead010a736e2b/chrome/browser/ui/search/instant_search_prerenderer_unittest.cc [modify] https://crrev.com/c0cb07a009c9d607d265928ece3ead010a736e2b/chrome/browser/ui/search/search_ipc_router_unittest.cc [modify] https://crrev.com/c0cb07a009c9d607d265928ece3ead010a736e2b/content/browser/renderer_host/render_process_host_browsertest.cc [modify] https://crrev.com/c0cb07a009c9d607d265928ece3ead010a736e2b/content/browser/security_exploit_browsertest.cc [modify] https://crrev.com/c0cb07a009c9d607d265928ece3ead010a736e2b/content/shell/browser/layout_test/blink_test_controller.cc [modify] https://crrev.com/c0cb07a009c9d607d265928ece3ead010a736e2b/extensions/browser/api/alarms/alarms_api_unittest.cc
,
Apr 4 2017
,
Aug 31 2017
There are currently around 320 callers of WebContents::GetRenderProcessHost. There are the following subcategories of callers: - Non-test callers - around 100 (after fixing these callers, we can add "ForTesting" suffix to the method name) - Callers outside of //content layer - around 262 (after fixing these callers, the method declaration can be moved from WebContents to WebContentsImpl).
,
Sep 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/237c3d7820b6ad49871568ff972cd8ab3c34dea2 commit 237c3d7820b6ad49871568ff972cd8ab3c34dea2 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Tue Sep 05 18:08:39 2017 Remove calls to the deprecated WebContents::GetRenderProcessHost method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL removes the usage of this API and converts it to its equivalents all the callers under //chrome/browser/task_manager. Bug: 666525 Change-Id: If6759a4cf935ee72c6a19613476aedaf2076f395 Reviewed-on: https://chromium-review.googlesource.com/646388 Reviewed-by: Nick Carter <nick@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#499676} [modify] https://crrev.com/237c3d7820b6ad49871568ff972cd8ab3c34dea2/chrome/browser/task_manager/providers/web_contents/background_contents_task.cc [modify] https://crrev.com/237c3d7820b6ad49871568ff972cd8ab3c34dea2/chrome/browser/task_manager/providers/web_contents/extension_task.cc [modify] https://crrev.com/237c3d7820b6ad49871568ff972cd8ab3c34dea2/chrome/browser/task_manager/providers/web_contents/guest_task.cc [modify] https://crrev.com/237c3d7820b6ad49871568ff972cd8ab3c34dea2/chrome/browser/task_manager/providers/web_contents/prerender_task.cc [modify] https://crrev.com/237c3d7820b6ad49871568ff972cd8ab3c34dea2/chrome/browser/task_manager/providers/web_contents/printing_task.cc [modify] https://crrev.com/237c3d7820b6ad49871568ff972cd8ab3c34dea2/chrome/browser/task_manager/providers/web_contents/renderer_task.cc [modify] https://crrev.com/237c3d7820b6ad49871568ff972cd8ab3c34dea2/chrome/browser/task_manager/providers/web_contents/renderer_task.h [modify] https://crrev.com/237c3d7820b6ad49871568ff972cd8ab3c34dea2/chrome/browser/task_manager/providers/web_contents/subframe_task.cc [modify] https://crrev.com/237c3d7820b6ad49871568ff972cd8ab3c34dea2/chrome/browser/task_manager/providers/web_contents/tab_contents_task.cc [modify] https://crrev.com/237c3d7820b6ad49871568ff972cd8ab3c34dea2/content/public/browser/web_contents.h
,
Sep 19 2017
Using an ad-hoc clang plugin (and quite a few manual edits) I have put together a CL that removes WebContents::GetRenderProcessHost() entirely - https://chromium-review.googlesource.com/c/chromium/src/+/673124. FWIW, this CL is green on trybots. OTOH, to get this CL ready to land, we should carefully review the old callsites and open bugs / add TODOs for things that should go through web_contents->Get*Main*Frame()->GetProcess().
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4229f25c347aa64f01d932dd23856e44eae6d7a6 commit 4229f25c347aa64f01d932dd23856e44eae6d7a6 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 01:47:46 2017 Removing WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL removes this API altogether. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). For the record, below is a list of existing bugs that have been uncovered or highlighted during the review of this CL: - https://crbug.com/715924: Headless OOPIF support - https://crbug.com/767519: Android WebView code duplication - https://crbug.com/767526: Handling of unresponsive renderers - https://crbug.com/767539: TabSpecificContentSettings - https://crbug.com/767557: ExtensionMsg_UpdateTabSpecificPermissions - https://crbug.com/767563: chrome.processes.getProcessIdForTab - https://crbug.com/769385: WebViewInternalAddContentScriptsFunction - https://crbug.com/769461: BrowserTag/WebView owner tracking - https://crbug.com/769479: PrintPreviewDialogController Bug: 666525 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: Idcb70a8c3928f0631a38a61b7029876fdaf921cb Tbr: alokp@chromium.org, boliu@chromium.org, derat@chromium.org, dvallet@chromium.org, haraken@chromium.org, lazyboy@chromium.org, lfg@chromium.org, raymes@chromium.org, rdsmith@chromium.org, tapted@chromium.org, tedchoc@chromium.org, thestig@chromium.org, treib@chromium.org Tbr: asvitkine@chromium.org, bartfab@chromium.org, bengr@chromium.org, benwells@chromium.org, dewittj@chromium.org, dsinclair@chromium.org, jkarlin@chromium.org, jsbell@chromium.org, meacer@chromium.org, mmenke@chromium.org, nparker@chromium.org, sergeyu@chromium.org, sky@chromium.org, stanisc@chromium.org, tommycli@chromium.org, wjmaclean@chromium.org Reviewed-on: https://chromium-review.googlesource.com/673124 Reviewed-by: Justin DeWitt <dewittj@chromium.org> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by: Stanislav Chiknavaryan <stanisc@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by: Nathan Parker <nparker@chromium.org> Reviewed-by: David Vallet <dvallet@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Lucas Gadani <lfg@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Nick Carter <nick@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#504862} [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/android_webview/browser/aw_contents.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/android_webview/browser/state_serializer.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/android/download/download_controller.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/android/tab_android.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/android/tab_web_contents_delegate_android.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/apps/guest_view/app_view_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/apps/guest_view/web_view_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/background_sync/background_sync_permission_context_unittest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/chromeos/power/renderer_freezer.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/content_settings/tab_specific_content_settings.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/crash_recovery_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/download/save_package_file_picker.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/extensions/active_tab_permission_granter.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/extensions/api/processes/processes_api.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/extensions/app_process_apitest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/extensions/isolated_app_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/extensions/process_management_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/extensions/process_manager_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/extensions/webstore_installer.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/geolocation/geolocation_permission_context_unittest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/media/midi_sysex_permission_context_unittest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/media/webrtc/media_stream_devices_controller_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/media_galleries/media_file_system_registry.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/metrics/renderer_uptime_web_contents_observer.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/notifications/notification_permission_context_unittest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/offline_pages/android/downloads/offline_page_download_bridge.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/pdf/pdf_extension_test.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/permissions/permission_context_base_unittest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/plugins/chrome_plugin_service_filter_unittest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/plugins/pdf_iframe_navigation_throttle.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/plugins/pdf_plugin_placeholder_observer.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/policy/policy_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/prerender/prerender_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/printing/print_preview_dialog_controller.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/printing/print_view_manager.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/renderer_context_menu/render_view_context_menu.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/resource_coordinator/tab_manager.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/resource_coordinator/tab_manager_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/resource_coordinator/tab_manager_delegate_chromeos.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/resource_coordinator/tab_manager_unittest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/safe_browsing/client_side_detection_host.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/safe_browsing/threat_details_unittest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/safe_browsing/ui_manager_unittest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/search/search.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/search/search_unittest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/ssl/ssl_browser_tests.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/storage/durable_storage_permission_context_unittest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/sync/test/integration/sessions_helper.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/ui/blocked_content/blocked_window_params.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/ui/browser_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/ui/browser_instant_controller.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/ui/browser_instant_controller_unittest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/ui/browser_navigator_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/ui/cocoa/hung_renderer_controller.mm [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/ui/javascript_dialogs/javascript_dialog_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/ui/search/search_tab_helper.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/ui/search_engines/search_engine_tab_helper.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/ui/tab_contents/core_tab_helper.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/ui/tabs/tab_strip_model.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/ui/tabs/tab_strip_model_unittest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/ui/views/external_protocol_dialog_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/ui/views/hung_renderer_view.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/ui/webui/app_launcher_page_ui.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/ui/webui/interstitials/interstitial_ui.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/ui/webui/ntp/new_tab_ui.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/ui/webui/print_preview/print_preview_handler.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/ui/webui/settings_utils_linux.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/ui/webui/webui_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/ui/zoom/zoom_controller_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/browser/web_bluetooth_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chrome/test/base/ui_test_utils.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/chromecast/browser/cast_content_browser_client.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/components/guest_view/browser/guest_view_manager.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/components/safe_browsing/triggers/ad_sampler_trigger.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/components/zoom/zoom_controller.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/browser/android/java/gin_java_bridge_dispatcher_host.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/browser/android/java/gin_java_bridge_message_filter.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/browser/browser_plugin/browser_plugin_guest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/browser/child_process_launcher_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/browser/child_process_security_policy_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/browser/cross_site_transfer_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/browser/devtools/devtools_frontend_host_impl.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/browser/download/mhtml_generation_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/browser/download/save_package.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/browser/frame_host/frame_tree_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/browser/frame_host/interstitial_page_impl.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/browser/frame_host/navigation_controller_impl_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/browser/frame_host/render_frame_host_manager_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/browser/host_zoom_map_impl.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/browser/host_zoom_map_impl_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/browser/indexed_db/indexed_db_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/browser/loader/resource_dispatcher_host_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/browser/loader/resource_dispatcher_host_unittest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/browser/media/android/browser_media_player_manager.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/browser/renderer_host/render_widget_host_view_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/browser/security_exploit_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/browser/service_worker/service_worker_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/browser/site_per_process_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/browser/speech/speech_recognition_dispatcher_host.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/browser/web_contents/web_contents_impl.h [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/browser/web_contents/web_contents_impl_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/browser/webui/web_ui_impl.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/browser/webui/web_ui_mojo_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/public/browser/web_contents.h [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/public/test/browser_test_utils.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/renderer/browser_render_view_browsertest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/test/content_browser_test_test.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/test/test_navigation_url_loader.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/test/test_web_contents.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/content/test/test_web_contents.h [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/extensions/browser/extension_host.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/extensions/browser/guest_view/extension_options/extension_options_guest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/extensions/browser/guest_view/extension_view/extension_view_guest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/extensions/browser/guest_view/extensions_guest_view_manager_delegate.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/extensions/browser/guest_view/web_view/web_view_apitest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/extensions/browser/guest_view/web_view/web_view_guest.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/extensions/test/background_page_watcher.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/headless/lib/browser/headless_web_contents_impl.cc [modify] https://crrev.com/4229f25c347aa64f01d932dd23856e44eae6d7a6/ui/views/controls/webview/webview.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32 commit 86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Thu Sep 28 02:19:01 2017 Revert "Removing WebContents::GetRenderProcessHost() method." This reverts commit 4229f25c347aa64f01d932dd23856e44eae6d7a6. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 504862 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzQyMjlmMjVjMzQ3YWE2NGYwMWQ5MzJkZDIzODU2ZTQ0ZWFlNmQ3YTYM Sample Failed Build: https://luci-milo.appspot.com/buildbot/chromium.win/Win%20x64%20Builder/38179 Original change's description: > Removing WebContents::GetRenderProcessHost() method. > > WebContents::GetRenderProcessHost is an API that doesn't behave as > expected with out-of-process iframes, as multiple processes can be > associated with a single WebContents. This CL removes this API > altogether. > > This CL was started by using an ad-hoc clang-plugin that replaced > existing callsites of WebContents::GetRenderProcessHost() with a call to > something like wc->GetMainFrame()->GetProcess(). This was followed-up > by manually adding an include of render_frame_host.h and git cl format > and git cl lint and then a self-review with small tweaks (e.g. sometimes > using a wc->GetRenderViewHost()->GetProcess() is more appropriate). > > For the record, below is a list of existing bugs that have been > uncovered or highlighted during the review of this CL: > - https://crbug.com/715924: Headless OOPIF support > - https://crbug.com/767519: Android WebView code duplication > - https://crbug.com/767526: Handling of unresponsive renderers > - https://crbug.com/767539: TabSpecificContentSettings > - https://crbug.com/767557: ExtensionMsg_UpdateTabSpecificPermissions > - https://crbug.com/767563: chrome.processes.getProcessIdForTab > - https://crbug.com/769385: WebViewInternalAddContentScriptsFunction > - https://crbug.com/769461: BrowserTag/WebView owner tracking > - https://crbug.com/769479: PrintPreviewDialogController > > Bug: 666525 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation > Change-Id: Idcb70a8c3928f0631a38a61b7029876fdaf921cb > Tbr: alokp@chromium.org, boliu@chromium.org, derat@chromium.org, dvallet@chromium.org, haraken@chromium.org, lazyboy@chromium.org, lfg@chromium.org, raymes@chromium.org, rdsmith@chromium.org, tapted@chromium.org, tedchoc@chromium.org, thestig@chromium.org, treib@chromium.org > Tbr: asvitkine@chromium.org, bartfab@chromium.org, bengr@chromium.org, benwells@chromium.org, dewittj@chromium.org, dsinclair@chromium.org, jkarlin@chromium.org, jsbell@chromium.org, meacer@chromium.org, mmenke@chromium.org, nparker@chromium.org, sergeyu@chromium.org, sky@chromium.org, stanisc@chromium.org, tommycli@chromium.org, wjmaclean@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/673124 > Reviewed-by: Justin DeWitt <dewittj@chromium.org> > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Reviewed-by: Stanislav Chiknavaryan <stanisc@chromium.org> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Reviewed-by: Nathan Parker <nparker@chromium.org> > Reviewed-by: David Vallet <dvallet@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Lucas Gadani <lfg@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Nick Carter <nick@chromium.org> > Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504862} Change-Id: I389fcfe03f5ed41366855d1340f767d89592408c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 666525 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Reviewed-on: https://chromium-review.googlesource.com/688759 Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#504868} [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/android_webview/browser/aw_contents.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/android_webview/browser/state_serializer.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/android/download/download_controller.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/android/tab_android.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/android/tab_web_contents_delegate_android.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/apps/guest_view/app_view_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/apps/guest_view/web_view_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/background_sync/background_sync_permission_context_unittest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/chromeos/power/renderer_freezer.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/content_settings/tab_specific_content_settings.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/crash_recovery_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/download/save_package_file_picker.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/extensions/active_tab_permission_granter.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/extensions/api/processes/processes_api.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/extensions/app_process_apitest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/extensions/isolated_app_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/extensions/process_management_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/extensions/process_manager_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/extensions/webstore_installer.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/geolocation/geolocation_permission_context_unittest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/media/midi_sysex_permission_context_unittest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/media/webrtc/media_stream_devices_controller_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/media_galleries/media_file_system_registry.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/metrics/renderer_uptime_web_contents_observer.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/notifications/notification_permission_context_unittest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/offline_pages/android/downloads/offline_page_download_bridge.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/pdf/pdf_extension_test.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/permissions/permission_context_base_unittest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/plugins/chrome_plugin_service_filter_unittest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/plugins/pdf_iframe_navigation_throttle.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/plugins/pdf_plugin_placeholder_observer.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/policy/policy_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/prerender/prerender_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/printing/print_preview_dialog_controller.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/printing/print_view_manager.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/renderer_context_menu/render_view_context_menu.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/resource_coordinator/tab_manager.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/resource_coordinator/tab_manager_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/resource_coordinator/tab_manager_delegate_chromeos.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/resource_coordinator/tab_manager_unittest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/safe_browsing/client_side_detection_host.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/safe_browsing/threat_details_unittest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/safe_browsing/ui_manager_unittest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/search/search.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/search/search_unittest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/ssl/ssl_browser_tests.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/storage/durable_storage_permission_context_unittest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/sync/test/integration/sessions_helper.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/ui/blocked_content/blocked_window_params.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/ui/browser_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/ui/browser_instant_controller.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/ui/browser_instant_controller_unittest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/ui/browser_navigator_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/ui/cocoa/hung_renderer_controller.mm [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/ui/javascript_dialogs/javascript_dialog_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/ui/search/search_tab_helper.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/ui/search_engines/search_engine_tab_helper.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/ui/tab_contents/core_tab_helper.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/ui/tabs/tab_strip_model.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/ui/tabs/tab_strip_model_unittest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/ui/views/external_protocol_dialog_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/ui/views/hung_renderer_view.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/ui/webui/app_launcher_page_ui.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/ui/webui/interstitials/interstitial_ui.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/ui/webui/ntp/new_tab_ui.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/ui/webui/print_preview/print_preview_handler.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/ui/webui/settings_utils_linux.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/ui/webui/webui_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/ui/zoom/zoom_controller_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/browser/web_bluetooth_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chrome/test/base/ui_test_utils.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/chromecast/browser/cast_content_browser_client.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/components/guest_view/browser/guest_view_manager.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/components/safe_browsing/triggers/ad_sampler_trigger.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/components/zoom/zoom_controller.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/browser/android/java/gin_java_bridge_dispatcher_host.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/browser/android/java/gin_java_bridge_message_filter.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/browser/browser_plugin/browser_plugin_guest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/browser/child_process_launcher_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/browser/child_process_security_policy_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/browser/cross_site_transfer_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/browser/devtools/devtools_frontend_host_impl.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/browser/download/mhtml_generation_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/browser/download/save_package.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/browser/frame_host/frame_tree_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/browser/frame_host/interstitial_page_impl.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/browser/frame_host/navigation_controller_impl_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/browser/frame_host/render_frame_host_manager_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/browser/host_zoom_map_impl.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/browser/host_zoom_map_impl_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/browser/indexed_db/indexed_db_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/browser/loader/resource_dispatcher_host_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/browser/loader/resource_dispatcher_host_unittest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/browser/media/android/browser_media_player_manager.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/browser/renderer_host/render_widget_host_view_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/browser/security_exploit_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/browser/service_worker/service_worker_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/browser/site_per_process_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/browser/speech/speech_recognition_dispatcher_host.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/browser/web_contents/web_contents_impl.h [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/browser/web_contents/web_contents_impl_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/browser/webui/web_ui_impl.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/browser/webui/web_ui_mojo_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/public/browser/web_contents.h [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/public/test/browser_test_utils.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/renderer/browser_render_view_browsertest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/test/content_browser_test_test.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/test/test_navigation_url_loader.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/test/test_web_contents.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/content/test/test_web_contents.h [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/extensions/browser/extension_host.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/extensions/browser/guest_view/extension_options/extension_options_guest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/extensions/browser/guest_view/extension_view/extension_view_guest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/extensions/browser/guest_view/extensions_guest_view_manager_delegate.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/extensions/browser/guest_view/web_view/web_view_apitest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/extensions/browser/guest_view/web_view/web_view_guest.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/extensions/test/background_page_watcher.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/headless/lib/browser/headless_web_contents_impl.cc [modify] https://crrev.com/86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32/ui/views/controls/webview/webview.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/016e36f637554da6ed3c2aa05f03de585fd7cd9a commit 016e36f637554da6ed3c2aa05f03de585fd7cd9a Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 05:18:55 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=thestig@chromium.org Bug: 666525 Change-Id: I25b8303777b74936dd8aec44674b509a1ebbeebf Reviewed-on: https://chromium-review.googlesource.com/689135 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#504913} [modify] https://crrev.com/016e36f637554da6ed3c2aa05f03de585fd7cd9a/chrome/browser/pdf/pdf_extension_test.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/705c39357c1ba284132de7433a73c433cbeccefb commit 705c39357c1ba284132de7433a73c433cbeccefb Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 06:15:40 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=thestig@chromium.org Bug: 666525 Change-Id: If9b034c86f4332d9196e759cc948dca8c3d9ce17 Reviewed-on: https://chromium-review.googlesource.com/689125 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#504921} [modify] https://crrev.com/705c39357c1ba284132de7433a73c433cbeccefb/chrome/browser/printing/print_preview_dialog_controller.cc [modify] https://crrev.com/705c39357c1ba284132de7433a73c433cbeccefb/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc [modify] https://crrev.com/705c39357c1ba284132de7433a73c433cbeccefb/chrome/browser/printing/print_view_manager.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f3c304ed76cddb311c7708faf6aee3c07225b1f commit 2f3c304ed76cddb311c7708faf6aee3c07225b1f Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 06:18:21 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=reillyg@chromium.org Bug: 666525 Change-Id: I106793fbb4ae7e33213cd5daf49c9620a359b0e6 Reviewed-on: https://chromium-review.googlesource.com/689119 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#504922} [modify] https://crrev.com/2f3c304ed76cddb311c7708faf6aee3c07225b1f/chrome/browser/media_galleries/media_file_system_registry.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c2c8fcbde6fe3874ee970136ae198520472d897 commit 0c2c8fcbde6fe3874ee970136ae198520472d897 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 12:36:51 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=bauerb@chromium.org Bug: 666525 Change-Id: Ib10ad6ad0f52490a16200addd4f63cd60cb431ee Reviewed-on: https://chromium-review.googlesource.com/689116 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#504979} [modify] https://crrev.com/0c2c8fcbde6fe3874ee970136ae198520472d897/chrome/browser/android/tab_web_contents_delegate_android.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b1e3f1b1c59f0ddf1f78fbd0adfd92b61df97c1 commit 1b1e3f1b1c59f0ddf1f78fbd0adfd92b61df97c1 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 12:52:39 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=pavely@chromium.org Bug: 666525 Change-Id: I2ea11f27da572b30ef0da7caa44c79b8006748ce Reviewed-on: https://chromium-review.googlesource.com/689127 Reviewed-by: Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#504982} [modify] https://crrev.com/1b1e3f1b1c59f0ddf1f78fbd0adfd92b61df97c1/chrome/browser/sync/test/integration/sessions_helper.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d0c2b7d3b5c30abe5a4b4d9ce0ad7a51786fdfc commit 2d0c2b7d3b5c30abe5a4b4d9ce0ad7a51786fdfc Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 12:54:37 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=benjhayden@chromium.org Bug: 666525 Change-Id: I74f1d083332c4bc0c0425eeda127a609c068cb6e Reviewed-on: https://chromium-review.googlesource.com/689139 Reviewed-by: Ben Hayden <benjhayden@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#504983} [modify] https://crrev.com/2d0c2b7d3b5c30abe5a4b4d9ce0ad7a51786fdfc/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2efd012a758098f0c37679fe03e20c6f9531ce2e commit 2efd012a758098f0c37679fe03e20c6f9531ce2e Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 12:57:29 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=maxmorin@chromium.org Bug: 666525 Change-Id: I6898537d91e51d0c4989ebebfce01bf7b9db37c6 Reviewed-on: https://chromium-review.googlesource.com/689129 Reviewed-by: Max Morin <maxmorin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#504984} [modify] https://crrev.com/2efd012a758098f0c37679fe03e20c6f9531ce2e/content/browser/speech/speech_recognition_dispatcher_host.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0fda82f3713b1812faf047742d1ea55b8e68ce0 commit c0fda82f3713b1812faf047742d1ea55b8e68ce0 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 12:57:36 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=altimin@chromium.org Bug: 666525 Change-Id: I7d77d006c93c5c3867f686d018d2b624fbbb0f66 Reviewed-on: https://chromium-review.googlesource.com/689095 Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#504985} [modify] https://crrev.com/c0fda82f3713b1812faf047742d1ea55b8e68ce0/headless/lib/browser/headless_web_contents_impl.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b06af54d645c8c4b59a9cd15874c8c99ab2a40b5 commit b06af54d645c8c4b59a9cd15874c8c99ab2a40b5 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 12:58:49 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=shimazu@chromium.org Bug: 666525 Change-Id: Ic084545de7fb2f741b5f53cb385dc88aca9a3086 Reviewed-on: https://chromium-review.googlesource.com/688172 Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#504987} [modify] https://crrev.com/b06af54d645c8c4b59a9cd15874c8c99ab2a40b5/content/browser/service_worker/service_worker_browsertest.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ca74ac0a5041a47ceffc79552602ebe72f6bb293 commit ca74ac0a5041a47ceffc79552602ebe72f6bb293 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 12:58:40 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=phajdan.jr@chromium.org Bug: 666525 Change-Id: I9bc7a358b61bf9aceb4b074475b96bae34855b65 Reviewed-on: https://chromium-review.googlesource.com/689096 Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#504986} [modify] https://crrev.com/ca74ac0a5041a47ceffc79552602ebe72f6bb293/chrome/test/base/ui_test_utils.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e9fdcd70d64d07673cab7ec72f1e19ca8fbd83a commit 0e9fdcd70d64d07673cab7ec72f1e19ca8fbd83a Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 13:00:03 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=pastarmovj@chromium.org Bug: 666525 Change-Id: I012b61ef5f6b76295e4d01067369d1029a57d473 Reviewed-on: https://chromium-review.googlesource.com/689142 Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#504988} [modify] https://crrev.com/0e9fdcd70d64d07673cab7ec72f1e19ca8fbd83a/chrome/browser/policy/policy_browsertest.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dff8c0e0e2a3f11c8cb3fda814422eae76c09329 commit dff8c0e0e2a3f11c8cb3fda814422eae76c09329 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 13:01:16 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=lazyboy@chromium.org Bug: 666525 Change-Id: I0df13be0c92b4e478604274d97386ec57960c332 Reviewed-on: https://chromium-review.googlesource.com/689111 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#504989} [modify] https://crrev.com/dff8c0e0e2a3f11c8cb3fda814422eae76c09329/chrome/browser/apps/guest_view/app_view_browsertest.cc [modify] https://crrev.com/dff8c0e0e2a3f11c8cb3fda814422eae76c09329/chrome/browser/apps/guest_view/web_view_browsertest.cc [modify] https://crrev.com/dff8c0e0e2a3f11c8cb3fda814422eae76c09329/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aabf5c2c8bef8ec2088f0424cb51b18c95c1d73e commit aabf5c2c8bef8ec2088f0424cb51b18c95c1d73e Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 13:01:46 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=jochen@chromium.org Bug: 666525 Change-Id: I383bce4b63a6a18ade43315c541a13d748299875 Reviewed-on: https://chromium-review.googlesource.com/689103 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#504990} [modify] https://crrev.com/aabf5c2c8bef8ec2088f0424cb51b18c95c1d73e/chrome/browser/ui/blocked_content/blocked_window_params.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f0b84caba981f29ff35518e326bb6ecb9e55ac8 commit 3f0b84caba981f29ff35518e326bb6ecb9e55ac8 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 13:02:37 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=lazyboy@chromium.org Bug: 666525 Change-Id: Ifc24a9925347dcce1a023adaa5cf2a5abf455535 Reviewed-on: https://chromium-review.googlesource.com/689123 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#504991} [modify] https://crrev.com/3f0b84caba981f29ff35518e326bb6ecb9e55ac8/chrome/browser/extensions/active_tab_permission_granter.cc [modify] https://crrev.com/3f0b84caba981f29ff35518e326bb6ecb9e55ac8/chrome/browser/extensions/app_process_apitest.cc [modify] https://crrev.com/3f0b84caba981f29ff35518e326bb6ecb9e55ac8/chrome/browser/extensions/isolated_app_browsertest.cc [modify] https://crrev.com/3f0b84caba981f29ff35518e326bb6ecb9e55ac8/chrome/browser/extensions/process_management_browsertest.cc [modify] https://crrev.com/3f0b84caba981f29ff35518e326bb6ecb9e55ac8/chrome/browser/extensions/process_manager_browsertest.cc [modify] https://crrev.com/3f0b84caba981f29ff35518e326bb6ecb9e55ac8/chrome/browser/extensions/webstore_installer.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7fe464e3ed60a3fda6f70a0369c31c499087a9da commit 7fe464e3ed60a3fda6f70a0369c31c499087a9da Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 13:05:23 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=aelias@chromium.org Bug: 666525 Change-Id: I0e469931918a07647477d581c317cc78f0c067f3 Reviewed-on: https://chromium-review.googlesource.com/688230 Reviewed-by: Alexandre Elias <aelias@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#504993} [modify] https://crrev.com/7fe464e3ed60a3fda6f70a0369c31c499087a9da/content/renderer/browser_render_view_browsertest.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/752b5929bff614ff4e48666816e78b55f66f98b5 commit 752b5929bff614ff4e48666816e78b55f66f98b5 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 13:06:36 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=michaelpg@chromium.org Bug: 666525 Change-Id: I5486880df5bf031d373c731213df577e918fe3b7 Reviewed-on: https://chromium-review.googlesource.com/689121 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#504995} [modify] https://crrev.com/752b5929bff614ff4e48666816e78b55f66f98b5/chrome/browser/ui/webui/app_launcher_page_ui.cc [modify] https://crrev.com/752b5929bff614ff4e48666816e78b55f66f98b5/chrome/browser/ui/webui/settings_utils_linux.cc [modify] https://crrev.com/752b5929bff614ff4e48666816e78b55f66f98b5/chrome/browser/ui/webui/webui_browsertest.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/097fd161ecd0ed4d65e2d537c6661a9ec676ef7b commit 097fd161ecd0ed4d65e2d537c6661a9ec676ef7b Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 13:38:45 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=lazyboy@chromium.org Bug: 666525 Change-Id: I97cc90888f35ef0fcacc7e1a83deaa3439904337 Reviewed-on: https://chromium-review.googlesource.com/689018 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505003} [modify] https://crrev.com/097fd161ecd0ed4d65e2d537c6661a9ec676ef7b/content/browser/browser_plugin/browser_plugin_guest.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d62e3b119487bc01b1794991b59b78c60a684212 commit d62e3b119487bc01b1794991b59b78c60a684212 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 13:46:46 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=grunell@chromium.org Bug: 666525 Change-Id: Ie88bf81e57607e8cf85a9dd1ff4e2d48998d01a2 Reviewed-on: https://chromium-review.googlesource.com/689094 Reviewed-by: Henrik Grunell <grunell@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505008} [modify] https://crrev.com/d62e3b119487bc01b1794991b59b78c60a684212/chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc [modify] https://crrev.com/d62e3b119487bc01b1794991b59b78c60a684212/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dddf6ec11c0aec4241c455764f578373e23d6a4f commit dddf6ec11c0aec4241c455764f578373e23d6a4f Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 14:04:00 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=lazyboy@chromium.org Bug: 666525 Change-Id: Iea1d1570be5b3f35e6811c2faa1d0f0411f8a379 Reviewed-on: https://chromium-review.googlesource.com/688895 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505013} [modify] https://crrev.com/dddf6ec11c0aec4241c455764f578373e23d6a4f/chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a814f33528de4f2ea67990e279f09645854cb57e commit a814f33528de4f2ea67990e279f09645854cb57e Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 14:36:03 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=avi@chromium.org Bug: 666525 Change-Id: I041a49290baec644180bd3f40c658dd0458d4cbe Reviewed-on: https://chromium-review.googlesource.com/689118 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#505017} [modify] https://crrev.com/a814f33528de4f2ea67990e279f09645854cb57e/chrome/browser/ui/javascript_dialogs/javascript_dialog_browsertest.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dbcc8f95054737f8c934942c692f64549486dfff commit dbcc8f95054737f8c934942c692f64549486dfff Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 14:37:18 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=lazyboy@chromium.org Bug: 666525 Change-Id: Idbab88621758712b7d3d6cdf3decdb023e5e65f2 Reviewed-on: https://chromium-review.googlesource.com/688899 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505018} [modify] https://crrev.com/dbcc8f95054737f8c934942c692f64549486dfff/chrome/browser/renderer_context_menu/render_view_context_menu.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb359a64598138d6d69346f5ad019bcf95533107 commit fb359a64598138d6d69346f5ad019bcf95533107 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 14:56:09 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=cmumford@chromium.org Bug: 666525 Change-Id: I74f82c441f22fa1809d8d8262fe5c71881843729 Reviewed-on: https://chromium-review.googlesource.com/689137 Reviewed-by: Chris Mumford <cmumford@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505023} [modify] https://crrev.com/fb359a64598138d6d69346f5ad019bcf95533107/content/browser/indexed_db/indexed_db_browsertest.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb75a7d44692a0d4801c0fb65a7ee965e1f90fea commit bb75a7d44692a0d4801c0fb65a7ee965e1f90fea Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 14:58:25 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=wjmaclean@chromium.org Bug: 666525 Change-Id: I703d25575a1fbd487c5703633e652afea83cee4d Reviewed-on: https://chromium-review.googlesource.com/688897 Reviewed-by: James MacLean <wjmaclean@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505024} [modify] https://crrev.com/bb75a7d44692a0d4801c0fb65a7ee965e1f90fea/components/zoom/zoom_controller.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0aeaef809e8860fb116ef46557d9445d170aa720 commit 0aeaef809e8860fb116ef46557d9445d170aa720 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 15:13:35 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=miu@chromium.org Bug: 666525 Change-Id: I518a4c7af8783cde82ca6b98796367e4530d94e0 Reviewed-on: https://chromium-review.googlesource.com/689016 Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505027} [modify] https://crrev.com/0aeaef809e8860fb116ef46557d9445d170aa720/ui/views/controls/webview/webview.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c06a6c394e4315808425c9dae7578a020dcf553 commit 7c06a6c394e4315808425c9dae7578a020dcf553 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 15:36:46 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=rsesek@chromium.org Bug: 666525 Change-Id: Iad735e1eddf2b56ec42f58a7c700628f7ef31df1 Reviewed-on: https://chromium-review.googlesource.com/689141 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505035} [modify] https://crrev.com/7c06a6c394e4315808425c9dae7578a020dcf553/chrome/browser/ui/cocoa/hung_renderer_controller.mm
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ff2d1563701e8fb17a760ca6c21b45262edec25 commit 2ff2d1563701e8fb17a760ca6c21b45262edec25 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 15:59:51 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=msw@chromium.org Bug: 666525 Change-Id: I310eea6b9f3dba136c2d46df235d9ce51b47b7a6 Reviewed-on: https://chromium-review.googlesource.com/689100 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505040} [modify] https://crrev.com/2ff2d1563701e8fb17a760ca6c21b45262edec25/chrome/browser/ui/browser_browsertest.cc [modify] https://crrev.com/2ff2d1563701e8fb17a760ca6c21b45262edec25/chrome/browser/ui/browser_navigator_browsertest.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6083866bec7c0dd4b647402cb37450e8ee801a1 commit c6083866bec7c0dd4b647402cb37450e8ee801a1 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 16:34:41 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=xiyuan@chromium.org Bug: 666525 Change-Id: I10358379bca0403dc8a3d27fbfd02a632cce65d3 Reviewed-on: https://chromium-review.googlesource.com/689104 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505049} [modify] https://crrev.com/c6083866bec7c0dd4b647402cb37450e8ee801a1/chrome/browser/chromeos/power/renderer_freezer.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb8c717cfb21c236d4e2fd8a7d1a6d0a44760547 commit eb8c717cfb21c236d4e2fd8a7d1a6d0a44760547 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 16:40:56 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=ryansturm@chromium.org Bug: 666525 Change-Id: Idf794d844071cc6a515b8366f0ebcf39c1f4c7e8 Reviewed-on: https://chromium-review.googlesource.com/689030 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505053} [modify] https://crrev.com/eb8c717cfb21c236d4e2fd8a7d1a6d0a44760547/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/563c5552574f5b7b21cbb49c42c78291b185f203 commit 563c5552574f5b7b21cbb49c42c78291b185f203 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 16:45:17 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=rdevlin.cronin@chromium.org Bug: 666525 Change-Id: Ie2ee9465ee7a8cca62b65d0852333ab9680ba6e3 Reviewed-on: https://chromium-review.googlesource.com/689020 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#505056} [modify] https://crrev.com/563c5552574f5b7b21cbb49c42c78291b185f203/chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f25fbd90fcdfb1e409002c412da39b4be8103dc commit 9f25fbd90fcdfb1e409002c412da39b4be8103dc Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 16:45:24 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=mattm@chromium.org Bug: 666525 Change-Id: I85916b4a88e15fb8a079b557c4fd8451eed8a5cd Reviewed-on: https://chromium-review.googlesource.com/689022 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#505057} [modify] https://crrev.com/9f25fbd90fcdfb1e409002c412da39b4be8103dc/chrome/browser/ui/webui/interstitials/interstitial_ui.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5440a8ec4df6e760ec1b5b0f2a5e88d5931c826c commit 5440a8ec4df6e760ec1b5b0f2a5e88d5931c826c Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 16:52:10 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=rdsmith@chromium.org Bug: 666525 Change-Id: I97adc233a59bd7edc9a95fce1c2db458a2caf48f Reviewed-on: https://chromium-review.googlesource.com/688005 Reviewed-by: Randy Smith <rdsmith@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505061} [modify] https://crrev.com/5440a8ec4df6e760ec1b5b0f2a5e88d5931c826c/content/browser/loader/resource_dispatcher_host_browsertest.cc [modify] https://crrev.com/5440a8ec4df6e760ec1b5b0f2a5e88d5931c826c/content/browser/loader/resource_dispatcher_host_unittest.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ddd9f05158b6cfebbb8f1e4f8089a962f4e1579 commit 0ddd9f05158b6cfebbb8f1e4f8089a962f4e1579 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 16:59:47 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=qinmin@chromium.org Bug: 666525 Change-Id: Iaefa09bfd0085d68c4b296e229197ed8171da6ca Reviewed-on: https://chromium-review.googlesource.com/688232 Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505065} [modify] https://crrev.com/0ddd9f05158b6cfebbb8f1e4f8089a962f4e1579/content/browser/media/android/browser_media_player_manager.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b6c7d1d7ab79c00017376ea28aaf1858dc69ad8 commit 2b6c7d1d7ab79c00017376ea28aaf1858dc69ad8 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 17:31:01 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=tbarzic@chromium.org Bug: 666525 Change-Id: I9411427ca99d25dd1081871d3db6400e8d16a418 Reviewed-on: https://chromium-review.googlesource.com/689131 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505077} [modify] https://crrev.com/2b6c7d1d7ab79c00017376ea28aaf1858dc69ad8/chrome/browser/extensions/api/processes/processes_api.cc [modify] https://crrev.com/2b6c7d1d7ab79c00017376ea28aaf1858dc69ad8/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ca36b95f4df0aebcffb6d4aa6e94fb8511e284bd commit ca36b95f4df0aebcffb6d4aa6e94fb8511e284bd Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 17:46:16 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=estark@chromium.org Bug: 666525 Change-Id: Ia5cfdc5682fdfa8f419de5341dc2868292adb74a Reviewed-on: https://chromium-review.googlesource.com/689110 Reviewed-by: Emily Stark <estark@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505083} [modify] https://crrev.com/ca36b95f4df0aebcffb6d4aa6e94fb8511e284bd/chrome/browser/ssl/ssl_browser_tests.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ce01288dd6b7baaf160676a3b75495c462be61b commit 6ce01288dd6b7baaf160676a3b75495c462be61b Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 18:08:39 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=lfg@chromium.org Bug: 666525 Change-Id: Ie278447778d4b066b1588ecd1c0748221aa14522 Reviewed-on: https://chromium-review.googlesource.com/689025 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#505087} [modify] https://crrev.com/6ce01288dd6b7baaf160676a3b75495c462be61b/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db050e233846fe8dcc1fa1d2a56728e16b473aa1 commit db050e233846fe8dcc1fa1d2a56728e16b473aa1 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 18:11:11 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=dpapad@chromium.org Bug: 666525 Change-Id: I7f56ede89ac9d6c72debb7fa018317539bcf8fc9 Reviewed-on: https://chromium-review.googlesource.com/689101 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505088} [modify] https://crrev.com/db050e233846fe8dcc1fa1d2a56728e16b473aa1/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9692f3c0a76a7eb2bc80a8c6ff778a6f2661ec0d commit 9692f3c0a76a7eb2bc80a8c6ff778a6f2661ec0d Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 18:31:48 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=achuith@chromium.org Bug: 666525 Change-Id: If9e66ef88a2d29360ddf0455de2f1489d324c895 Reviewed-on: https://chromium-review.googlesource.com/689106 Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505091} [modify] https://crrev.com/9692f3c0a76a7eb2bc80a8c6ff778a6f2661ec0d/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e0ce4ed78fa13769a9df7a0c2b4ffe5206c50d0 commit 9e0ce4ed78fa13769a9df7a0c2b4ffe5206c50d0 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 19:09:15 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=boliu@chromium.org Bug: 666525 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I13380dbc5c3339e7b7acdd28c574517b668d4cf2 Reviewed-on: https://chromium-review.googlesource.com/689026 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505111} [modify] https://crrev.com/9e0ce4ed78fa13769a9df7a0c2b4ffe5206c50d0/content/browser/child_process_launcher_browsertest.cc [modify] https://crrev.com/9e0ce4ed78fa13769a9df7a0c2b4ffe5206c50d0/content/browser/child_process_security_policy_browsertest.cc [modify] https://crrev.com/9e0ce4ed78fa13769a9df7a0c2b4ffe5206c50d0/content/browser/cross_site_transfer_browsertest.cc [modify] https://crrev.com/9e0ce4ed78fa13769a9df7a0c2b4ffe5206c50d0/content/browser/frame_host/frame_tree_browsertest.cc [modify] https://crrev.com/9e0ce4ed78fa13769a9df7a0c2b4ffe5206c50d0/content/browser/frame_host/interstitial_page_impl.cc [modify] https://crrev.com/9e0ce4ed78fa13769a9df7a0c2b4ffe5206c50d0/content/browser/frame_host/navigation_controller_impl_browsertest.cc [modify] https://crrev.com/9e0ce4ed78fa13769a9df7a0c2b4ffe5206c50d0/content/browser/frame_host/render_frame_host_manager_browsertest.cc [modify] https://crrev.com/9e0ce4ed78fa13769a9df7a0c2b4ffe5206c50d0/content/browser/security_exploit_browsertest.cc [modify] https://crrev.com/9e0ce4ed78fa13769a9df7a0c2b4ffe5206c50d0/content/browser/site_per_process_browsertest.cc [modify] https://crrev.com/9e0ce4ed78fa13769a9df7a0c2b4ffe5206c50d0/content/browser/web_contents/web_contents_impl_browsertest.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44dda9b60bd630d8dfe5c84d64315e09f4b79f55 commit 44dda9b60bd630d8dfe5c84d64315e09f4b79f55 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 19:12:07 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=torne@chromium.org Bug: 666525 Change-Id: I3600da8b60fb8a8a4d3f2c7e119777a4212afc1d Reviewed-on: https://chromium-review.googlesource.com/688767 Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505113} [modify] https://crrev.com/44dda9b60bd630d8dfe5c84d64315e09f4b79f55/content/browser/android/java/gin_java_bridge_dispatcher_host.cc [modify] https://crrev.com/44dda9b60bd630d8dfe5c84d64315e09f4b79f55/content/browser/android/java/gin_java_bridge_message_filter.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab7b615b6b1066f87870c55fcdd1d4696f9be5ae commit ab7b615b6b1066f87870c55fcdd1d4696f9be5ae Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 19:55:59 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=fgorski@chromium.org Bug: 666525 Change-Id: I6e70f5ac9d552ad575fd9339f1af8d39bf04bed7 Reviewed-on: https://chromium-review.googlesource.com/689105 Reviewed-by: Filip Gorski <fgorski@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505123} [modify] https://crrev.com/ab7b615b6b1066f87870c55fcdd1d4696f9be5ae/chrome/browser/offline_pages/android/downloads/offline_page_download_bridge.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24e9ccfde57c0943a8ac87a5e81e6598396de190 commit 24e9ccfde57c0943a8ac87a5e81e6598396de190 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 20:06:22 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=timloh@chromium.org Bug: 666525 Change-Id: If15d845c29b7a81d392aa35774ed243f7db618e8 Reviewed-on: https://chromium-review.googlesource.com/689028 Reviewed-by: Justin DeWitt <dewittj@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505126} [modify] https://crrev.com/24e9ccfde57c0943a8ac87a5e81e6598396de190/chrome/browser/notifications/notification_permission_context_unittest.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1452b891704eead0ae451c59074e34b3c46c6d69 commit 1452b891704eead0ae451c59074e34b3c46c6d69 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 20:10:09 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=benwells@chromium.org Bug: 666525 Change-Id: I4817794f96d6b0b428ad2be9d465452e2a863a85 Reviewed-on: https://chromium-review.googlesource.com/688170 Reviewed-by: Adrienne Porter Felt <felt@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505127} [modify] https://crrev.com/1452b891704eead0ae451c59074e34b3c46c6d69/chrome/browser/permissions/permission_context_base_unittest.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57ade7c91ab13a041a1e37a9b045e8634994b4a3 commit 57ade7c91ab13a041a1e37a9b045e8634994b4a3 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 20:26:33 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=sky@chromium.org Bug: 666525 Change-Id: Ifbc74b5399f1b05f40394789b5f0f248dbd03452 Reviewed-on: https://chromium-review.googlesource.com/689112 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505136} [modify] https://crrev.com/57ade7c91ab13a041a1e37a9b045e8634994b4a3/chrome/browser/crash_recovery_browsertest.cc [modify] https://crrev.com/57ade7c91ab13a041a1e37a9b045e8634994b4a3/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a3b71f36afb95f15098ce23a81b29f7d5e172f2 commit 4a3b71f36afb95f15098ce23a81b29f7d5e172f2 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 20:29:28 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=sky@chromium.org Bug: 666525 Change-Id: Ib74387545eacb69e0d0f20feae2d83a8b8649733 Reviewed-on: https://chromium-review.googlesource.com/689023 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505137} [modify] https://crrev.com/4a3b71f36afb95f15098ce23a81b29f7d5e172f2/chrome/browser/ui/tabs/tab_strip_model.cc [modify] https://crrev.com/4a3b71f36afb95f15098ce23a81b29f7d5e172f2/chrome/browser/ui/tabs/tab_strip_model_unittest.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/020d22695214c706ed96c6d05356ee83f4cc1acd commit 020d22695214c706ed96c6d05356ee83f4cc1acd Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 20:46:00 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=pasko@chromium.org Bug: 666525 Change-Id: I25740f166c501b336a5782553a5be68fd3840f62 Reviewed-on: https://chromium-review.googlesource.com/689015 Reviewed-by: David Benjamin <davidben@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505146} [modify] https://crrev.com/020d22695214c706ed96c6d05356ee83f4cc1acd/chrome/browser/prerender/prerender_browsertest.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/658bcee5d36f5667b3150680453fc2cf4a4700d1 commit 658bcee5d36f5667b3150680453fc2cf4a4700d1 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 21:31:07 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=asvitkine@chromium.org Bug: 666525 Change-Id: Ic899f9f4a4c67104770271c5fcef27251f524510 Reviewed-on: https://chromium-review.googlesource.com/688768 Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505162} [modify] https://crrev.com/658bcee5d36f5667b3150680453fc2cf4a4700d1/chrome/browser/metrics/renderer_uptime_web_contents_observer.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf78893d5bc02dd1b561ee47de26e8b196320ecb commit cf78893d5bc02dd1b561ee47de26e8b196320ecb Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 22:29:57 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=finnur@chromium.org Bug: 666525 Change-Id: I465d93e5c5a36a062f536e7981fd0c9d93bc0313 Reviewed-on: https://chromium-review.googlesource.com/689097 Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505194} [modify] https://crrev.com/cf78893d5bc02dd1b561ee47de26e8b196320ecb/extensions/browser/extension_host.cc [modify] https://crrev.com/cf78893d5bc02dd1b561ee47de26e8b196320ecb/extensions/test/background_page_watcher.cc
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe91571c2780d818fead2f50447627f4bce619a1 commit fe91571c2780d818fead2f50447627f4bce619a1 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 28 22:42:25 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=dgozman@chromium.org Bug: 666525 Change-Id: I280a42f5038e26cefd16f01dc656ba96b7b96828 Reviewed-on: https://chromium-review.googlesource.com/689120 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505197} [modify] https://crrev.com/fe91571c2780d818fead2f50447627f4bce619a1/content/browser/devtools/devtools_frontend_host_impl.cc
,
Sep 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb8672fa5cc0a5f5782b0964107451a4e647359e commit bb8672fa5cc0a5f5782b0964107451a4e647359e Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Fri Sep 29 15:58:41 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=tommycli@chromium.org Bug: 666525 Change-Id: Ia641a614a5129624424e1c81b0a945befddd8cd5 Reviewed-on: https://chromium-review.googlesource.com/688773 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#505379} [modify] https://crrev.com/bb8672fa5cc0a5f5782b0964107451a4e647359e/chrome/browser/plugins/chrome_plugin_service_filter_unittest.cc [modify] https://crrev.com/bb8672fa5cc0a5f5782b0964107451a4e647359e/chrome/browser/plugins/pdf_iframe_navigation_throttle.cc [modify] https://crrev.com/bb8672fa5cc0a5f5782b0964107451a4e647359e/chrome/browser/plugins/pdf_plugin_placeholder_observer.cc
,
Sep 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e145d7efc6da7f51b74e992b9ee907e70222334 commit 8e145d7efc6da7f51b74e992b9ee907e70222334 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Fri Sep 29 16:09:54 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=lcwu@chromium.org Bug: 666525 Change-Id: I74bb2e240ca4a54ac280c8b8d770f88a34dd1f4f Reviewed-on: https://chromium-review.googlesource.com/689102 Reviewed-by: Luke Halliwell <halliwell@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505383} [modify] https://crrev.com/8e145d7efc6da7f51b74e992b9ee907e70222334/chromecast/browser/cast_content_browser_client.cc
,
Sep 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/078f4bad323ed290d5306c0263ac48ef38f6e0c5 commit 078f4bad323ed290d5306c0263ac48ef38f6e0c5 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Fri Sep 29 16:37:17 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=timloh@chromium.org Bug: 666525 Change-Id: Ib68682643dcf49005f05fe8b23a33a078f6bcef9 Reviewed-on: https://chromium-review.googlesource.com/689029 Reviewed-by: Josh Karlin <jkarlin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505389} [modify] https://crrev.com/078f4bad323ed290d5306c0263ac48ef38f6e0c5/chrome/browser/background_sync/background_sync_permission_context_unittest.cc
,
Sep 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61fd350272510a2c0421e76514f54b46cbf6caf8 commit 61fd350272510a2c0421e76514f54b46cbf6caf8 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Fri Sep 29 17:08:58 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=ekaramad@chromium.org Bug: 666525 Change-Id: I8c9c9436301eabd31b5bfe1054956c63d5457dfc Reviewed-on: https://chromium-review.googlesource.com/689107 Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505399} [modify] https://crrev.com/61fd350272510a2c0421e76514f54b46cbf6caf8/extensions/browser/guest_view/extension_options/extension_options_guest.cc [modify] https://crrev.com/61fd350272510a2c0421e76514f54b46cbf6caf8/extensions/browser/guest_view/extension_view/extension_view_guest.cc [modify] https://crrev.com/61fd350272510a2c0421e76514f54b46cbf6caf8/extensions/browser/guest_view/extensions_guest_view_manager_delegate.cc [modify] https://crrev.com/61fd350272510a2c0421e76514f54b46cbf6caf8/extensions/browser/guest_view/web_view/web_view_apitest.cc [modify] https://crrev.com/61fd350272510a2c0421e76514f54b46cbf6caf8/extensions/browser/guest_view/web_view/web_view_guest.cc
,
Sep 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9ae372f20e1d63eaf5de0a18fd28aeb4e928416 commit e9ae372f20e1d63eaf5de0a18fd28aeb4e928416 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Fri Sep 29 17:37:38 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=treib@chromium.org Bug: 666525 Change-Id: Iff2b7f18d4c593b10846eac3c8ec5a03a0b0ef6d Reviewed-on: https://chromium-review.googlesource.com/689114 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505408} [modify] https://crrev.com/e9ae372f20e1d63eaf5de0a18fd28aeb4e928416/chrome/browser/search/search.cc [modify] https://crrev.com/e9ae372f20e1d63eaf5de0a18fd28aeb4e928416/chrome/browser/search/search_unittest.cc [modify] https://crrev.com/e9ae372f20e1d63eaf5de0a18fd28aeb4e928416/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/e9ae372f20e1d63eaf5de0a18fd28aeb4e928416/content/browser/web_contents/web_contents_impl.h [modify] https://crrev.com/e9ae372f20e1d63eaf5de0a18fd28aeb4e928416/content/public/browser/web_contents.h [modify] https://crrev.com/e9ae372f20e1d63eaf5de0a18fd28aeb4e928416/content/test/test_web_contents.cc [modify] https://crrev.com/e9ae372f20e1d63eaf5de0a18fd28aeb4e928416/content/test/test_web_contents.h
,
Sep 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b3182253006df2ca3297a5182da86627cfd37b0 commit 1b3182253006df2ca3297a5182da86627cfd37b0 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Fri Sep 29 18:13:45 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=estade@chromium.org Bug: 666525 Change-Id: Ia364e50c35362c9fd1f4bfecd59d022e1dd42dc2 Reviewed-on: https://chromium-review.googlesource.com/688229 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505423} [modify] https://crrev.com/1b3182253006df2ca3297a5182da86627cfd37b0/chrome/browser/ui/webui/ntp/new_tab_ui.cc
,
Sep 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f01bba33d31d2b2e096530014125c1f07813e867 commit f01bba33d31d2b2e096530014125c1f07813e867 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Fri Sep 29 20:13:54 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=sgurun@chromium.org Bug: 666525 Change-Id: I59af4e0f4a1ac74e216e140436e7e6cf72cc6e1f Reviewed-on: https://chromium-review.googlesource.com/688762 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505451} [modify] https://crrev.com/f01bba33d31d2b2e096530014125c1f07813e867/android_webview/browser/aw_contents.cc [modify] https://crrev.com/f01bba33d31d2b2e096530014125c1f07813e867/android_webview/browser/state_serializer.cc
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de8cfb511d9881d7961fb8856bd202d975922a56 commit de8cfb511d9881d7961fb8856bd202d975922a56 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Mon Oct 02 16:04:18 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=nyquist@chromium.org Bug: 666525 Change-Id: I08eef35a6c2823d3e760643e2e01176cce8bfda7 Reviewed-on: https://chromium-review.googlesource.com/689099 Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505631} [modify] https://crrev.com/de8cfb511d9881d7961fb8856bd202d975922a56/chrome/browser/android/tab_android.cc
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25b64efbc011e50768fce9474081d5ebebb71484 commit 25b64efbc011e50768fce9474081d5ebebb71484 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Mon Oct 02 18:04:16 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=yfriedman@chromium.org Bug: 666525 Change-Id: I67384af73215bcea33d06454e69b9813807f2f08 Reviewed-on: https://chromium-review.googlesource.com/689138 Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505676} [modify] https://crrev.com/25b64efbc011e50768fce9474081d5ebebb71484/chrome/browser/android/download/download_controller.cc
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b55fc49feb9c733f910baa34b500bf1bcf9d4756 commit b55fc49feb9c733f910baa34b500bf1bcf9d4756 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Mon Oct 02 18:38:34 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=felt@chromium.org Bug: 666525 Change-Id: Icde83bc5446d80758b3033025907ad472cea43e4 Reviewed-on: https://chromium-review.googlesource.com/689021 Reviewed-by: Adrienne Porter Felt <felt@chromium.org> Reviewed-by: Nathan Parker <nparker@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505692} [modify] https://crrev.com/b55fc49feb9c733f910baa34b500bf1bcf9d4756/chrome/browser/safe_browsing/client_side_detection_host.cc [modify] https://crrev.com/b55fc49feb9c733f910baa34b500bf1bcf9d4756/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc [modify] https://crrev.com/b55fc49feb9c733f910baa34b500bf1bcf9d4756/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc [modify] https://crrev.com/b55fc49feb9c733f910baa34b500bf1bcf9d4756/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc [modify] https://crrev.com/b55fc49feb9c733f910baa34b500bf1bcf9d4756/chrome/browser/safe_browsing/threat_details_unittest.cc [modify] https://crrev.com/b55fc49feb9c733f910baa34b500bf1bcf9d4756/chrome/browser/safe_browsing/ui_manager_unittest.cc [modify] https://crrev.com/b55fc49feb9c733f910baa34b500bf1bcf9d4756/components/safe_browsing/triggers/ad_sampler_trigger.cc
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72a4f8b49e6c4438353bbf52fe6ccce7baa84f83 commit 72a4f8b49e6c4438353bbf52fe6ccce7baa84f83 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Mon Oct 02 18:40:57 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=timloh@chromium.org Bug: 666525 Change-Id: I5eda6f194bfd823a35762e39cc671f45586d9e90 Reviewed-on: https://chromium-review.googlesource.com/688761 Reviewed-by: Tommi <tommi@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505696} [modify] https://crrev.com/72a4f8b49e6c4438353bbf52fe6ccce7baa84f83/chrome/browser/media/midi_sysex_permission_context_unittest.cc
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94cca91f0b48939cf9a368a8dd65cb81460b935f commit 94cca91f0b48939cf9a368a8dd65cb81460b935f Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Mon Oct 02 18:50:27 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=rjkroege@chromium.org Bug: 666525 Change-Id: I5a09740d57ed0be3ae1498bad574a54219071961 Reviewed-on: https://chromium-review.googlesource.com/689126 Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505703} [modify] https://crrev.com/94cca91f0b48939cf9a368a8dd65cb81460b935f/content/browser/renderer_host/render_widget_host_view_browsertest.cc
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c773bbdfeb6e99018c21359158edb1a2424f842d commit c773bbdfeb6e99018c21359158edb1a2424f842d Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Mon Oct 02 19:25:29 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=wjmaclean@chromium.org Bug: 666525 Change-Id: Id5848733de81e87b8df9e2f269a9d0c403bf42e5 Reviewed-on: https://chromium-review.googlesource.com/688231 Reviewed-by: James MacLean <wjmaclean@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505713} [modify] https://crrev.com/c773bbdfeb6e99018c21359158edb1a2424f842d/content/browser/host_zoom_map_impl.cc
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ff155220d97ac1d4e9e2ddd6a1e31be03363725 commit 1ff155220d97ac1d4e9e2ddd6a1e31be03363725 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Mon Oct 02 19:26:52 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=jam@chromium.org Bug: 666525 Change-Id: I53cd4da58f10f8a902e7a59bfd40e455ec34404c Reviewed-on: https://chromium-review.googlesource.com/688771 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505716} [modify] https://crrev.com/1ff155220d97ac1d4e9e2ddd6a1e31be03363725/chrome/browser/ui/tab_contents/core_tab_helper.cc
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2910db72911624d3f93eb66cdd037413a8d850ce commit 2910db72911624d3f93eb66cdd037413a8d850ce Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Mon Oct 02 19:44:03 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=timloh@chromium.org Bug: 666525 Change-Id: I030980776cffd7bbc889b15ba8b320f642e2df0d Reviewed-on: https://chromium-review.googlesource.com/689115 Reviewed-by: Joshua Bell <jsbell@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505730} [modify] https://crrev.com/2910db72911624d3f93eb66cdd037413a8d850ce/chrome/browser/storage/durable_storage_permission_context_unittest.cc
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f14b545b51e92553d706c2e740aa9f9a648e3ed9 commit f14b545b51e92553d706c2e740aa9f9a648e3ed9 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Mon Oct 02 20:10:34 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=tommi@chromium.org Bug: 666525 Change-Id: I6182a024fed44f6f596e1570be839f3cf3cfd891 Reviewed-on: https://chromium-review.googlesource.com/689122 Reviewed-by: Tommi <tommi@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505748} [modify] https://crrev.com/f14b545b51e92553d706c2e740aa9f9a648e3ed9/content/public/test/browser_test_utils.cc
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb9a4affd2f01425021231d519794bef54b2cbee commit cb9a4affd2f01425021231d519794bef54b2cbee Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Mon Oct 02 20:17:42 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=pkasting@chromium.org Bug: 666525 Change-Id: I81b69d00045c3de5f5ab40fb6b6e2ffac8d31768 Reviewed-on: https://chromium-review.googlesource.com/689019 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505751} [modify] https://crrev.com/cb9a4affd2f01425021231d519794bef54b2cbee/chrome/browser/ui/search_engines/search_engine_tab_helper.cc
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a348242518b2ca6bb0fe8af6e5885e473732f3cb commit a348242518b2ca6bb0fe8af6e5885e473732f3cb Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Mon Oct 02 20:31:34 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=wjmaclean@chromium.org Bug: 666525 Change-Id: Idb83f3e7ae57c5ec284b8cda2e35b0f393ac3613 Reviewed-on: https://chromium-review.googlesource.com/688770 Reviewed-by: James MacLean <wjmaclean@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505762} [modify] https://crrev.com/a348242518b2ca6bb0fe8af6e5885e473732f3cb/content/browser/host_zoom_map_impl_browsertest.cc
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a192ffbcdfaea400a01384c6743b2872ac733a7e commit a192ffbcdfaea400a01384c6743b2872ac733a7e Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Mon Oct 02 20:36:38 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=wjmaclean@chromium.org Bug: 666525 Change-Id: I62249bb683f291b34da02bc2c20a2ce2668e6078 Reviewed-on: https://chromium-review.googlesource.com/688173 Reviewed-by: James MacLean <wjmaclean@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505764} [modify] https://crrev.com/a192ffbcdfaea400a01384c6743b2872ac733a7e/chrome/browser/ui/zoom/zoom_controller_browsertest.cc
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a77e434c2c222ede9780ca292510692f601acca5 commit a77e434c2c222ede9780ca292510692f601acca5 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Mon Oct 02 21:20:57 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=wjmaclean@chromium.org Bug: 666525 Change-Id: If468bececcb1ea017a75b363c0208b3b6b182e97 Reviewed-on: https://chromium-review.googlesource.com/689108 Reviewed-by: James MacLean <wjmaclean@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505787} [modify] https://crrev.com/a77e434c2c222ede9780ca292510692f601acca5/components/guest_view/browser/guest_view_manager.cc
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b934da7eca4c42338145bfc5de1fd07f73f020ab commit b934da7eca4c42338145bfc5de1fd07f73f020ab Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Mon Oct 02 22:38:18 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=wjmaclean@chromium.org Bug: 666525 Change-Id: I2adf34e7e6d72b4e8391fa3b1e141cddaf0c9288 Reviewed-on: https://chromium-review.googlesource.com/688769 Reviewed-by: James MacLean <wjmaclean@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505822} [modify] https://crrev.com/b934da7eca4c42338145bfc5de1fd07f73f020ab/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/382773265bc845437e2b2abb050768de08ebea3b commit 382773265bc845437e2b2abb050768de08ebea3b Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Mon Oct 02 23:52:48 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=raymes@chromium.org Bug: 666525 Change-Id: I168b6fe1b435c1df42affb65266a9e1099d4cb90 Reviewed-on: https://chromium-review.googlesource.com/688171 Reviewed-by: Raymes Khoury <raymes@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505859} [modify] https://crrev.com/382773265bc845437e2b2abb050768de08ebea3b/chrome/browser/geolocation/geolocation_permission_context_unittest.cc
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c0acdb95be2c6ed9af28f4746733cc89a7bb1af commit 0c0acdb95be2c6ed9af28f4746733cc89a7bb1af Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Tue Oct 03 00:03:08 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=raymes@chromium.org Bug: 666525 Change-Id: I233ff68af8f61aebb07aaed58fbe2c197b970322 Reviewed-on: https://chromium-review.googlesource.com/689136 Reviewed-by: Raymes Khoury <raymes@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505863} [modify] https://crrev.com/0c0acdb95be2c6ed9af28f4746733cc89a7bb1af/chrome/browser/media/webrtc/media_stream_devices_controller_browsertest.cc
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3262c01e36208190404ee336bb4f0257b80a19f commit d3262c01e36208190404ee336bb4f0257b80a19f Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Tue Oct 03 00:20:43 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=raymes@chromium.org Bug: 666525 Change-Id: Ic44b6d3465e3affd405f188c7743fbe543f846c4 Reviewed-on: https://chromium-review.googlesource.com/688898 Reviewed-by: Raymes Khoury <raymes@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505874} [modify] https://crrev.com/d3262c01e36208190404ee336bb4f0257b80a19f/chrome/browser/content_settings/tab_specific_content_settings.cc
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc8f9d8f6b796bbad05aa75e5e4b3d005deaccd4 commit dc8f9d8f6b796bbad05aa75e5e4b3d005deaccd4 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Tue Oct 03 15:29:59 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=zhenw@chromium.org Bug: 666525 Change-Id: I66c198dd94d6d5963e8edcca4c94033e62aeab47 Reviewed-on: https://chromium-review.googlesource.com/689027 Reviewed-by: Zhen Wang <zhenw@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#506046} [modify] https://crrev.com/dc8f9d8f6b796bbad05aa75e5e4b3d005deaccd4/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe_browsertest.cc [modify] https://crrev.com/dc8f9d8f6b796bbad05aa75e5e4b3d005deaccd4/chrome/browser/resource_coordinator/tab_manager.cc [modify] https://crrev.com/dc8f9d8f6b796bbad05aa75e5e4b3d005deaccd4/chrome/browser/resource_coordinator/tab_manager_browsertest.cc [modify] https://crrev.com/dc8f9d8f6b796bbad05aa75e5e4b3d005deaccd4/chrome/browser/resource_coordinator/tab_manager_unittest.cc
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ca83344664eff09193859590064df2c6c5dfd1e9 commit ca83344664eff09193859590064df2c6c5dfd1e9 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Tue Oct 03 18:03:35 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=qinmin@chromium.org Bug: 666525 Change-Id: I804f5b12bf9763be750a9ec9d6ac141cba5d6e05 Reviewed-on: https://chromium-review.googlesource.com/689128 Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#506100} [modify] https://crrev.com/ca83344664eff09193859590064df2c6c5dfd1e9/chrome/browser/download/save_package_file_picker.cc
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bac919407903883141ceae0fc35760b79615ca1f commit bac919407903883141ceae0fc35760b79615ca1f Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Tue Oct 03 18:40:06 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=jyasskin@chromium.org Bug: 666525 Change-Id: I583ec4076732a84814ed05e2fe06b1d07ded6dee Reviewed-on: https://chromium-review.googlesource.com/688760 Reviewed-by: Jeffrey Yasskin <jyasskin@chromium.org> Reviewed-by: Conley Owens <cco3@chromium.org> Commit-Queue: Jeffrey Yasskin <jyasskin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#506116} [modify] https://crrev.com/bac919407903883141ceae0fc35760b79615ca1f/chrome/browser/web_bluetooth_browsertest.cc
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0623c968f2610133bc1b98bb203d2b12e10e090 commit c0623c968f2610133bc1b98bb203d2b12e10e090 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Tue Oct 03 19:02:45 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=qinmin@chromium.org Bug: 666525 Change-Id: Ie6ee9411a14e1b91e17cb5c83801a1ea5410b936 Reviewed-on: https://chromium-review.googlesource.com/689124 Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#506128} [modify] https://crrev.com/c0623c968f2610133bc1b98bb203d2b12e10e090/content/browser/download/mhtml_generation_browsertest.cc [modify] https://crrev.com/c0623c968f2610133bc1b98bb203d2b12e10e090/content/browser/download/save_package.cc
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d7fc4b795414b438ee7f22515e4c0683918270f commit 7d7fc4b795414b438ee7f22515e4c0683918270f Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Wed Oct 04 15:05:04 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=samarth@chromium.org Bug: 666525 Change-Id: Id663ba6297c2513f71343452a1b2f56a1528c17d Reviewed-on: https://chromium-review.googlesource.com/689140 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#506389} [modify] https://crrev.com/7d7fc4b795414b438ee7f22515e4c0683918270f/chrome/browser/ui/browser_instant_controller.cc
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76569fa57bac3e376aaca158897f7a8c98d8a371 commit 76569fa57bac3e376aaca158897f7a8c98d8a371 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Wed Oct 04 15:50:35 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=samarth@chromium.org Bug: 666525 Change-Id: If2a349829b2de02a166403075358e0e7af5f7020 Reviewed-on: https://chromium-review.googlesource.com/689117 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#506400} [modify] https://crrev.com/76569fa57bac3e376aaca158897f7a8c98d8a371/chrome/browser/ui/search/search_tab_helper.cc
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0917b6dd875967d5e1d1a3275abdda0a7381163 commit d0917b6dd875967d5e1d1a3275abdda0a7381163 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Wed Oct 04 16:06:52 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=samarth@chromium.org Bug: 666525 Change-Id: I4345acbb935b022be52eadb8789892b33e5b8e96 Reviewed-on: https://chromium-review.googlesource.com/688772 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#506402} [modify] https://crrev.com/d0917b6dd875967d5e1d1a3275abdda0a7381163/chrome/browser/ui/browser_instant_controller_unittest.cc
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b185605f62333a0f974d50c421d7694cce35259b commit b185605f62333a0f974d50c421d7694cce35259b Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Wed Oct 04 16:20:25 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=sky@chromium.org Bug: 666525 Change-Id: I8167f7c6577f457939f2d2379640523f583c9dff Reviewed-on: https://chromium-review.googlesource.com/689109 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#506405} [modify] https://crrev.com/b185605f62333a0f974d50c421d7694cce35259b/chrome/browser/ui/views/external_protocol_dialog_browsertest.cc [modify] https://crrev.com/b185605f62333a0f974d50c421d7694cce35259b/chrome/browser/ui/views/hung_renderer_view.cc
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e9b7c926c5361cf064945b2f234b4d285d2c99e commit 6e9b7c926c5361cf064945b2f234b4d285d2c99e Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Wed Oct 04 17:37:40 2017 Remove a no-op + not overriden WebContentsDelegate::WebUISend method. The content::WebContentsDelegate::WebUISend virtual method is a no-op and is not overriden anywhere. Therefore it should be safe to just delete this method and stop calling it (since calling it is a no-op). The only caller of content::WebContentsDelegate::WebUISend was WebContentsImpl::OnWebUISend method which is also deleted by this CL. ViewHostMsg_WebUISend is *not* being deleted - it is still handled by the browser in content::WebUIImpl::OnWebUISend. Bug: 683418, 666525 Change-Id: Icf6272b0df3f4359e758e04ddefd026402b9ea03 Reviewed-on: https://chromium-review.googlesource.com/698348 Commit-Queue: Nick Carter <nick@chromium.org> Reviewed-by: Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#506435} [modify] https://crrev.com/6e9b7c926c5361cf064945b2f234b4d285d2c99e/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/6e9b7c926c5361cf064945b2f234b4d285d2c99e/content/browser/web_contents/web_contents_impl.h [modify] https://crrev.com/6e9b7c926c5361cf064945b2f234b4d285d2c99e/content/public/browser/web_contents_delegate.h
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ab165aa26ba1b8dfac7829482316de1efef71c9 commit 5ab165aa26ba1b8dfac7829482316de1efef71c9 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Wed Oct 04 18:20:10 2017 Removing callers of the WebContents::GetRenderProcessHost() method. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=cylee@chromium.org Bug: 666525 Change-Id: I08c5ee78b78aa268e37fe78651b915b12da0f635 Reviewed-on: https://chromium-review.googlesource.com/689024 Reviewed-by: Cheng-Yu Lee <cylee@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#506448} [modify] https://crrev.com/5ab165aa26ba1b8dfac7829482316de1efef71c9/chrome/browser/resource_coordinator/tab_manager_delegate_chromeos.cc
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/055fe8f2c6931931073b0f923c541df65dc8eafa commit 055fe8f2c6931931073b0f923c541df65dc8eafa Author: Dan Beam <dbeam@chromium.org> Date: Wed Oct 04 23:23:36 2017 Remove code dealing with Web UIs living in subframes This was needed when the "uber" page hosted multiple different iframes: <iframe src="chrome://settings"></iframe> <iframe src="chrome://extensions"></iframe> <iframe src="chrome://history"></iframe> <iframe src="chrome://about"></iframe> for code separation purposes. Because the "uber" page UI has been replaced and the replacements don't use <iframe>s, the code can be removed. R=creis@chromium.org BUG=683418,666525 Change-Id: I1ee60a3fe74af3bfc78503740cbccf134ea41bd8 Reviewed-on: https://chromium-review.googlesource.com/696718 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#506558} [modify] https://crrev.com/055fe8f2c6931931073b0f923c541df65dc8eafa/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc [modify] https://crrev.com/055fe8f2c6931931073b0f923c541df65dc8eafa/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/055fe8f2c6931931073b0f923c541df65dc8eafa/content/browser/web_contents/web_contents_impl.h [modify] https://crrev.com/055fe8f2c6931931073b0f923c541df65dc8eafa/content/browser/webui/web_ui_impl.cc [modify] https://crrev.com/055fe8f2c6931931073b0f923c541df65dc8eafa/content/browser/webui/web_ui_impl.h [modify] https://crrev.com/055fe8f2c6931931073b0f923c541df65dc8eafa/content/public/browser/web_contents.h [modify] https://crrev.com/055fe8f2c6931931073b0f923c541df65dc8eafa/content/public/browser/web_ui.h [modify] https://crrev.com/055fe8f2c6931931073b0f923c541df65dc8eafa/content/public/test/test_web_ui.cc [modify] https://crrev.com/055fe8f2c6931931073b0f923c541df65dc8eafa/content/public/test/test_web_ui.h
,
Oct 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/029231044beed18a9aee6c7803774ec1fac0ba1f commit 029231044beed18a9aee6c7803774ec1fac0ba1f Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Mon Oct 09 18:11:37 2017 Convert ViewHostMsg_WebUISend so that it is sent via frame (not view). Bug: 683418, 666525 Change-Id: Id8bf3fa0a69b783b73a075a54ff7154e6d4c7a1e Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Reviewed-on: https://chromium-review.googlesource.com/701415 Reviewed-by: Nick Carter <nick@chromium.org> Reviewed-by: Rachel Blum <groby@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#507414} [modify] https://crrev.com/029231044beed18a9aee6c7803774ec1fac0ba1f/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/029231044beed18a9aee6c7803774ec1fac0ba1f/content/browser/webui/web_ui_impl.cc [modify] https://crrev.com/029231044beed18a9aee6c7803774ec1fac0ba1f/content/browser/webui/web_ui_impl.h [modify] https://crrev.com/029231044beed18a9aee6c7803774ec1fac0ba1f/content/common/frame_messages.h [modify] https://crrev.com/029231044beed18a9aee6c7803774ec1fac0ba1f/content/common/view_messages.h [modify] https://crrev.com/029231044beed18a9aee6c7803774ec1fac0ba1f/content/renderer/web_ui_extension.cc [modify] https://crrev.com/029231044beed18a9aee6c7803774ec1fac0ba1f/docs/webui_explainer.md
,
Oct 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31ab5bf35abaffc0e2a07e127a6cd2d702177d80 commit 31ab5bf35abaffc0e2a07e127a6cd2d702177d80 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Mon Oct 09 21:34:59 2017 Removing WebContents::GetRenderProcessHost() method [~reland]. WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL removes this API altogether. This CL is a reland of r504862 (very trimmed down thanks to prelanding of many other, small CLs that got rid of most of the callers of the WebContents::GetRenderProcessHost method). For the record, below is a list of existing bugs that have been uncovered or highlighted during the reviews of CLs leading up to the removal of the problematic API: - https://crbug.com/715924: Headless OOPIF support - https://crbug.com/767519: Android WebView code duplication - https://crbug.com/767526: Handling of unresponsive renderers - https://crbug.com/767539: TabSpecificContentSettings - https://crbug.com/767557: ExtensionMsg_UpdateTabSpecificPermissions - https://crbug.com/767563: chrome.processes.getProcessIdForTab - https://crbug.com/769385: WebViewInternalAddContentScriptsFunction - https://crbug.com/769461: BrowserTag/WebView owner tracking - https://crbug.com/769479: PrintPreviewDialogController - https://crbug.com/770758: web_cache::WebCacheManager Bug: 666525 Change-Id: Ida372c9a93c4d37abbfdf5bb3c175b439b22abf8 Tbr: nick@chromium.org, avi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/707309 Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#507496} [modify] https://crrev.com/31ab5bf35abaffc0e2a07e127a6cd2d702177d80/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/31ab5bf35abaffc0e2a07e127a6cd2d702177d80/content/browser/web_contents/web_contents_impl.h [modify] https://crrev.com/31ab5bf35abaffc0e2a07e127a6cd2d702177d80/content/browser/webui/web_ui_mojo_browsertest.cc [modify] https://crrev.com/31ab5bf35abaffc0e2a07e127a6cd2d702177d80/content/public/browser/web_contents.h [modify] https://crrev.com/31ab5bf35abaffc0e2a07e127a6cd2d702177d80/content/test/content_browser_test_test.cc [modify] https://crrev.com/31ab5bf35abaffc0e2a07e127a6cd2d702177d80/content/test/test_navigation_url_loader.cc
,
Oct 10
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 10
Hmmm... the following methods are no longer present in the code: - WebContentsImpl::GetRenderProcessHost - WebContentsImpl::GetRoutingID So, maybe this bug can just be marked as Fixed? |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by alex...@chromium.org
, Nov 17 2016