New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666523 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

Replace colors in autofill popup_contants.h with colors from ui::NativeTheme

Project Member Reported by lshang@chromium.org, Nov 17 2016

Issue description

Colors in chrome/browser/ui/autofill/popup_constants.h ought to be replaced by getting colors from ui::NativeTheme for consistency and accessibility.

 
Owner: ----
Status: Available (was: Assigned)

Comment 2 by ajha@chromium.org, Dec 5 2016

Components: UI>Browser>Autofill
Labels: M-57

Comment 3 by ma...@chromium.org, Dec 5 2016

Cc: lshang@chromium.org
Owner: csashi@google.com
Status: Assigned (was: Available)
Hi Sashi, this could be an interesting starter bug for someone on your team. Assigning to you tentatively.

Comment 4 by csashi@google.com, Dec 5 2016

Owner: jiahuiguo@google.com
Sounds good. Jason - do you want to take a look? Thanks.
Cc: jsaul@google.com
Labels: OS-All
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9f57d21417b53ef91e922a63204d950010d0251

commit d9f57d21417b53ef91e922a63204d950010d0251
Author: jiahuiguo <jiahuiguo@google.com>
Date: Mon Jan 09 22:46:55 2017

Replace hard-coded colors from ui::NativeTheme for consistency
and accessibility, and refactor to let views, not controllers
in control of presentation details, while the controller returns
a color id instead of a color.

BUG= 666523 
TEST=Smoke Test

Review-Url: https://codereview.chromium.org/2581513002
Cr-Commit-Position: refs/heads/master@{#442384}

[modify] https://crrev.com/d9f57d21417b53ef91e922a63204d950010d0251/chrome/browser/ui/autofill/autofill_popup_controller.h
[modify] https://crrev.com/d9f57d21417b53ef91e922a63204d950010d0251/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
[modify] https://crrev.com/d9f57d21417b53ef91e922a63204d950010d0251/chrome/browser/ui/autofill/autofill_popup_controller_impl.h
[modify] https://crrev.com/d9f57d21417b53ef91e922a63204d950010d0251/chrome/browser/ui/autofill/autofill_popup_layout_model.cc
[modify] https://crrev.com/d9f57d21417b53ef91e922a63204d950010d0251/chrome/browser/ui/autofill/autofill_popup_layout_model.h
[modify] https://crrev.com/d9f57d21417b53ef91e922a63204d950010d0251/chrome/browser/ui/autofill/popup_constants.h
[modify] https://crrev.com/d9f57d21417b53ef91e922a63204d950010d0251/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm
[modify] https://crrev.com/d9f57d21417b53ef91e922a63204d950010d0251/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc
[modify] https://crrev.com/d9f57d21417b53ef91e922a63204d950010d0251/chrome/browser/ui/views/autofill/autofill_popup_view_views.cc
[modify] https://crrev.com/d9f57d21417b53ef91e922a63204d950010d0251/chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc

Status: Fixed (was: Started)
Owner: jiahuiguo@chromium.org

Sign in to add a comment