Colors in chrome/browser/ui/autofill/popup_constants.h ought to be replaced by getting colors from ui::NativeTheme for consistency and accessibility.
Hi Sashi, this could be an interesting starter bug for someone on your team. Assigning to you tentatively.
Sounds good. Jason - do you want to take a look? Thanks.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9f57d21417b53ef91e922a63204d950010d0251 commit d9f57d21417b53ef91e922a63204d950010d0251 Author: jiahuiguo <jiahuiguo@google.com> Date: Mon Jan 09 22:46:55 2017 Replace hard-coded colors from ui::NativeTheme for consistency and accessibility, and refactor to let views, not controllers in control of presentation details, while the controller returns a color id instead of a color. BUG= 666523 TEST=Smoke Test Review-Url: https://codereview.chromium.org/2581513002 Cr-Commit-Position: refs/heads/master@{#442384} [modify] https://crrev.com/d9f57d21417b53ef91e922a63204d950010d0251/chrome/browser/ui/autofill/autofill_popup_controller.h [modify] https://crrev.com/d9f57d21417b53ef91e922a63204d950010d0251/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc [modify] https://crrev.com/d9f57d21417b53ef91e922a63204d950010d0251/chrome/browser/ui/autofill/autofill_popup_controller_impl.h [modify] https://crrev.com/d9f57d21417b53ef91e922a63204d950010d0251/chrome/browser/ui/autofill/autofill_popup_layout_model.cc [modify] https://crrev.com/d9f57d21417b53ef91e922a63204d950010d0251/chrome/browser/ui/autofill/autofill_popup_layout_model.h [modify] https://crrev.com/d9f57d21417b53ef91e922a63204d950010d0251/chrome/browser/ui/autofill/popup_constants.h [modify] https://crrev.com/d9f57d21417b53ef91e922a63204d950010d0251/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm [modify] https://crrev.com/d9f57d21417b53ef91e922a63204d950010d0251/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc [modify] https://crrev.com/d9f57d21417b53ef91e922a63204d950010d0251/chrome/browser/ui/views/autofill/autofill_popup_view_views.cc [modify] https://crrev.com/d9f57d21417b53ef91e922a63204d950010d0251/chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc
Comment 1 by lshang@chromium.org
, Dec 5 2016Status: Available (was: Assigned)