New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666518 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Undefined-shift in webrtc::ComfortNoiseDecoder::Generate

Project Member Reported by ClusterFuzz, Nov 17 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4978839756472320

Fuzzer: libfuzzer_neteq_rtp_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Undefined-shift
Crash Address: 
Crash State:
  webrtc::ComfortNoiseDecoder::Generate
  webrtc::ComfortNoise::Generate
  webrtc::NetEqImpl::DoRfc3389Cng
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=424632:424679

Minimized Testcase (0.02 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96S43WzLTZA5Oknpb6GDYctjDPB9L788wMrYbVayphbTjvfbV0n_MUczsUjvuJ09ACXfJrgjyDD3najrVU-OymHgwcTcIEGtAqPuUlZxjS-cKjECmyD1oYH1f0_X2kWrCRwFlBm7EP6b3zZ3e93dK4GU2S1yw?testcase_id=4978839756472320

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 

Comment 1 by ananthak@google.com, Nov 18 2016

Components: Blink>WebRTC
Cc: tina.legrand@webrtc.org nyerramilli@chromium.org turaj@webrtc.org
Labels: -Type-Bug M-56 Test-Predator-Wrong-CLs Type-Bug-Regression
requesting WebRTC team to check the issue and help.

Comment 3 by guidou@chromium.org, Nov 18 2016

Components: -Blink>WebRTC Blink>WebRTC>Audio
Cc: -tina.legrand@webrtc.org -turaj@webrtc.org hlundin@chromium.org tlegrand@chromium.org
Status: Available (was: Untriaged)

Comment 5 by ossu@chromium.org, Nov 21 2016

Owner: ossu@chromium.org
Taking a quick look at this. The undefined behavior caught by this fuzzer can be "fixed" by replacing the << 2 with * 4, however I'm not sure this is completely correct. The test case is a "left shift of negative value -32363", which clearly won't fit in the 16 bit signed integer it's in, regardless if we use shifting or multiplication. I'll keep investigating.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/0eb19602a3a7bab20f31efe93f9de205106f5b48

commit 0eb19602a3a7bab20f31efe93f9de205106f5b48
Author: ossu <ossu@webrtc.org>
Date: Tue Nov 22 13:15:21 2016

ComfortNoise: Calculate used scale factor in Q13

BUG= chromium:666518 

Review-Url: https://codereview.webrtc.org/2519873003
Cr-Commit-Position: refs/heads/master@{#15189}

[modify] https://crrev.com/0eb19602a3a7bab20f31efe93f9de205106f5b48/webrtc/modules/audio_coding/codecs/cng/webrtc_cng.cc

Project Member

Comment 7 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by ClusterFuzz, Nov 23 2016

ClusterFuzz has detected this issue as fixed in range 433878:433990.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4978839756472320

Fuzzer: libfuzzer_neteq_rtp_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Undefined-shift
Crash Address: 
Crash State:
  webrtc::ComfortNoiseDecoder::Generate
  webrtc::ComfortNoise::Generate
  webrtc::NetEqImpl::DoRfc3389Cng
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=424632:424679
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=433878:433990

Minimized Testcase (0.02 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96S43WzLTZA5Oknpb6GDYctjDPB9L788wMrYbVayphbTjvfbV0n_MUczsUjvuJ09ACXfJrgjyDD3najrVU-OymHgwcTcIEGtAqPuUlZxjS-cKjECmyD1oYH1f0_X2kWrCRwFlBm7EP6b3zZ3e93dK4GU2S1yw?testcase_id=4978839756472320

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Nov 23 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Available)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 10 by ClusterFuzz, Nov 23 2016

ClusterFuzz has detected this issue as fixed in range 433878:433990.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4978839756472320

Fuzzer: libfuzzer_neteq_rtp_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Undefined-shift
Crash Address: 
Crash State:
  webrtc::ComfortNoiseDecoder::Generate
  webrtc::ComfortNoise::Generate
  webrtc::NetEqImpl::DoRfc3389Cng
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=424632:424679
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=433878:433990

Minimized Testcase (0.02 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96S43WzLTZA5Oknpb6GDYctjDPB9L788wMrYbVayphbTjvfbV0n_MUczsUjvuJ09ACXfJrgjyDD3najrVU-OymHgwcTcIEGtAqPuUlZxjS-cKjECmyD1oYH1f0_X2kWrCRwFlBm7EP6b3zZ3e93dK4GU2S1yw?testcase_id=4978839756472320

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Sign in to add a comment