New issue
Advanced search Search tips

Issue 666516 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-buffer-overflow in unibrow::Utf8::CalculateValue

Project Member Reported by ClusterFuzz, Nov 17 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4684034207907840

Fuzzer: libfuzzer_v8_serialized_script_value_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 1
Crash Address: 0x61d00000c7e6
Crash State:
  unibrow::Utf8::CalculateValue
  unibrow::Utf8DecoderBase::Reset
  v8::internal::Factory::NewStringFromUtf8
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=432836:432874

Minimized Testcase (2.34 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95ZBBqyMYwsW1gAPCOSf24iufpH0DnLVx1VjUTeM00hx1vacBrJnz9fCfSmaC84tyoc_JayLqzsVpcCP6isyIhVwNQUtpt1Ype4Z_L_XhR1jfE80QdNFb58phc26ngBsY5FcCTvO3JnkvCbGhUcKav2D-UOYQ?testcase_id=4684034207907840

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Nov 18 2016

Labels: M-56
Project Member

Comment 2 by sheriffbot@chromium.org, Nov 18 2016

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Nov 18 2016

Labels: Pri-1
Owner: jochen@chromium.org
Status: Assigned (was: Untriaged)
jochen@, can you take a look at this or assign it to someone who can? Thanks.
Components: Blink>JavaScript
Project Member

Comment 6 by ClusterFuzz, Nov 19 2016

ClusterFuzz has detected this issue as fixed in range 433084:433312.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4684034207907840

Fuzzer: libfuzzer_v8_serialized_script_value_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 1
Crash Address: 0x61d00000c7e6
Crash State:
  unibrow::Utf8::CalculateValue
  unibrow::Utf8DecoderBase::Reset
  v8::internal::Factory::NewStringFromUtf8
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=432836:432874
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=433084:433312

Minimized Testcase (2.34 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95ZBBqyMYwsW1gAPCOSf24iufpH0DnLVx1VjUTeM00hx1vacBrJnz9fCfSmaC84tyoc_JayLqzsVpcCP6isyIhVwNQUtpt1Ype4Z_L_XhR1jfE80QdNFb58phc26ngBsY5FcCTvO3JnkvCbGhUcKav2D-UOYQ?testcase_id=4684034207907840

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Nov 19 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 8 by sheriffbot@chromium.org, Nov 19 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 9 by ClusterFuzz, Dec 16 2016

ClusterFuzz has detected this issue as fixed in range 433834:433855.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4684034207907840

Fuzzer: libfuzzer_v8_serialized_script_value_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 1
Crash Address: 0x61d00000c7e6
Crash State:
  unibrow::Utf8::CalculateValue
  unibrow::Utf8DecoderBase::Reset
  v8::internal::Factory::NewStringFromUtf8
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=432836:432874
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=433834:433855

Minimized Testcase (2.34 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95ZBBqyMYwsW1gAPCOSf24iufpH0DnLVx1VjUTeM00hx1vacBrJnz9fCfSmaC84tyoc_JayLqzsVpcCP6isyIhVwNQUtpt1Ype4Z_L_XhR1jfE80QdNFb58phc26ngBsY5FcCTvO3JnkvCbGhUcKav2D-UOYQ?testcase_id=4684034207907840

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Labels: Merge-Request-56
The fixed range includes the following v8 roll:

https://chromium.googlesource.com/v8/v8/+log/228237cf..d7fb769f

anything in there look like it might be what should/could be merged to M56 to fix this security issue?
Project Member

Comment 11 by sheriffbot@chromium.org, Dec 16 2016

Labels: -Merge-Request-56 Merge-Review-56 Hotlist-Merge-Review
This bug requires manual review: No test file found in commits.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 12 by dimu@google.com, Dec 16 2016

Labels: -Merge-Review-56 -Hotlist-Merge-Review
[Automated comment] removing mislabelled Merge-Review-56, Hotlist-Merge-Review
Labels: -ReleaseBlock-Beta -M-56 M-57
Project Member

Comment 14 by sheriffbot@chromium.org, Feb 25 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment