New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666515 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Remove the timeout from the test script command line

Project Member Reported by petewil@chromium.org, Nov 17 2016

Issue description

We determined that the timeout in the background offlining test script command line is probably both unnecessary and causes problems.  Let's remove the argument and rely on the defaults in OfflinerPolicy
 

Comment 1 by romax@chromium.org, Nov 19 2016

Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2656bba9e0f0cff3f12d0aa008ba91797ae53b9c

commit 2656bba9e0f0cff3f12d0aa008ba91797ae53b9c
Author: romax <romax@chromium.org>
Date: Sat Nov 19 01:04:23 2016

[Offline Pages] Remove timeout in test harness.

Removes the timeout related code since there isn't a use case which would
terminate test harness before it finishes offlining all the urls.

BUG= 666515 

Review-Url: https://codereview.chromium.org/2518733002
Cr-Commit-Position: refs/heads/master@{#433362}

[modify] https://crrev.com/2656bba9e0f0cff3f12d0aa008ba91797ae53b9c/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java
[modify] https://crrev.com/2656bba9e0f0cff3f12d0aa008ba91797ae53b9c/chrome/browser/android/offline_pages/evaluation/run_offline_page_evaluation_test.py

Comment 3 by romax@chromium.org, Nov 19 2016

Status: Fixed (was: Started)

Sign in to add a comment