New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666502 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
User never visited
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[Cronet] Use XCode Clang when building release version of Cronet for iOS

Project Member Reported by mef@chromium.org, Nov 17 2016

Issue description

The binary size of fat Cronet.framework is reduced if gn argument use_xcode_clang is true.

Built using Chromium clang:
6415456 Nov 17 14:13 Cronet

Built using XCode clang:
6381632 Nov 17 16:27 Cronet

The difference is just 33k, but looks like an easy save.


 

Comment 1 by jif@chromium.org, Nov 18 2016

Owner: sdefresne@chromium.org
Status: Assigned (was: Untriaged)
Owner: mef@chromium.org

Comment 3 by mef@chromium.org, Jan 9 2017

Status: Started (was: Assigned)
Recent build with CookieStoreIOS shows even bigger difference (about 80k):

Built using Chromium clang:
6747488 Jan  6 17:15 Cronet

Built using XCode clang:
6664000 Jan  9 10:45 Cronet
Project Member

Comment 4 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/970e26717675d235f8dc59c1646e4abf9e3a7784

commit 970e26717675d235f8dc59c1646e4abf9e3a7784
Author: mef <mef@chromium.org>
Date: Thu May 11 21:27:01 2017

[Cronet] Use xcode clang on iOS to reduce release binary size.

BUG= 666502 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2614423002
Cr-Commit-Position: refs/heads/master@{#471077}

[modify] https://crrev.com/970e26717675d235f8dc59c1646e4abf9e3a7784/components/cronet/tools/cr_cronet.py
[modify] https://crrev.com/970e26717675d235f8dc59c1646e4abf9e3a7784/components/cronet/tools/package_ios.py

Comment 5 by mef@chromium.org, May 11 2017

Cc: mef@chromium.org rsleevi@chromium.org
Owner: smut@chromium.org
Per conversation with Sleevi all official bots should use is_official_build=true, however this flag is not available for debug builds, so use_xcode_clang=true looks like a next good option.

Sana, could you help us to update Cronet bots?
Project Member

Comment 6 by bugdroid1@chromium.org, May 12 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/f21a682c327d6411e3df2c35e331c263b841f272

commit f21a682c327d6411e3df2c35e331c263b841f272
Author: smut <smut@google.com>
Date: Fri May 12 22:04:29 2017

Comment 7 by s...@google.com, May 12 2017

Status: Fixed (was: Started)

Sign in to add a comment