New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666472 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

"timeline" sometimes shows as custom column.

Project Member Reported by allada@chromium.org, Nov 17 2016

Issue description

Sometimes there's a custom column called "timeline" in network panel.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff55f920752fe080a09137e51dd1f14d0a5018a3

commit ff55f920752fe080a09137e51dd1f14d0a5018a3
Author: allada <allada@chromium.org>
Date: Fri Nov 18 04:13:51 2016

[Devtools] Removed timeline setting from network log settings

This patch ensures there are no lingering "timeline" setting for network
log settings. "timeline" or "waterfall" may have been saved into the
users settings and when the new waterfall came out it may have caused
some users to see "timeline" as a custom column; this removes that.

R=dgozman,lushnikov
BUG= 666472 

Review-Url: https://codereview.chromium.org/2513733002
Cr-Commit-Position: refs/heads/master@{#433091}

[modify] https://crrev.com/ff55f920752fe080a09137e51dd1f14d0a5018a3/third_party/WebKit/Source/devtools/front_end/common/Settings.js

Status: Fixed (was: Assigned)
Labels: Merge-Request-55
Status: Started (was: Fixed)

Comment 4 by dimu@chromium.org, Dec 7 2016

Labels: -Merge-Request-55 Merge-Review-55 Hotlist-Merge-Review
[Automated comment] Request affecting a post-stable build (M55), manual review required.
Cc: allada@chromium.org
 Issue 672096  has been merged into this issue.
Is this change applicable to all OSs or any specific os?
Labels: -Merge-Review-55 Merge-Review-56
Sorry, I didn't realize we where rolling out. Requesting 56 instead.
Labels: -Merge-Review-56 Merge-Request-56
Labels: -Merge-Request-56 Merge-Approved-56 OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Approved for M56 branch 2924.  Marking as OS-All given that DevTools are applicable cross-platform, but correct me if this wouldn't show up on certain platforms e.g. Android.
Components: Platform>DevTools>Network
Labels: -Hotlist-Merge-Review -Merge-Approved-56
Status: Fixed (was: Started)
Looks like the promotion of the dev channel took the change into beta, so no need for a merge any more.

Thanks!

Comment 11 by pdk...@gmail.com, Dec 15 2016

Nope, it didn't make it into M56 (Beta).
Labels: ReleaseBlock-Stable M-56 Merge-Request-56
Project Member

Comment 13 by sheriffbot@chromium.org, Jan 5 2017

Labels: -Merge-Request-56 Hotlist-Merge-Approved Merge-Approved-56
Your change meets the bar and is auto-approved for M56. Please go ahead and merge the CL manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 5 2017

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6907442116a1174239f500b519de42bd59a8658b

commit 6907442116a1174239f500b519de42bd59a8658b
Author: allada <allada@chromium.org>
Date: Thu Jan 05 03:07:02 2017

[Devtools] Removed timeline setting from network log settings

This patch ensures there are no lingering "timeline" setting for network
log settings. "timeline" or "waterfall" may have been saved into the
users settings and when the new waterfall came out it may have caused
some users to see "timeline" as a custom column; this removes that.

R=dgozman
BUG= 666472 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2513733002
Cr-Commit-Position: refs/heads/master@{#433091}
(cherry picked from commit ff55f920752fe080a09137e51dd1f14d0a5018a3)

Review-Url: https://codereview.chromium.org/2617633003
Cr-Commit-Position: refs/branch-heads/2924@{#677}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/6907442116a1174239f500b519de42bd59a8658b/third_party/WebKit/Source/devtools/front_end/common/Settings.js

Sign in to add a comment