New issue
Advanced search Search tips

Issue 666471 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 666396



Sign in to add a comment

PannerOptions refDistance and friends incorrectly declared floats

Project Member Reported by rtoy@chromium.org, Nov 17 2016

Issue description

The current PannerOptions.idl file declares the following to be floats instead of doubles:  refDistance, maxDistance, rolloffFactor, coneInnerAngle, coneOuterAngle, and coneOuterGain.

The spec clearly says they are doubles and the corresponding attributes are actually doubles.

 

Comment 1 by rtoy@chromium.org, Nov 17 2016

Blocking: 666396
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4eae706d4f07f9d297ce0f8d8cbc2bf07618598

commit a4eae706d4f07f9d297ce0f8d8cbc2bf07618598
Author: rtoy <rtoy@chromium.org>
Date: Fri Nov 18 16:40:37 2016

Some PannerOptions dictionary members should be doubles

Some of the dictionary members were incorrectly declared to be floats
when they should have been doubles.  The corresponding attributes
themselves are doubles so the members should match.

See https://webaudio.github.io/web-audio-api/#panneroptions

BUG= 666471 
TEST=constructor/panner.html updated

Review-Url: https://codereview.chromium.org/2508733006
Cr-Commit-Position: refs/heads/master@{#433217}

[modify] https://crrev.com/a4eae706d4f07f9d297ce0f8d8cbc2bf07618598/third_party/WebKit/LayoutTests/webaudio/constructor/panner.html
[modify] https://crrev.com/a4eae706d4f07f9d297ce0f8d8cbc2bf07618598/third_party/WebKit/Source/modules/webaudio/PannerOptions.idl

Comment 3 by rtoy@chromium.org, Nov 18 2016

Labels: Merge-Request-56
Requesting merge to M56.

This is a minor correction to the IDL that allows passing in doubles instead of floats for the PannerNode constructor. (Constructors were added in M55, so relatively new.)

Comment 4 by dimu@chromium.org, Nov 19 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 28 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6490317e95b58a3068a7c123904afaf4eb7a5467

commit 6490317e95b58a3068a7c123904afaf4eb7a5467
Author: Raymond Toy <rtoy@chromium.org>
Date: Mon Nov 28 19:28:53 2016

Some PannerOptions dictionary members should be doubles

Some of the dictionary members were incorrectly declared to be floats
when they should have been doubles.  The corresponding attributes
themselves are doubles so the members should match.

See https://webaudio.github.io/web-audio-api/#panneroptions

BUG= 666471 
TEST=constructor/panner.html updated

Review-Url: https://codereview.chromium.org/2508733006
Cr-Commit-Position: refs/heads/master@{#433217}
(cherry picked from commit a4eae706d4f07f9d297ce0f8d8cbc2bf07618598)

Review URL: https://codereview.chromium.org/2536603003 .

Cr-Commit-Position: refs/branch-heads/2924@{#120}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/6490317e95b58a3068a7c123904afaf4eb7a5467/third_party/WebKit/LayoutTests/webaudio/constructor/panner.html
[modify] https://crrev.com/6490317e95b58a3068a7c123904afaf4eb7a5467/third_party/WebKit/Source/modules/webaudio/PannerOptions.idl

Comment 6 by rtoy@chromium.org, Dec 1 2016

Status: Fixed (was: Started)

Sign in to add a comment