MD OOBE: Learn more link is not translated |
||||||||||||||||||||
Issue descriptionGo through new MD OOBE. Change language to Arabic Click the translated "Learn more" link on the Terms and conditions page Expected: Translated page in modal dialog Actual: English page in modal dialog
,
Nov 29 2016
This is something strange. The string in resources has ID IDS_LEARN_MORE, but it is not translated.
,
Feb 4 2017
Issue 688710 has been merged into this issue.
,
Feb 13 2017
Actually, I'm playing with OOBE and changing language selection now and it looks like most strings are staying in English. I'm looking at Canary, but I was under the impression that most of these strings have been in long enough that we should have translations for them. Did we ever figure out what's up? Marking this as a blocker for new OOBE launch.
,
Feb 13 2017
https://cs.chromium.org/search/?q=6165508094623778733&p=6&sq=package:chromium&type=cs It looks like we have the translated "learn more" in *.xtb files. So maybe need someone to look at why the result is not displayed.
,
Feb 14 2017
Issue 691904 might be the root problem.
,
Feb 14 2017
alemate@ yep. I just figured that out. When I changed the language I was expecting it to switch immediately. I'll comment more in the other bug. Thanks.
,
Mar 15 2017
abodenha@ - Tai here from l10n. Please keep us posted if addt'l support is needed from our end. We're able to provide translations on strings that are in TC if needed, but will need the TC Message ID or EN source strings. Thx!
,
Mar 15 2017
This has been fixed. The root cause was (partially) broken i18n macro that was used to insert string values to the UI.
,
Mar 15 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-58; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-58 label, otherwise remove Merge-TBD label. Thanks.
,
Mar 24 2017
I just tested on 58.0.3029.36 / 9334.20.0 (Official Build) dev-channel reef and still see this issue. Was there a merge missed? Or does dev channel not contain translations or smth ?
,
Mar 29 2017
I cannot reproduce this. This is a picture with 58.0.3029.36 : https://drive.google.com/a/google.com/file/d/0B78LGDAASRQ4ZDFDelNjYWhlVDA/view?usp=sharing I see the link is translated.
,
Apr 3 2017
It's been a while but I think this bug was about the modal that appears when you click the link. Which is still in English on latest M58 despite the rest of the UI being in arabic
,
Apr 3 2017
,
Apr 4 2017
Ah, OK, now I understand. Initially the issue was about "Leann more..." text translation, which turned to be an issue with $i18n macro that was used there. But screenshot is now about the Help App, which is a separate application. +morsed David, are you the right person to look into this?
,
Apr 4 2017
,
Apr 4 2017
+alemate: Yes, I am the person currently working with the HelpApp, with weifangsun@ overseeing the project. And the HelpApp is responsible for the Diagnostics and Usage Data panel in the OOBE, setting the translations which are baked into the OS (the text content is managed within gKMS/Redwood). Note that historically the HelpApp never supported Arabic as a locale. The list of supported languages were as follows: 'de', 'en', 'en_GB', 'es', 'es_419', 'fi', 'fil', 'fr', 'hi', 'it', 'ja', 'ms', 'nl', 'pt_BR', 'ru', 'sv', 'ta', 'zh_CN', 'zh_TW' But, as of M59 (9409.0.0/59.0.3054.0), the HelpApp will support the same full list of 53 languages supported by ChromeOS itself. When M59 moves to an official Dev build, I will re-test the OOBE and confirm.
,
Apr 6 2017
Scratch that. It's been determined that the increase in language support was too large for ChromeOS image (16+mb) and the change is being rolled back. See http://crbug.com/708334 . It is unknown if and when Arabic and other languages will be added into the HelpApp or the Get Help app. Determinations regarding language expansion(s) will be made at some unknown point in the future.
,
Apr 12 2017
It sounds like this is not going to make it into 58, should we remove the release block stable?
,
Apr 12 2017
@bhthompson: Yes. Adding Arabic and other locales to the HelpApp will not make M58 (or even M59). Feel free to update labels accordingly. It is unknown when HelpApp languages will be increased so that the "Diagnostics and Usage Data" panel matches all languages otherwise currently available in ChromeOS.
,
Apr 24 2017
,
Apr 25 2017
,
Apr 25 2017
,
May 22 2017
,
May 22 2017
,
May 22 2017
,
Jun 27 2017
Hi Everyone, Geoff here from localization. I checked Redwood and it looks like the translations are completed for the text indicated in comment 18. Please let us know if there's anything else we could do to help. https://screenshot.googleplex.com/jZCx03GBbe0
,
Sep 6 2017
Hi, We think this issue has been completed already. Tagging the case fixed. Feel free to update us is there's anything we can assist you all. Regards!
,
Jan 22 2018
,
Jan 23 2018
|
||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||
Comment 1 by omrilio@chromium.org
, Nov 22 2016