laptop-mode: WiFi power save settings not applied at boot |
|||
Issue description
WiFi power save settings are not always applied at boot time.
When this occurs the kernel initialization of the WiFi interface has not been completed when "laptop-mode force" runs at boot. That this issue is seen now is probably a side effect of CL 4683f33 ("laptop-mode-tools: Refactor usb_autosuspend::listed_by_id") which reduces the runtime of "laptop-mode force" significantly.
This can be fixed by extending the laptop-mode udev rules to invoke LMT upon changes in the state of a network interface.
,
Nov 17 2016
re #1: Yeah, laptop-mode-tools is quite a beast ... There hasn't been much activity on issue 214886 , has there been any development in that area since 2012?
,
Nov 17 2016
Not sure. I am very much in favor of removing dependence on LMT and writing our own much slimmer replacement for it. Matthias, want to take this on?
,
Nov 17 2016
(Let's take rewriting discussion to issue 214886 .) :-)
,
Nov 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0645aeeb86eca5fa29d55ae6317ec6d13a0df01c commit 0645aeeb86eca5fa29d55ae6317ec6d13a0df01c Author: Matthias Kaehlcke <mka@chromium.org> Date: Thu Nov 17 20:40:11 2016 Add udev rule for WiFi devices WiFi power save settings are not always applied at boot time. When this occurs the kernel initialization of the WiFi interface has no been completed when "laptop-mode force" runs at boot. That this issue is seen now is probably a side effect of CL 4683f33 ("laptop-mode-tools: Refactor usb_autosuspend::listed_by_id") which reduces the runtime of "laptop-mode force" significantly. Add a udev rule for WiFi/net devices to make sure laptop-mode can apply the configured power save settings. BUG= chromium:666459 TEST=USE=-wifi_force_powersave emerge-kevin laptop-mode-tools cros deploy ${KEVIN_IP} laptop-mode-tools # repeat 10x boot kevin with power supply attached iw dev mlan0 get power_save => Power save: off Change-Id: I5ef813b28eb1b658745e88614048bdd99524dcff Reviewed-on: https://chromium-review.googlesource.com/412442 Commit-Ready: Matthias Kaehlcke <mka@chromium.org> Tested-by: Matthias Kaehlcke <mka@chromium.org> Reviewed-by: Todd Broch <tbroch@chromium.org> [add] https://crrev.com/0645aeeb86eca5fa29d55ae6317ec6d13a0df01c/app-laptop/laptop-mode-tools/files/0033-Add-udev-rule-for-WiFi-devices.patch [rename] https://crrev.com/0645aeeb86eca5fa29d55ae6317ec6d13a0df01c/app-laptop/laptop-mode-tools/laptop-mode-tools-1.59-r38.ebuild [modify] https://crrev.com/0645aeeb86eca5fa29d55ae6317ec6d13a0df01c/app-laptop/laptop-mode-tools/laptop-mode-tools-1.59.ebuild
,
Nov 18 2016
,
Jan 13 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by derat@chromium.org
, Nov 17 2016