stylus tool still shows up in the shelf after disabled |
||||||
Issue descriptionSee this on ToT: 56.0.2924.0 Steps to reproduce: 1. Uncheck "Show stylus tools in the shelf" in the stylus settings 2. Notice stylus tool is hidden in the shelf 3. Go to Lock screen(search+l) 4. Unlock screen and see the stylus tools again in the shelf. Note this only happened in lock screen but not sign-in screen.
,
Nov 28 2016
,
Nov 28 2016
,
Nov 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04d83e71145866d8d7cea925f4ff2c57c0c9bd03 commit 04d83e71145866d8d7cea925f4ff2c57c0c9bd03 Author: jdufault <jdufault@chromium.org> Date: Mon Nov 28 21:05:02 2016 Make sure stylus tools are always hidden if disabled by the user. BUG= 666450 Review-Url: https://codereview.chromium.org/2535773004 Cr-Commit-Position: refs/heads/master@{#434717} [modify] https://crrev.com/04d83e71145866d8d7cea925f4ff2c57c0c9bd03/ash/common/system/chromeos/palette/palette_tray.cc [modify] https://crrev.com/04d83e71145866d8d7cea925f4ff2c57c0c9bd03/ash/common/system/chromeos/palette/palette_tray.h
,
Nov 29 2016
,
Nov 29 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7596b2711a8b021e71ba86b27e486aaac935617 commit d7596b2711a8b021e71ba86b27e486aaac935617 Author: Jacob Dufault <jdufault@google.com> Date: Thu Dec 01 16:38:18 2016 Make sure stylus tools are always hidden if disabled by the user. BUG= 666450 Review-Url: https://codereview.chromium.org/2535773004 Cr-Commit-Position: refs/heads/master@{#434717} (cherry picked from commit 04d83e71145866d8d7cea925f4ff2c57c0c9bd03) Review URL: https://codereview.chromium.org/2532083008 . Cr-Commit-Position: refs/branch-heads/2924@{#248} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/d7596b2711a8b021e71ba86b27e486aaac935617/ash/common/system/chromeos/palette/palette_tray.cc [modify] https://crrev.com/d7596b2711a8b021e71ba86b27e486aaac935617/ash/common/system/chromeos/palette/palette_tray.h
,
Dec 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7596b2711a8b021e71ba86b27e486aaac935617 commit d7596b2711a8b021e71ba86b27e486aaac935617 Author: Jacob Dufault <jdufault@google.com> Date: Thu Dec 01 16:38:18 2016 Make sure stylus tools are always hidden if disabled by the user. BUG= 666450 Review-Url: https://codereview.chromium.org/2535773004 Cr-Commit-Position: refs/heads/master@{#434717} (cherry picked from commit 04d83e71145866d8d7cea925f4ff2c57c0c9bd03) Review URL: https://codereview.chromium.org/2532083008 . Cr-Commit-Position: refs/branch-heads/2924@{#248} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/d7596b2711a8b021e71ba86b27e486aaac935617/ash/common/system/chromeos/palette/palette_tray.cc [modify] https://crrev.com/d7596b2711a8b021e71ba86b27e486aaac935617/ash/common/system/chromeos/palette/palette_tray.h
,
Dec 1 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jdufault@chromium.org
, Nov 17 2016Status: Assigned (was: Untriaged)