New issue
Advanced search Search tips

Issue 666448 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Linux_ChromiumOS_Full snapshot builds are missing icudtl.dat

Project Member Reported by thestig@chromium.org, Nov 17 2016

Issue description

What steps will reproduce the problem?
(1) Download chrome-linux.zip from https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Linux_ChromiumOS_Full/432914/
(2) Unzip it
(3) Run the "chrome" binary instead

What is the expected result?

A Chromium window of some kind launches

What happens instead?

Chromium crashes with:

[1117/120744:FATAL:content_main_runner.cc(680)] Check failed: base::i18n::InitializeICU(). 

because the zip file is missing icudtl.dat.
 
Cc: abodenha@chromium.org mmoss@chromium.org
Owner: thestig@chromium.org
Status: Assigned (was: Untriaged)
I believe this is due to a missing entry in chrome/tools/build/chromeos/FILES.cfg. I hope this is an easy fix. With this, new archived builds will work out of the box and "tools/bisect-builds.py -a chromeos" can actually work.
Cc: js...@chromium.org dmazz...@chromium.org
We even tried a hack to try to work around this bug. I'm not sure why the hack failed for me at an older build at r400000, but works in my tree with newer builds at r43xxxx. Maybe the current icudtl.dat doesn't work with older builds? *shrug*

The hack may need to stay because all the old archived builds are missing the .dat file. Or we may determine the hack doesn't quite work right 100% of the time, and we should just throw it away. If anyone is interested, feel free to file a new bug to examine if the hack is worth keeping.
I ran some builds by hand and I believe an icudtl.dat mismatch indeed can cause chrome builds to crash, so the hack is probably not worth keeping unless we fix it to copy idudtl.dat from the right revision.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3dd2c2a6e2f6d21c084f72108b9e4db9a26e3dda

commit 3dd2c2a6e2f6d21c084f72108b9e4db9a26e3dda
Author: thestig <thestig@chromium.org>
Date: Thu Nov 17 22:31:27 2016

Archive icudtl.dat in ChromeOS continuous builds.

Also remove obsolete file entires and sort the list a bit more.

BUG= 666448 

Review-Url: https://codereview.chromium.org/2512763002
Cr-Commit-Position: refs/heads/master@{#432997}

[modify] https://crrev.com/3dd2c2a6e2f6d21c084f72108b9e4db9a26e3dda/chrome/tools/build/chromeos/FILES.cfg
[modify] https://crrev.com/3dd2c2a6e2f6d21c084f72108b9e4db9a26e3dda/chrome/tools/build/linux/FILES.cfg

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3dd2c2a6e2f6d21c084f72108b9e4db9a26e3dda

commit 3dd2c2a6e2f6d21c084f72108b9e4db9a26e3dda
Author: thestig <thestig@chromium.org>
Date: Thu Nov 17 22:31:27 2016

Archive icudtl.dat in ChromeOS continuous builds.

Also remove obsolete file entires and sort the list a bit more.

BUG= 666448 

Review-Url: https://codereview.chromium.org/2512763002
Cr-Commit-Position: refs/heads/master@{#432997}

[modify] https://crrev.com/3dd2c2a6e2f6d21c084f72108b9e4db9a26e3dda/chrome/tools/build/chromeos/FILES.cfg
[modify] https://crrev.com/3dd2c2a6e2f6d21c084f72108b9e4db9a26e3dda/chrome/tools/build/linux/FILES.cfg

Status: Fixed (was: Assigned)
Filed  bug 666508  as a follow up. I think new builds in the archive will have the missing .dat file starting now without further actions?

Comment 7 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 8 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 9 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 11 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment