New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666447 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 664494



Sign in to add a comment

Bisect - Gathering Reference Values step fails to produce any values but is green.

Project Member Reported by simonhatch@chromium.org, Nov 17 2016

Issue description

Owner: simonhatch@chromium.org
Seems like an easy way to surface this would be in local_bisect.py:_gather_reference_range where it explicitly checks the results of the good and bad revision

An extra check to see if they they managed to produce any values and generating an error or at least a warning might be the way to go.

wdyt roberto?
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/863eb9dd1b2311df03793e115679184d6db0daf7

commit 863eb9dd1b2311df03793e115679184d6db0daf7
Author: Simon <simonhatch@chromium.org>
Date: Wed Nov 23 17:00:52 2016

[bisect] - Fail if no values from "Gathering Reference Values".

Previously when this failed, the bisect would just continue on to
"Compare Samples" which would also fail. Instead this CL forces
the "Gathering Reference Values" step to fail out and make it
obvious where things went wrong.


BUG= 666447 

Change-Id: Iac8bac09483be13aafad6696ebcac1fbf36bfbb6
Reviewed-on: https://chromium-review.googlesource.com/412922
Commit-Queue: Simon Hatch <simonhatch@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/863eb9dd1b2311df03793e115679184d6db0daf7/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/failed_buildbucket_get.json
[add] https://crrev.com/863eb9dd1b2311df03793e115679184d6db0daf7/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/gathering_references_no_values.json
[modify] https://crrev.com/863eb9dd1b2311df03793e115679184d6db0daf7/scripts/slave/recipe_modules/auto_bisect_staging/example.py
[modify] https://crrev.com/863eb9dd1b2311df03793e115679184d6db0daf7/scripts/slave/recipe_modules/auto_bisect_staging/revision_state.py

Blocking: 664494
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/75646a7cf53bbf029ffc22356430e8edb4784150

commit 75646a7cf53bbf029ffc22356430e8edb4784150
Author: Simon <simonhatch@chromium.org>
Date: Thu Dec 01 22:13:16 2016

Bisect - Check for buildbot output tests.

Previously we always passed stdout_paths, but nothing used it. Now we
check the command against a list of known gtests and only pass the
buildbot output in those cases.

BUG= 666447 

Change-Id: I339d485c9c3215920ce579a2d9ba018a90f2078d
Reviewed-on: https://chromium-review.googlesource.com/415527
Commit-Queue: Simon Hatch <simonhatch@chromium.org>
Reviewed-by: Prasad Vuppalapu <prasadv@chromium.org>

[modify] https://crrev.com/75646a7cf53bbf029ffc22356430e8edb4784150/scripts/slave/recipe_modules/auto_bisect_staging/bisector.py
[add] https://crrev.com/75646a7cf53bbf029ffc22356430e8edb4784150/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_buildbot_bisect.json
[modify] https://crrev.com/75646a7cf53bbf029ffc22356430e8edb4784150/scripts/slave/recipe_modules/auto_bisect_staging/example.py
[modify] https://crrev.com/75646a7cf53bbf029ffc22356430e8edb4784150/scripts/slave/recipe_modules/auto_bisect_staging/revision_state.py
[modify] https://crrev.com/75646a7cf53bbf029ffc22356430e8edb4784150/scripts/slave/recipe_modules/bisect_tester_staging/perf_test.py
[modify] https://crrev.com/75646a7cf53bbf029ffc22356430e8edb4784150/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/basic_perf_tryjob_with_metric.json

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/a5700d90eca1e05a02bf85b8993541f5ca631fb8

commit a5700d90eca1e05a02bf85b8993541f5ca631fb8
Author: Simon <simonhatch@chromium.org>
Date: Fri Dec 02 17:06:45 2016

Push bisect_staging changes to prod

Bisect - Check for buildbot output tests.
Bisect - Fail if no values from "Gathering Reference Values

BUG= 666447 ,  668529 

Change-Id: Ida0ac3db2e04f5ab4ed17bb3f0910ed4af77dd0d
Reviewed-on: https://chromium-review.googlesource.com/415618
Reviewed-by: Prasad Vuppalapu <prasadv@chromium.org>
Commit-Queue: Simon Hatch <simonhatch@chromium.org>

[modify] https://crrev.com/a5700d90eca1e05a02bf85b8993541f5ca631fb8/scripts/slave/recipe_modules/auto_bisect/bisector.py
[add] https://crrev.com/a5700d90eca1e05a02bf85b8993541f5ca631fb8/scripts/slave/recipe_modules/auto_bisect/example.expected/basic_buildbot_bisect.json
[modify] https://crrev.com/a5700d90eca1e05a02bf85b8993541f5ca631fb8/scripts/slave/recipe_modules/auto_bisect/example.expected/failed_buildbucket_get.json
[add] https://crrev.com/a5700d90eca1e05a02bf85b8993541f5ca631fb8/scripts/slave/recipe_modules/auto_bisect/example.expected/gathering_references_no_values.json
[modify] https://crrev.com/a5700d90eca1e05a02bf85b8993541f5ca631fb8/scripts/slave/recipe_modules/auto_bisect/example.py
[modify] https://crrev.com/a5700d90eca1e05a02bf85b8993541f5ca631fb8/scripts/slave/recipe_modules/auto_bisect/revision_state.py
[modify] https://crrev.com/a5700d90eca1e05a02bf85b8993541f5ca631fb8/scripts/slave/recipe_modules/bisect_tester/perf_test.py
[modify] https://crrev.com/a5700d90eca1e05a02bf85b8993541f5ca631fb8/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_metric.json

Status: Fixed (was: Untriaged)
Components: Speed>Bisection

Sign in to add a comment