New issue
Advanced search Search tips

Issue 666443 link

Starred by 1 user
Status: Fixed
Owner:
tedc...@chromium.org
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----



Sign in to add a comment

Toolbar pop in after resuming an Activity.

Project Member Reported by tedc...@chromium.org, Nov 17 2016 
Steps to reproduce: 
1.) Scroll off the top controls/toolbar
2.) Exit Chrome (via the home button)
3.) Return to Chrome

Observed behavior: 
Toolbar just pops in

Expected behavior: 
The toolbar should animate in nicely.

Introduced in:
https://codereview.chromium.org/2484293003
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1e53e302cbb06925cbab1c0fec36dcf56ca33b8

commit d1e53e302cbb06925cbab1c0fec36dcf56ca33b8
Author: tedchoc <tedchoc@chromium.org>
Date: Fri Nov 18 03:09:03 2016

[Android] Fix toolbar jumping in after returning to Chrome.

The fix is two fold:
1.) Previously, it was being too aggressive about showing the
    controls based on any tab model event.  It should only do this
    if the tab changed.
2.) The transient show request on activity resumption was fighting
    with Android's activity animation, so this introduces a delay
    to make it look pretty.

BUG= 666443 

Review-Url: https://codereview.chromium.org/2512573003
Cr-Commit-Position: refs/heads/master@{#433043}

[modify] https://crrev.com/d1e53e302cbb06925cbab1c0fec36dcf56ca33b8/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java

Comment 2 by tedc...@chromium.org, Nov 18 2016

Status: Fixed (was: Started)
►

Sign in to add a comment