New issue
Advanced search Search tips

Issue 666441 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in SkCanvas::getDevice

Project Member Reported by ClusterFuzz, Nov 17 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6638571684626432

Fuzzer: ifratric_acrojs
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x621001650910
Crash State:
  SkCanvas::getDevice
  skia::GetMetaData
  printing::MetafileSkiaWrapper::GetMetafileFromCanvas
  
Recommended Security Severity: High

Regressed: https://cluster-fuzz.appspot.com/revisions?job=mac_asan_chrome&range=432464:432588

Minimized Testcase (876.46 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96vW-CX3LG0cIpdKok8nPT9uqDPZcn3Xf0wgxHpu38PAJwFYoQBvnpVLdxcdWWhMsWCBue-tRvPMV-EHrVZu5uG4nVORAfIpY4Zo6uTbHOLbmF9ZS3-aV-ySr4xvdNbC-hSRmcW598Dx4RMqoKLI7dcwn8sPnVJFwWQ3tEiALYCTcKvF2k?testcase_id=6638571684626432

Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 

Comment 1 by mea...@chromium.org, Nov 18 2016

Components: Blink>Canvas
Labels: Pri-1
Owner: junov@chromium.org
Status: Assigned (was: Untriaged)
junov: Can you please take a look? Thanks.
Project Member

Comment 2 by sheriffbot@chromium.org, Nov 18 2016

Labels: M-56
Project Member

Comment 3 by sheriffbot@chromium.org, Nov 18 2016

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by junov@chromium.org, Nov 18 2016

Status: Started (was: Assigned)

Comment 5 by junov@chromium.org, Nov 18 2016

Components: -Blink>Canvas Internals>Printing Internals>Skia>PDF
Owner: halcanary@chromium.org
Status: Assigned (was: Started)
This is a printing bug, not a canvas bug.
halcanary: please take a look.
Cc: reed@google.com

Comment 7 by reed@google.com, Nov 18 2016

Is this fixed with https://codereview.chromium.org/2509983004/ ?
I'll ask ClusterFuzz to rerun it.
reed's revert is r433136, and CF is testing at r433191. So we'll let it do its thing and report back.
Project Member

Comment 10 by sheriffbot@chromium.org, Nov 19 2016

Labels: M-56
Project Member

Comment 11 by sheriffbot@chromium.org, Dec 2 2016

Labels: -Security_Impact-Head Security_Impact-Beta
Project Member

Comment 12 by sheriffbot@chromium.org, Dec 3 2016

halcanary: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Any updates on this?  We're planning on shipping to Beta tomorrow on 12/8
Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
Moving to ReleaseBlock-Stable so this still gets tracked in the milestone
Project Member

Comment 15 by ClusterFuzz, Dec 16 2016

ClusterFuzz has detected this issue as fixed in range 432588:432805.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6638571684626432

Fuzzer: ifratric_acrojs
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x621001650910
Crash State:
  SkCanvas::getDevice
  skia::GetMetaData
  printing::MetafileSkiaWrapper::GetMetafileFromCanvas
  
Recommended Security Severity: High

Regressed: https://cluster-fuzz.appspot.com/revisions?job=mac_asan_chrome&range=432464:432588
Fixed: https://cluster-fuzz.appspot.com/revisions?job=mac_asan_chrome&range=432588:432805

Minimized Testcase (876.46 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96vW-CX3LG0cIpdKok8nPT9uqDPZcn3Xf0wgxHpu38PAJwFYoQBvnpVLdxcdWWhMsWCBue-tRvPMV-EHrVZu5uG4nVORAfIpY4Zo6uTbHOLbmF9ZS3-aV-ySr4xvdNbC-hSRmcW598Dx4RMqoKLI7dcwn8sPnVJFwWQ3tEiALYCTcKvF2k?testcase_id=6638571684626432

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 16 by ClusterFuzz, Dec 16 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6638571684626432 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 17 by sheriffbot@chromium.org, Dec 17 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 18 by sheriffbot@chromium.org, Dec 19 2016

Labels: Merge-Request-56

Comment 19 by dimu@chromium.org, Dec 20 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 20 by sheriffbot@chromium.org, Dec 23 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Approved -ReleaseBlock-Stable -Merge-Approved-56
Fixed in M56 per comment 16
Project Member

Comment 22 by sheriffbot@chromium.org, Mar 25 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment