New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666421 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
no longer active
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

[Media Router] Some translations show " ".

Project Member Reported by apaci...@chromium.org, Nov 17 2016

Issue description

CrOS 56.0.2923.0 64 bit (local build)
Haven't tried other languages yet.

What is the expected result?
"Google Hangouts"
"Besoin d'aide?"

What happens instead?
"Google Hangouts"
"Besoin d'aide ?"
 
Screenshot from 2016-11-17 11:10:41.png
29.7 KB View Download
FWIW, there's a space between "d'aide" and "?", but not between "Google" and "Hangouts" in the French translations -- https://cs.chromium.org/chromium/src/chrome/app/resources/generated_resources_fr.xtb
Components: -Blink>PresentationAPI Internals>Cast>UI
Owner: apaci...@chromium.org
Status: Assigned (was: Untriaged)
Ping Jennifer; are you able to look at this?  M56 goes to Beta later this week.

Comment 4 Deleted

I'll take a look today.
Cc: apaci...@chromium.org
Owner: gov...@chromium.org
It looks like this is an issue with the translations we got, so it affects French (general, Canada, France, and Switzerland options).

Also tried for good measure: Spanish, Italian, Chinese (Traditional), Hebrew, Bulgarian.

These changes will fix the strings to be [screenshot]: https://codereview.chromium.org/2551023007/

It looks like XTBs are updated periodically. govind@, what's the best way to get these changes in?
Screenshot from 2016-12-05 17:00:34.png
28.1 KB View Download
Cc: klo...@chromium.org
Once change is merged to M55, it will get picked up by weekly translation run which I run every Monday.

+ klobag@ (Chrome OS M56 TPM) for M56  merge review approval (String freeze for M56 was on 11/04/16)
Cc: -apaci...@chromium.org dimu@chromium.org gov...@chromium.org
Owner: apaci...@chromium.org
Thanks govind@. Per offline convo, roped in dimu@ (via email) to see how to proceed.
Status: Started (was: Assigned)
I've sent out the patch to manually update the strings in the xtb file. I'll request a merge afterwards.

Currently discussing how to update the strings in the translations tool that we pull the xtbs from with dimu@.
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdc6e6902254955083de6a84f9148099c1404308

commit fdc6e6902254955083de6a84f9148099c1404308
Author: apacible <apacible@chromium.org>
Date: Wed Dec 07 16:43:16 2016

[Media Router] Update French strings.

The existing strings show an unwanted "&nbsp;". This manual change should be merged to 56 and the strings updated in the translation tool (source of the xtb files) for future versions.

BUG= 666421 

Review-Url: https://codereview.chromium.org/2551023007
Cr-Commit-Position: refs/heads/master@{#436980}

[modify] https://crrev.com/fdc6e6902254955083de6a84f9148099c1404308/chrome/app/resources/generated_resources_fr.xtb

Labels: Merge-Request-56

Comment 12 by dimu@chromium.org, Dec 9 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Why in the world does web UI turn 'U+00A0' (NBSP) to a literal '&nbsp;' ?  
In addition to fixing strings in xtb/TC, that issue also has to be taken care of (perhaps in a separate bug). 

Project Member

Comment 14 by bugdroid1@chromium.org, Dec 9 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0cd7d847332ce56948c97792fe3bf90a77f53e6

commit a0cd7d847332ce56948c97792fe3bf90a77f53e6
Author: Jennifer Apacible <apacible@chromium.org>
Date: Fri Dec 09 23:05:56 2016

[Media Router] Update French strings.

The existing strings show an unwanted "&nbsp;". This manual change should be merged to 56 and the strings updated in the translation tool (source of the xtb files) for future versions.

BUG= 666421 

Review-Url: https://codereview.chromium.org/2551023007
Cr-Commit-Position: refs/heads/master@{#436980}
(cherry picked from commit fdc6e6902254955083de6a84f9148099c1404308)

Review URL: https://codereview.chromium.org/2563863004 .

Cr-Commit-Position: refs/branch-heads/2924@{#440}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/a0cd7d847332ce56948c97792fe3bf90a77f53e6/chrome/app/resources/generated_resources_fr.xtb

Status: Fixed (was: Started)
re #13: Filed issue 673045 to track general issue. 

jshin@ also made manual changes for our French strings in TC. Thank you!

Comment 16 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 18 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment