[Media Router] Some translations show " ". |
|||||||||||||
Issue descriptionCrOS 56.0.2923.0 64 bit (local build) Haven't tried other languages yet. What is the expected result? "Google Hangouts" "Besoin d'aide?" What happens instead? "Google Hangouts" "Besoin d'aide ?"
,
Dec 1 2016
,
Dec 5 2016
Ping Jennifer; are you able to look at this? M56 goes to Beta later this week.
,
Dec 6 2016
I'll take a look today.
,
Dec 6 2016
It looks like this is an issue with the translations we got, so it affects French (general, Canada, France, and Switzerland options). Also tried for good measure: Spanish, Italian, Chinese (Traditional), Hebrew, Bulgarian. These changes will fix the strings to be [screenshot]: https://codereview.chromium.org/2551023007/ It looks like XTBs are updated periodically. govind@, what's the best way to get these changes in?
,
Dec 6 2016
Once change is merged to M55, it will get picked up by weekly translation run which I run every Monday. + klobag@ (Chrome OS M56 TPM) for M56 merge review approval (String freeze for M56 was on 11/04/16)
,
Dec 6 2016
Thanks govind@. Per offline convo, roped in dimu@ (via email) to see how to proceed.
,
Dec 6 2016
I've sent out the patch to manually update the strings in the xtb file. I'll request a merge afterwards. Currently discussing how to update the strings in the translations tool that we pull the xtbs from with dimu@.
,
Dec 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fdc6e6902254955083de6a84f9148099c1404308 commit fdc6e6902254955083de6a84f9148099c1404308 Author: apacible <apacible@chromium.org> Date: Wed Dec 07 16:43:16 2016 [Media Router] Update French strings. The existing strings show an unwanted " ". This manual change should be merged to 56 and the strings updated in the translation tool (source of the xtb files) for future versions. BUG= 666421 Review-Url: https://codereview.chromium.org/2551023007 Cr-Commit-Position: refs/heads/master@{#436980} [modify] https://crrev.com/fdc6e6902254955083de6a84f9148099c1404308/chrome/app/resources/generated_resources_fr.xtb
,
Dec 9 2016
,
Dec 9 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 9 2016
Why in the world does web UI turn 'U+00A0' (NBSP) to a literal ' ' ? In addition to fixing strings in xtb/TC, that issue also has to be taken care of (perhaps in a separate bug).
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0cd7d847332ce56948c97792fe3bf90a77f53e6 commit a0cd7d847332ce56948c97792fe3bf90a77f53e6 Author: Jennifer Apacible <apacible@chromium.org> Date: Fri Dec 09 23:05:56 2016 [Media Router] Update French strings. The existing strings show an unwanted " ". This manual change should be merged to 56 and the strings updated in the translation tool (source of the xtb files) for future versions. BUG= 666421 Review-Url: https://codereview.chromium.org/2551023007 Cr-Commit-Position: refs/heads/master@{#436980} (cherry picked from commit fdc6e6902254955083de6a84f9148099c1404308) Review URL: https://codereview.chromium.org/2563863004 . Cr-Commit-Position: refs/branch-heads/2924@{#440} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/a0cd7d847332ce56948c97792fe3bf90a77f53e6/chrome/app/resources/generated_resources_fr.xtb
,
Dec 9 2016
re #13: Filed issue 673045 to track general issue. jshin@ also made manual changes for our French strings in TC. Thank you!
,
May 30 2017
,
Aug 1 2017
,
Jan 22 2018
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by apaci...@chromium.org
, Nov 17 2016