This is a follow-up bug of bug 665259 . Now we have many conditions to handle the specialty of paint offsets of these objects. We should refactor to remove the special conditions as much as possible.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74454dfeaa27a9f696824e0a2a1548175d2e26ab commit 74454dfeaa27a9f696824e0a2a1548175d2e26ab Author: wangxianzhu <wangxianzhu@chromium.org> Date: Fri Nov 18 03:53:50 2016 Avoid special handling of LayoutSVGForeignObject about its paint offset Previously we painted a LayoutSVGForeignObject in the following way: 1 Issue transform and clip based on localSVGTransform; 2 Call BlockFlowPainter::paint with zero LayoutPoint() 3 BlockFlowPainter::paint uses the object's location() as the actual paint offset. The above painting method also required us to generate the same paint properties in PaintPropertyTreeBuilder. This CL change painting of LayoutSVGForiegnObject in a new way: 1 Issue transform and clip based on localToSVGParentTransform which includes the viewport offset; 2 Call BlockFlowPainter::paint with -location() as the paint offset; 3 BlockFlowPainter::paint then add the object's location() to the paint offset which results a zero paint offset. With the new method, LayoutSVGForeignObject behaves more like a normal SVG object so we can remove some special handling of it. BUG= 666416 x CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2512493003 Cr-Commit-Position: refs/heads/master@{#433080} [modify] https://crrev.com/74454dfeaa27a9f696824e0a2a1548175d2e26ab/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp [modify] https://crrev.com/74454dfeaa27a9f696824e0a2a1548175d2e26ab/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.h [modify] https://crrev.com/74454dfeaa27a9f696824e0a2a1548175d2e26ab/third_party/WebKit/Source/core/layout/svg/LayoutSVGViewportContainer.h [modify] https://crrev.com/74454dfeaa27a9f696824e0a2a1548175d2e26ab/third_party/WebKit/Source/core/paint/ObjectPainter.cpp [modify] https://crrev.com/74454dfeaa27a9f696824e0a2a1548175d2e26ab/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp [modify] https://crrev.com/74454dfeaa27a9f696824e0a2a1548175d2e26ab/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp [modify] https://crrev.com/74454dfeaa27a9f696824e0a2a1548175d2e26ab/third_party/WebKit/Source/core/paint/SVGForeignObjectPainter.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/478770fa0efff410715a804f55a4cc283a3a683e commit 478770fa0efff410715a804f55a4cc283a3a683e Author: wangxianzhu <wangxianzhu@chromium.org> Date: Sat Nov 19 00:11:18 2016 Update documentation and cleanup impls for localToSVGParentTransform() BUG= 666416 Review-Url: https://codereview.chromium.org/2514573003 Cr-Commit-Position: refs/heads/master@{#433344} [modify] https://crrev.com/478770fa0efff410715a804f55a4cc283a3a683e/third_party/WebKit/Source/core/layout/LayoutObject.cpp [modify] https://crrev.com/478770fa0efff410715a804f55a4cc283a3a683e/third_party/WebKit/Source/core/layout/LayoutObject.h [modify] https://crrev.com/478770fa0efff410715a804f55a4cc283a3a683e/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp [modify] https://crrev.com/478770fa0efff410715a804f55a4cc283a3a683e/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.h [modify] https://crrev.com/478770fa0efff410715a804f55a4cc283a3a683e/third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.h [modify] https://crrev.com/478770fa0efff410715a804f55a4cc283a3a683e/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp [modify] https://crrev.com/478770fa0efff410715a804f55a4cc283a3a683e/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.h [modify] https://crrev.com/478770fa0efff410715a804f55a4cc283a3a683e/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp [modify] https://crrev.com/478770fa0efff410715a804f55a4cc283a3a683e/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.h [modify] https://crrev.com/478770fa0efff410715a804f55a4cc283a3a683e/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.h [modify] https://crrev.com/478770fa0efff410715a804f55a4cc283a3a683e/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.h [modify] https://crrev.com/478770fa0efff410715a804f55a4cc283a3a683e/third_party/WebKit/Source/core/layout/svg/LayoutSVGTransformableContainer.h [modify] https://crrev.com/478770fa0efff410715a804f55a4cc283a3a683e/third_party/WebKit/Source/core/layout/svg/LayoutSVGViewportContainer.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82ac602161c3c94c1c7dc979339a2908f71e71ca commit 82ac602161c3c94c1c7dc979339a2908f71e71ca Author: wangxianzhu <wangxianzhu@chromium.org> Date: Sat Nov 19 23:58:14 2016 Use LayoutBox::frameRect() as the viewport of LayoutSVGForeignObject LayoutBox::frameRect() and LayoutSVGForeignObject::viewportRect() have the same value, so we can just use the former. Also fixed vertical writing mode bug. This make it easier to let SVGText behave in a similar way. BUG= 666416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2510313004 Cr-Commit-Position: refs/heads/master@{#433431} [modify] https://crrev.com/82ac602161c3c94c1c7dc979339a2908f71e71ca/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 [add] https://crrev.com/82ac602161c3c94c1c7dc979339a2908f71e71ca/third_party/WebKit/LayoutTests/svg/foreignObject/vertical-foreignObject-expected.html [add] https://crrev.com/82ac602161c3c94c1c7dc979339a2908f71e71ca/third_party/WebKit/LayoutTests/svg/foreignObject/vertical-foreignObject.html [modify] https://crrev.com/82ac602161c3c94c1c7dc979339a2908f71e71ca/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp [modify] https://crrev.com/82ac602161c3c94c1c7dc979339a2908f71e71ca/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.h [modify] https://crrev.com/82ac602161c3c94c1c7dc979339a2908f71e71ca/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp [modify] https://crrev.com/82ac602161c3c94c1c7dc979339a2908f71e71ca/third_party/WebKit/Source/core/paint/SVGForeignObjectPainter.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a85757755e1db65b954b4a40283ad5660ae84630 commit a85757755e1db65b954b4a40283ad5660ae84630 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Sun Nov 20 18:13:19 2016 Revert of Avoid special handling of LayoutSVGForeignObject about its paint offset (patchset #2 id:20001 of https://codereview.chromium.org/2512493003/ ) Reason for revert: It is incorrect to treat the HTML viewport defined by a LayoutSVGForeignObject as the "local SVG coordinate space", because it's not the space that the local svg transform, clip path and filters apply. This CL is wrong because it treats the wrong LayoutSVGForeignObject::localToParentSVGTransform() as correct and used a wrong way to remedy that. This CL breaks clip path on foreignObject because the clip path is applied in wrong space. Original issue's description: > Avoid special handling of LayoutSVGForeignObject about its paint offset > > Previously we painted a LayoutSVGForeignObject in the following way: > 1 Issue transform and clip based on localSVGTransform; > 2 Call BlockFlowPainter::paint with zero LayoutPoint() > 3 BlockFlowPainter::paint uses the object's location() as the actual > paint offset. > > The above painting method also required us to generate the same paint > properties in PaintPropertyTreeBuilder. > > This CL change painting of LayoutSVGForiegnObject in a new way: > 1 Issue transform and clip based on localToSVGParentTransform which > includes the viewport offset; > 2 Call BlockFlowPainter::paint with -location() as the paint offset; > 3 BlockFlowPainter::paint then add the object's location() to the > paint offset which results a zero paint offset. > > With the new method, LayoutSVGForeignObject behaves more like a normal > SVG object so we can remove some special handling of it. > > BUG= 666416 > > x > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Committed: https://crrev.com/74454dfeaa27a9f696824e0a2a1548175d2e26ab > Cr-Commit-Position: refs/heads/master@{#433080} TBR=pdr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 666416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2513293002 Cr-Commit-Position: refs/heads/master@{#433456} [modify] https://crrev.com/a85757755e1db65b954b4a40283ad5660ae84630/third_party/WebKit/Source/core/paint/ObjectPainter.cpp [modify] https://crrev.com/a85757755e1db65b954b4a40283ad5660ae84630/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp [modify] https://crrev.com/a85757755e1db65b954b4a40283ad5660ae84630/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp [modify] https://crrev.com/a85757755e1db65b954b4a40283ad5660ae84630/third_party/WebKit/Source/core/paint/SVGForeignObjectPainter.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2 commit 56fe6c7ab880c20c1a6c97532d70018b5c3b47d2 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Tue Nov 22 00:01:44 2016 Change SVG layout tree output to be more meaningful and consistent - Change position output of SVGRoot from absoluteVisualRect() to frameRect() to keep consistency to non-SVG objects, and avoid confusion when the output's location overlaps with parent's location. - Change position output of other SVG objects from absoluteVisualRect() to objectBoundingBox() to make it similar to other outputs which use local geometries. - Change position output of SVG inline text from FloatRect(firstRunOrigin(), boundingBox().width()) to objectBoundingBox(). The original output didn't make sense when the first run is not at the top-left corner (e.g. <text dy="0,-5">ABC</text>). - Remove enclosingIntRect() to let the output reflect subpixel layouts. The possibility of more flakiness is low because 1) the numbers are rounded to keep 2 fraction digits and 2) we already output float positions for svg line layout geometries. This is a preparation before unifying SVGLayoutText coordinate spaces (to let the underlying LayoutBlockFlow see consistent coordinates for texts and outlines). BUG= 666416 R=pdr@chromium.org Review URL: https://codereview.chromium.org/2521473002 . Cr-Commit-Position: refs/heads/master@{#433709} [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/SlowTests [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/css3/filters/buffer-offset-expected.txt [delete] https://crrev.com/4bbdb78cb38b2b39e2adba32fee547680a64d594/third_party/WebKit/LayoutTests/css3/filters/effect-reference-hidpi-hw-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/css3/filters/effect-reference-subregion-nested-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/fast/parser/innerhtml-with-prefixed-elements-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/paint/invalidation/repaint-svg-after-style-change-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/paint/invalidation/svg-layout-root-style-attr-update-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/accelerated-scrolling-with-clip-path-text-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/css2.1/20110323/replaced-intrinsic-001-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/css2.1/20110323/replaced-intrinsic-002-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/css2.1/20110323/replaced-intrinsic-003-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/css2.1/20110323/replaced-intrinsic-004-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/css2.1/20110323/replaced-intrinsic-005-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-colorspace-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-colorspace-hw-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-composite-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-composite-hw-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-hw-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-ordering-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-ordering-hw-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-subregion-chained-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-subregion-chained-hw-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-subregion-colormatrix-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-subregion-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-subregion-hw-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-subregion-nested-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-tile-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-tile-hw-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/http/tests/misc/slow-loading-image-in-pattern-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/repaint-svg-after-style-change-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/filter-repaint-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-no-markup-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-direction-ltr-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-direction-rtl-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/painting-marker-05-f-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/painting-marker-06-f-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-12-t-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt [modify] https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2/third_party/WebKit/LayoutTests/platform/linux/s
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54a1e2fb8bed7a75e8912941075918eb944f0a04 commit 54a1e2fb8bed7a75e8912941075918eb944f0a04 Author: tsergeant <tsergeant@chromium.org> Date: Tue Nov 22 07:23:42 2016 Fix expectations for svg tests on Android SVG output format was changed in crrev.com/433709, these two tests were not updated and are failing on Android. BUG= 666416 TBR=wangxianzhu@chromium.org Review-Url: https://codereview.chromium.org/2520243002 Cr-Commit-Position: refs/heads/master@{#433807} [modify] https://crrev.com/54a1e2fb8bed7a75e8912941075918eb944f0a04/third_party/WebKit/LayoutTests/TestExpectations
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5520eaea333dc73d12ec54d92ed3bbf4ef8a6ad0 commit 5520eaea333dc73d12ec54d92ed3bbf4ef8a6ad0 Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org> Date: Tue Nov 22 08:25:43 2016 Auto-rebaseline for r433807 https://chromium.googlesource.com/chromium/src/+/54a1e2fb8 BUG= 666416 TBR=tsergeant@chromium.org Review URL: https://codereview.chromium.org/2525553002 . Cr-Commit-Position: refs/heads/master@{#433816} [modify] https://crrev.com/5520eaea333dc73d12ec54d92ed3bbf4ef8a6ad0/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/5520eaea333dc73d12ec54d92ed3bbf4ef8a6ad0/third_party/WebKit/LayoutTests/platform/android/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt [modify] https://crrev.com/5520eaea333dc73d12ec54d92ed3bbf4ef8a6ad0/third_party/WebKit/LayoutTests/platform/android/svg/batik/text/textAnchor3-expected.txt
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/400fdf9156f94a39c175e007ed9e70f2b8c8237d commit 400fdf9156f94a39c175e007ed9e70f2b8c8237d Author: wangxianzhu <wangxianzhu@chromium.org> Date: Wed Nov 23 04:08:02 2016 Output LayoutSVGInline in layout tree in SVG way Previously LayoutSVGInline was dumped in the default HTML object way. Change it to use the SVG way. This is to avoid the layout tree differences that would be caused by the upcoming CL to unify LayoutSVGText coordinate spaces. BUG= 666416 Review-Url: https://codereview.chromium.org/2524803002 Cr-Commit-Position: refs/heads/master@{#434109} [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/android/svg/batik/text/textAnchor3-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-direction-ltr-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/tspan-direction-rtl-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/struct-frag-05-t-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/styling-css-05-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/styling-css-06-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-align-02-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-align-03-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-align-04-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-align-06-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-deco-01-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-path-01-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/longTextOnPath-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/smallFonts-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textAnchor-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textAnchor2-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textAnchor3-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textDecoration-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textDecoration2-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textEffect3-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textFeatures-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textGlyphOrientationHorizontal-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textLayout-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textLayout2-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textLength-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textOnPath-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textOnPath2-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textOnPath3-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textOnPathSpaces-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textPCDATA-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textPosition-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textPosition2-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textProperties-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textProperties2-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/verticalText-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/verticalTextOnPath-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/xmlSpace-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/carto.net/colourpicker-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/carto.net/scrollbar-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/clip-path/clip-path-tspan-and-stroke-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/css/text-shadow-multiple-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/custom/alignment-baseline-modes-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/custom/container-opacity-clip-viewBox-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/custom/empty-mask-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/custom/image-small-width-height-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/custom/text-dom-01-f-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/custom/text-letter-spacing-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/custom/text-linking-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/custom/text-match-highlight-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/custom/text-rotation-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/custom/text-x-dx-lists-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/custom/text-x-dy-lists-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/custom/text-x-override-in-tspan-child-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/filters/filter-on-filter-for-text-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/filters/filter-on-tspan-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/text/bbox-with-glyph-overflow-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/text/bbox-with-glyph-overflow-on-path-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/text/bbox-with-glyph-overflow-zoomed-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/text/bidi-embedded-direction-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/text/bidi-reorder-value-lists-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/text/bidi-text-query-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/text/bidi-tspans-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/text/font-size-below-point-five-2-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/text/ligature-queries-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/text/scaled-font-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/text/select-x-list-with-tspans-1-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/text/select-x-list-with-tspans-2-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/text/select-x-list-with-tspans-3-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/text/select-x-list-with-tspans-4-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/text/small-fonts-2-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/text/text-decorations-in-scaled-pattern-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/text/text-midpoint-split-bug-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/text/text-path-middle-align-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/text/text-selection-align-02-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/text/text-selection-align-03-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/text/text-selection-align-04-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/text/text-selection-align-06-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/text/text-selection-deco-01-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/text/text-selection-path-01-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/text/text-selection-tselect-01-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/text/text-selection-tspan-01-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/linux/svg/text/text-with-geometric-precision-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/W3C-SVG-1.1/text-align-08-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/text/ligature-queries-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/tspan-direction-ltr-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/tspan-direction-rtl-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/struct-frag-05-t-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/styling-css-05-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/styling-css-06-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-align-02-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-align-03-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-align-04-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-align-06-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-align-08-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-deco-01-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-path-01-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/longTextOnPath-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/smallFonts-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/textAnchor-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/textAnchor2-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/textAnchor3-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/textDecoration-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/textDecoration2-expected.txt [modify] https://crrev.com/400fdf9156f94a39c175e007ed9e70f2b8c8237d/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/textEffect3-expected.txt [modify] https://crrev.com/400fdf915
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ef01616c17c1ffb3a6c5d1430b3641c2c25c6cb commit 6ef01616c17c1ffb3a6c5d1430b3641c2c25c6cb Author: wangxianzhu <wangxianzhu@chromium.org> Date: Wed Nov 23 22:48:22 2016 Fix SVG vertical text layout issues We layout SVG text fragments in physical coordinates of SVG <text>. SVG text layout objects inherite from HTML text layout objects. Previously we saved the physical coordinates in the HTML layout objects as logical coordinates, and tried to override the HTML code with SVG specific code to interprete the logical coordinates as physical coordinates in painting and hittesting, etc. However, there are still HTML code use the coordinates as logical and break some cases. Now convert the physical coordinates into appropriate coordinates required by the HTML layout objects before saving them. Also let SVG painting and hittesting code interprete the coordinates in the same way as HTML code does. Optimized SVGRootInlineBox::layoutChildBoxes() to reduce the complexity from O(2^logN) to O(N) (where N = number of line box nodes). SVGInlineFlowBox::calcuateBoundaries() will be removed in a later CL. Fix bug that the indirect descendants of the root box were not adjusted to the block coordinates. BUG= 666416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2524113002 Cr-Commit-Position: refs/heads/master@{#434270} [add] https://crrev.com/6ef01616c17c1ffb3a6c5d1430b3641c2c25c6cb/third_party/WebKit/LayoutTests/svg/text/vertical-discrete-chars-expected.html [add] https://crrev.com/6ef01616c17c1ffb3a6c5d1430b3641c2c25c6cb/third_party/WebKit/LayoutTests/svg/text/vertical-discrete-chars.html [add] https://crrev.com/6ef01616c17c1ffb3a6c5d1430b3641c2c25c6cb/third_party/WebKit/LayoutTests/svg/text/vertical-discrete-tspans-expected.html [add] https://crrev.com/6ef01616c17c1ffb3a6c5d1430b3641c2c25c6cb/third_party/WebKit/LayoutTests/svg/text/vertical-discrete-tspans.html [modify] https://crrev.com/6ef01616c17c1ffb3a6c5d1430b3641c2c25c6cb/third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp [modify] https://crrev.com/6ef01616c17c1ffb3a6c5d1430b3641c2c25c6cb/third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.cpp [modify] https://crrev.com/6ef01616c17c1ffb3a6c5d1430b3641c2c25c6cb/third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.h [modify] https://crrev.com/6ef01616c17c1ffb3a6c5d1430b3641c2c25c6cb/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4ece262ce1150e23a18ad661aa5e1b213f95f51 commit b4ece262ce1150e23a18ad661aa5e1b213f95f51 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Tue Nov 29 04:12:08 2016 Unify HTML and SVG coordinates of LayoutSVGText LayoutSVGText inherits from LayoutBlockFlow. During layout, at first SVG text fragments are laid out in physical coordinates in local SVG coordinates of LayoutSVGText, then the underlying LayoutBlockFlow and inline boxes are laid out in the coordinate space of the bounding box of the text fragments. The difference between HTML and SVG coordinates of LayoutSVGText causes some compexities, such as inconsistent coordinate space of SVG inline box calculateBoundaries(), complicated paint offset situations for outline and text when building paint property tree and painting (about text fragments painted in coordinates with paint offset baked in while outline painted with explicit paint offset), etc. Unifying the two coordinates can avoid the complexities. BUG= 666416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2531943002 Cr-Commit-Position: refs/heads/master@{#434885} [add] https://crrev.com/b4ece262ce1150e23a18ad661aa5e1b213f95f51/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/svg/text/text-layout-crash-expected.png [modify] https://crrev.com/b4ece262ce1150e23a18ad661aa5e1b213f95f51/third_party/WebKit/LayoutTests/platform/linux/svg/text/text-layout-crash-expected.png [modify] https://crrev.com/b4ece262ce1150e23a18ad661aa5e1b213f95f51/third_party/WebKit/LayoutTests/platform/mac/svg/text/text-layout-crash-expected.png [modify] https://crrev.com/b4ece262ce1150e23a18ad661aa5e1b213f95f51/third_party/WebKit/LayoutTests/platform/win/svg/text/text-layout-crash-expected.png [modify] https://crrev.com/b4ece262ce1150e23a18ad661aa5e1b213f95f51/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp [modify] https://crrev.com/b4ece262ce1150e23a18ad661aa5e1b213f95f51/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.h [modify] https://crrev.com/b4ece262ce1150e23a18ad661aa5e1b213f95f51/third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.cpp [modify] https://crrev.com/b4ece262ce1150e23a18ad661aa5e1b213f95f51/third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d66facc4263f517ee3cd4d733120bc9e5380cd1 commit 5d66facc4263f517ee3cd4d733120bc9e5380cd1 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Tue Nov 29 05:56:55 2016 Refactor InlineBox::calculateBoundaries() Previously calculateBoundaries() were used for two different purposes: - For InlineTextBox, this is to retrieve the frame rect (LayoutRect(x(), y(), width(), height()) which is a result of layout. - For SVGInlineFlowBox and SVGInlineTextBox this is a task during layout to calculate the boundaries based on the positions of text fragments. Remove InlineBox::calculateBoundaries() because we don't need it in this abstraction level. Rename InlineTextBox::calculateBoundaries() to frameRect(). Keep SVGInlineTextBox::calculateBoundaries() which is no longer virtual. BUG= 666416 Review-Url: https://codereview.chromium.org/2518363003 Cr-Commit-Position: refs/heads/master@{#434907} [modify] https://crrev.com/5d66facc4263f517ee3cd4d733120bc9e5380cd1/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp [modify] https://crrev.com/5d66facc4263f517ee3cd4d733120bc9e5380cd1/third_party/WebKit/Source/core/layout/LayoutText.cpp [modify] https://crrev.com/5d66facc4263f517ee3cd4d733120bc9e5380cd1/third_party/WebKit/Source/core/layout/ScrollAnchor.cpp [modify] https://crrev.com/5d66facc4263f517ee3cd4d733120bc9e5380cd1/third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp [modify] https://crrev.com/5d66facc4263f517ee3cd4d733120bc9e5380cd1/third_party/WebKit/Source/core/layout/line/InlineBox.h [modify] https://crrev.com/5d66facc4263f517ee3cd4d733120bc9e5380cd1/third_party/WebKit/Source/core/layout/line/InlineTextBox.h [modify] https://crrev.com/5d66facc4263f517ee3cd4d733120bc9e5380cd1/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp [modify] https://crrev.com/5d66facc4263f517ee3cd4d733120bc9e5380cd1/third_party/WebKit/Source/core/layout/svg/line/SVGInlineFlowBox.cpp [modify] https://crrev.com/5d66facc4263f517ee3cd4d733120bc9e5380cd1/third_party/WebKit/Source/core/layout/svg/line/SVGInlineFlowBox.h [modify] https://crrev.com/5d66facc4263f517ee3cd4d733120bc9e5380cd1/third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f451d9b5de5a1b4691d60d8c74341ac8a466cf57 commit f451d9b5de5a1b4691d60d8c74341ac8a466cf57 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Wed Nov 30 18:12:40 2016 Let SVGForeignObject's local SVG coordinates mean what it should We define "local SVG coordinates" as the space where SVG local transform etc. apply. With this definition, SVGForeignObject's localSVGTransform and localToSVGParentTransform should be the same which should both transform from local SVG coordinates instead of local HTML coordinates to parent SVG coordinates, and visualRectInLocalSVGCoordinates() should return the visual rect in local SVG coordinates instead of local HTML coordinates. With the above coordinates fixed, LayoutSVGBlock becomes the same for LayoutSVGText and LayoutSVGForeignObject regarding to SVG/HTML coordinates: SVG coordinates = HTML coordinates + location() (though location() is always zero for LayoutSVGText after https://codereview.chromium.org/2531943002/). The HTML coordinate mapping methods should also map between the HTML and SVG coordinates. BUG= 666416 TEST=refectoring, no outside behavior change. All existing tests should pass. The internal behavior change will be tested in the next CL which removes the special treatment of paint offsets of SVGForeignObjects. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2536493002 Cr-Commit-Position: refs/heads/master@{#435337} [modify] https://crrev.com/f451d9b5de5a1b4691d60d8c74341ac8a466cf57/third_party/WebKit/Source/core/layout/LayoutObject.h [modify] https://crrev.com/f451d9b5de5a1b4691d60d8c74341ac8a466cf57/third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.cpp [modify] https://crrev.com/f451d9b5de5a1b4691d60d8c74341ac8a466cf57/third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.h [modify] https://crrev.com/f451d9b5de5a1b4691d60d8c74341ac8a466cf57/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp [modify] https://crrev.com/f451d9b5de5a1b4691d60d8c74341ac8a466cf57/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.h [modify] https://crrev.com/f451d9b5de5a1b4691d60d8c74341ac8a466cf57/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
Reopening after the #c12 is reverted for bug 704643 .
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09a6cd640fb5bf07aa06477362229c2e6969a718 commit 09a6cd640fb5bf07aa06477362229c2e6969a718 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Tue Mar 28 20:38:12 2017 Reland "Let SVGForeignObject's local SVG coordinates mean what it should" (patchset #2 id:20001 of https://codereview.chromium.org/2767343003/ ) Fix wrong direction of mapping in LayoutSVGBlock::mapAncestorToLocal(). > Revert: "Let SVGForeignObject's local SVG coordinates mean what it should" > > This patch caused a hit testing regression with foreign objects. While > the fix is not hard, we are going to roll out as a precaution (and merge > to stable). > > This is a manual revert of https://crrev.com/f451d9b5de5a1b4691d60d8c74341ac8a466cf57 > (commit number #435337) due to revert conflicts. > > BUG= 704643 > > Review-Url: https://codereview.chromium.org/2767343003 > Cr-Commit-Position: refs/heads/master@{#459330} > Committed: https://chromium.googlesource.com/chromium/src/+/0cfb512a4ae94e681bd10a15d93abd740f330e3e > Original issue's description: >> Let SVGForeignObject's local SVG coordinates mean what it should >> >> We define "local SVG coordinates" as the space where SVG local transform >> etc. apply. With this definition, SVGForeignObject's localSVGTransform >> and localToSVGParentTransform should be the same which should both >> transform from local SVG coordinates instead of local HTML coordinates >> to parent SVG coordinates, and visualRectInLocalSVGCoordinates() should >> return the visual rect in local SVG coordinates instead of local HTML >> coordinates. >> >> With the above coordinates fixed, LayoutSVGBlock becomes the same for >> LayoutSVGText and LayoutSVGForeignObject regarding to SVG/HTML >> coordinates: SVG coordinates = HTML coordinates + location() (though >> location() is always zero for LayoutSVGText after >> https://codereview.chromium.org/2531943002/). The HTML coordinate >> mapping methods should also map between the HTML and SVG coordinates. >> >> Review-Url: https://codereview.chromium.org/2536493002 >> Cr-Commit-Position: refs/heads/master@{#435337} BUG= 704643 , 666416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2778873002 Cr-Commit-Position: refs/heads/master@{#460209} [modify] https://crrev.com/09a6cd640fb5bf07aa06477362229c2e6969a718/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/text-rescale-expected.txt [modify] https://crrev.com/09a6cd640fb5bf07aa06477362229c2e6969a718/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/text-rescale-expected.txt [modify] https://crrev.com/09a6cd640fb5bf07aa06477362229c2e6969a718/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/text-rescale-expected.txt [modify] https://crrev.com/09a6cd640fb5bf07aa06477362229c2e6969a718/third_party/WebKit/Source/core/BUILD.gn [modify] https://crrev.com/09a6cd640fb5bf07aa06477362229c2e6969a718/third_party/WebKit/Source/core/layout/LayoutObject.h [modify] https://crrev.com/09a6cd640fb5bf07aa06477362229c2e6969a718/third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.cpp [modify] https://crrev.com/09a6cd640fb5bf07aa06477362229c2e6969a718/third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.h [modify] https://crrev.com/09a6cd640fb5bf07aa06477362229c2e6969a718/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp [modify] https://crrev.com/09a6cd640fb5bf07aa06477362229c2e6969a718/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.h [add] https://crrev.com/09a6cd640fb5bf07aa06477362229c2e6969a718/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObjectTest.cpp [modify] https://crrev.com/09a6cd640fb5bf07aa06477362229c2e6969a718/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
Issue 616864 has been merged into this issue.
Comment 1 by bugdroid1@chromium.org
, Nov 18 2016