New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666408 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

chromite: release builder fails with flag --latest-toolchain

Project Member Reported by yunlian@chromium.org, Nov 17 2016

Issue description

https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/release/builds/7206

It fails at build_image stage
tar: ./usr/lib/debug/usr/x86_64-cros-linux-gnu: Not found in archive
tar: Exiting with failure status due to previous errors

This is because with --latest-toolchain option, the toolchain is rebuilt with command line

 /b/cbuild/internal_master/chromite/bin/cros_sdk 'PARALLEL_EMERGE_STATUS_FILE=/tmp/tmphH_YSS' 'USE=-cros-debug chrome_internal' 'FEATURES=separatedebug' 'CHROME_ORIGIN=LOCAL_SOURCE' -- ./update_chroot --nousepkg --toolchain_boards terra in /b/cbuild/internal_master

I suspect because of the USE flag "-cros-debug", the debug file is no longer generated.

 

Comment 1 by vapier@chromium.org, Nov 17 2016

is it actually because of cros-debug ?  that shouldn't be impacting toolchains because none of those packages check that flag.  further, it doesn't control whether debug info is generated or splitdebug is used.  which is what everything under /usr/lib/debug/ is.

i suspect that error is coming from build_library/dev_image_util.sh:install_dev_packages where it tries to install glibc debug info manually:
  # Copy over the libc debug info so that gdb
  # works with threads and also for a better debugging experience.
  sudo mkdir -p "${root_fs_dir}/usr/local/usr/lib/debug"
  pbzip2 -dc --ignore-trailing-garbage=1 "${LIBC_PATH}" | \
    sudo tar xpf - -C "${root_fs_dir}/usr/local/usr/lib/debug" \
      ./usr/lib/debug/usr/${CHOST} --strip-components=6

so if the glibc binary package is missing debug info, look at whether the splitdebug feature is getting clobbered somewhere along the way.
Yes, it is not because of cros-debug. Looking at the splitdebug feature now.
It is because of the flag 'FEATURES=separatedebug'. Current patch
https://chromium-review.googlesource.com/#/c/412363/
Workarounds this prolem.

Is this the right way to go?
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/96dcef5639becb22bdead75b7344100248179cb4

commit 96dcef5639becb22bdead75b7344100248179cb4
Author: Yunlian Jiang <yunlian@google.com>
Date: Mon Nov 21 19:07:07 2016

Filter FEATURES from extra_env for update_chroot.

When running update_chroot, glibc needs FEATURES="splitdebug".
Some build configurations may clobber this FEATURES flag. This
fixes that.

BUG= chromium:666408 
TEST=cbuildbot daisy-release --latest-toolchain

Change-Id: I06342a371f3990a640ccbeb075b4f250b07ce0b9
Reviewed-on: https://chromium-review.googlesource.com/412363
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Caroline Tice <cmtice@chromium.org>

[modify] https://crrev.com/96dcef5639becb22bdead75b7344100248179cb4/cbuildbot/commands.py

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/486ab3a83c4c1e05f231ccde8bea868d1c13cad1

commit 486ab3a83c4c1e05f231ccde8bea868d1c13cad1
Author: Yunlian Jiang <yunlian@google.com>
Date: Fri Dec 02 19:44:03 2016

Follow up CL for 'Filter FEATURES from extra_env for update_chroot.'

This fixes some issues brought by CL:412363. It uses dict.copy instead
of copy.copy. It appends 'splitdebug' to 'FEATURES' instead of clobering
'FEATURES'.

BUG= chromium:666408 
TEST=cbuildbot daisy-release --latest-toolchain

Change-Id: I5f1253a92151e64487fec817c886d07dcb16cb0f
Reviewed-on: https://chromium-review.googlesource.com/416190
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Yunlian Jiang <yunlian@chromium.org>

[modify] https://crrev.com/486ab3a83c4c1e05f231ccde8bea868d1c13cad1/cbuildbot/commands.py

Labels: -Pri-3 Pri-2
Owner: yunlian@chromium.org
Status: Assigned (was: Untriaged)
Yunlian, can this be closed?
Status: Verified (was: Assigned)

Sign in to add a comment