New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666384 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Fuchsia
Pri: 2
Type: Bug

Blocked on:
issue 898351

Blocking:
issue 662644


Show other hotlists

Hotlists containing this issue:
webgl-conformance-all


Sign in to add a comment

texturesize and tex-mipmap-levels WebGL2 tests failing on Linux Intel

Project Member Reported by geoffl...@chromium.org, Nov 17 2016

Issue description

rundeqp/functional/gles3/shadertexturefunction/texturesize.html and conformance2/textures/misc/tex-mipmap-levels.html started failing on the Linux Release (New Intel) bot.

First failure: https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28New%20Intel%29/builds/3338

Suspect CLs:
ES3 sampler types and their corresponding textures should be initialized before being sampled. https://codereview.chromium.org/2503403003 
Roll WebGL 6b0934a..f1cbc14 https://codereview.chromium.org/2505223002
 
Labels: Hotlist-PixelWrangler

Comment 2 by piman@chromium.org, Nov 17 2016

Owner: zmo@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79d05bf972b24b752029c2d9c727bfe975f2f208

commit 79d05bf972b24b752029c2d9c727bfe975f2f208
Author: zmo <zmo@chromium.org>
Date: Thu Nov 17 21:41:06 2016

Initialize depth texture using tex{Sub}Image2D except for ANGLE ES2

ANGLE_depth_texture does not allow uploading depth texture through tex{Sub}Image2D.

BUG=666384
TEST=Linux Intel bot on GPU FYI
R=jmadill@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2510163003
Cr-Commit-Position: refs/heads/master@{#432970}

[modify] https://crrev.com/79d05bf972b24b752029c2d9c727bfe975f2f208/gpu/command_buffer/service/gles2_cmd_decoder.cc

Cc: yunchao...@intel.com qiankun....@intel.com
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57d88773cae6976332a52f5b7f8dc4ca39016cd2

commit 57d88773cae6976332a52f5b7f8dc4ca39016cd2
Author: qiankun.miao <qiankun.miao@intel.com>
Date: Fri Nov 18 18:46:56 2016

WebGL CTS: suppress failures on Linux Intel

These two failures are related to texturesize function in fragment
shader.

BUG=666384
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2513733004
Cr-Commit-Position: refs/heads/master@{#433255}

[modify] https://crrev.com/57d88773cae6976332a52f5b7f8dc4ca39016cd2/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Status: Assigned (was: Untriaged)

Comment 7 by zmo@chromium.org, Nov 30 2016

A standalone test case is here:

https://github.com/KhronosGroup/WebGL/pull/2175

qiankun: can you file a bug against mesa driver?
Reported this bug to Mesa: https://bugs.freedesktop.org/show_bug.cgi?id=98923
Cc: yang...@intel.com qiankun....@intel.com
Move the failed tests in tex-mipmap-levels.html to conformance2/textures/misc/tex-3d-mipmap-levels-intel-bug.html: https://github.com/KhronosGroup/WebGL/pull/2267.
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/079ae727092a8011d34ddc6cb3feeb7422bc4a6a

commit 079ae727092a8011d34ddc6cb3feeb7422bc4a6a
Author: qiankun.miao <qiankun.miao@intel.com>
Date: Tue Jan 24 18:05:53 2017

Roll WebGL 9b0c9de..3c655cc

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/9b0c9de..3c655cc

BUG=603906, 666384,  678382 ,  673929 ,  682190 ,  684399 

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2649343002
Cr-Commit-Position: refs/heads/master@{#445758}

[modify] https://crrev.com/079ae727092a8011d34ddc6cb3feeb7422bc4a6a/DEPS
[modify] https://crrev.com/079ae727092a8011d34ddc6cb3feeb7422bc4a6a/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/079ae727092a8011d34ddc6cb3feeb7422bc4a6a/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Project Member

Comment 11 by sheriffbot@chromium.org, Jun 7 2017

Labels: Hotlist-Recharge-BouncingOwner
Owner: ----
Status: Untriaged (was: Assigned)
The assigned owner "qiankun.miao@intel.com" is not able to receive e-mails, please re-triage.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 12 by kbr@chromium.org, Jun 7 2017

Cc: -qiankun....@intel.com qkmiao@chromium.org
Status: Available (was: Untriaged)
Components: -Internals>GPU>WebGL Blink>WebGL

Comment 14 by yang...@intel.com, Oct 13 2017

Cc: -qkmiao@chromium.org
I have verified latest Mesa code fixed this issue. According to Mesa bug comments:
It should be fixed by

commit dffda6cbbbc1a8c2f7125db1b9cf15fbcdc8eb11
Author: Jason Ekstrand <jason.ekstrand@intel.com>
Date:   Tue Jun 6 09:58:07 2017 -0700

    i965: Use blorp instead of meta for PBO texture uploads
    
    Reviewed-by: Topi Pohjolainen <topi.pohjolainen@intel.com>
    Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>

or some patch in that series at least.

Comment 15 by kbr@chromium.org, Oct 13 2017

Thanks Yang. Please tell us when this rolls into a Mesa release and we'll upgrade the drivers on our Linux Intel bot.

Comment 16 by yang...@intel.com, Oct 16 2017

The latest Ubuntu 17.04 with Mesa 17.0.7 and latest update at 01.org (https://01.org/linuxgraphics/downloads/intel-graphics-update-tool-linux-os-v2.0.6) with Mesa 17.1.4 don't include the fix. I will give another try with 17.10 which will be released on Oct 19. 

Comment 17 by yang...@intel.com, Oct 19 2017

Unfortunately, Ubuntu 17.10 (with Mesa 17.2.2) doesn't fix the issue. We have to wait for future release (17.3.0 can work well). 
Project Member

Comment 18 by sheriffbot@chromium.org, Oct 19

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Recharge-Cold OS-Fuchsia
Owner: yang...@intel.com
Status: Assigned (was: Untriaged)
deqp/functional/gles3/shadertexturefunction/texturesize.html is still failing on the new Intel HD 630 bot. See:

https://chromium-swarm.appspot.com/task?id=40a5dafc9c325a10&refresh=10&show_raw=1

from this run:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20FYI%20Release%20%28Intel%20HD%20630%29/6566

Several cases fail:

[14320:14320:1019/085847.075050:INFO:CONSOLE(197)] "texture_functions.texturesize.sampler3d_fixed_vertex: Fail: Case 0 Got unexpected texture size", source:  (197)
[14320:14320:1019/085847.076418:INFO:CONSOLE(197)] "Init testcase: texture_functions", source:  (197)
[14320:14320:1019/085847.076909:INFO:CONSOLE(197)] "Init testcase: texture_functions.texturesize.sampler2d_fixed_vertex", source:  (197)
...

On the NVIDIA bot with ANGLE and the passthrough command decoder, some warnings are logged which may give a hint that the test is doing something wrong:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20FYI%20Release%20%28NVIDIA%29/5764

https://chromium-swarm.appspot.com/task?id=40a606e134333e10&refresh=10&show_raw=1

[4671:4671:1019/094646.058122:WARNING:angle_platform_impl.cc(52)] LogGLDebugMessage(158): 
	Source: OpenGL
	Type: Undefined behavior
	ID: 0x00020096
	Severity: Medium
	Message: Program undefined behavior warning: Sampler object 0 is bound to non-depth texture 0, yet it is used with a program that uses a shadow sampler. This is undefined behavior.
...


conformance2/textures/misc/tex-mipmap-levels.html is passing on Linux Intel now with the validating command decoder, but failing with the passthrough command decoder.

Yang, could someone from your team please look into these failures? If the tests are wrong let's fix them. Thanks.

Labels: -Hotlist-PixelWrangler -Hotlist-Recharge-BouncingOwner
Owner: xinghua....@intel.com
1. deqp/functional/gles3/shadertexturefunction/texturesize.html
This issue was fixed on latest mesa driver. I could reproduce this issue on Ubuntu 17.04 with system graphics driver, but could not reproduce this issue on Ubuntu 18.04. It could not been reproduced on Ubuntu 17.04 with latest mesa driver.

2. conformance2/textures/misc/tex-mipmap-levels.html
I run this case on my machine, reports error message as below,
"FAIL getError expected: INVALID_OPERATION. Was NO_ERROR : generateMipmap should fail for zero-size"
And the code is as below,
"
  tex = gl.createTexture();
  gl.bindTexture(gl.TEXTURE_2D, tex);
  gl.texImage2D(gl.TEXTURE_2D, 0, gl.RGBA8, 0, 0, 0, gl.RGBA, gl.UNSIGNED_BYTE, null);
  gl.generateMipmap(gl.TEXTURE_2D);
  wtu.glErrorShouldBe(gl, gl.INVALID_OPERATION, "generateMipmap should fail for zero-size texture");
"
The issue also exists on Nvidia GPU, I check ES 3.0 spec and cannot find where specify to throw an gl.INVALID_OPERATION in this situation.
ANGLE does not throw this error.
I think that case is wrong here.
2. conformance2/textures/misc/tex-mipmap-levels.html
Sorrry, case may not be wrong. I checked WebGL 2.0 spec, it shows "5.41 GenerateMipmap requires positive image dimensions"
But GLES 3.0.5 technically allows calling GenerateMipmap on 0x0 images.
So there is different between WebGL spec and GLES spec.
Blockedon: 898351
Correct - apologies for the confusion. A change was recently made to the WebGL 2.0 spec to forbid mipmap generation for 0x0 textures. We'll have to change Chromium's validation in order to pass the change in this test. See  Issue 898351 .

Blocking: 662644
Labels: webgl-conformance
The zero-size mipmap issue is fixed now, so these tests should all be passing on the latest driver now. Someone should verify, and we should update the driver on the bots.
We have confirmed that following cases still fail under Mesa 17.1.4, which Linux trybot is using, but fixed with Mesa 17.2.3.

deqp/functional/gles3/shadertexturefunction/texturesize.html
conformance2/textures/misc/tex-3d-mipmap-levels-intel-bug.html

Project Member

Comment 29 by bugdroid1@chromium.org, Jan 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f8fb3d2f0f570871e00c9b1ec73caf58401f5df

commit 6f8fb3d2f0f570871e00c9b1ec73caf58401f5df
Author: Lin Sun <lin.sun@intel.com>
Date: Fri Jan 04 04:06:29 2019

Cleaning up WebGL conformance expectations for Linux Intel

Remove intel flag from faiure expectations for fixed cases.
Comment fixed mesa version for Linux driver bugs.

Bug:  483282 , 905006,  686075 , 666384, 905011
Bug:  680276 ,  867675 
Change-Id: Ib54f28397bdd073778bea7294870516bb19d1ce6
Reviewed-on: https://chromium-review.googlesource.com/c/1390765
Commit-Queue: Lin Sun <lin.sun@intel.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619880}
[modify] https://crrev.com/6f8fb3d2f0f570871e00c9b1ec73caf58401f5df/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/6f8fb3d2f0f570871e00c9b1ec73caf58401f5df/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Sign in to add a comment