Umbrella bug to cover building an app that runs properly when the internal provider is compiled out.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf9201e200fcdb2d36f269dc0ddcd1a000265d1b commit bf9201e200fcdb2d36f269dc0ddcd1a000265d1b Author: rohitrao <rohitrao@chromium.org> Date: Thu Nov 17 18:04:58 2016 [ios] Implements more of ChromiumBrowserProvider. BUG= 666375 Review-Url: https://codereview.chromium.org/2507933003 Cr-Commit-Position: refs/heads/master@{#432911} [modify] https://crrev.com/bf9201e200fcdb2d36f269dc0ddcd1a000265d1b/ios/chrome/browser/providers/chromium_browser_provider.h [modify] https://crrev.com/bf9201e200fcdb2d36f269dc0ddcd1a000265d1b/ios/chrome/browser/providers/chromium_browser_provider.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84614a2f295cd7f64a192bf02a4a70a09b4ec5e0 commit 84614a2f295cd7f64a192bf02a4a70a09b4ec5e0 Author: rohitrao <rohitrao@chromium.org> Date: Thu Nov 24 14:57:44 2016 [ios] Implements even more of ChromiumBrowserProvider. Adds an implementation of GetAppDistributionProvider(), as callers expect that method to return a non-NULL object. Adds a call to EnsureBrowserStateKeyedServiceFactoriesBuilt() during startup, as this method call belongs in Chromium and not in the embedder's provider implementation. BUG= 666375 Review-Url: https://codereview.chromium.org/2526043002 Cr-Commit-Position: refs/heads/master@{#434322} [modify] https://crrev.com/84614a2f295cd7f64a192bf02a4a70a09b4ec5e0/ios/chrome/browser/ios_chrome_main_parts.mm [modify] https://crrev.com/84614a2f295cd7f64a192bf02a4a70a09b4ec5e0/ios/chrome/browser/providers/chromium_browser_provider.h [modify] https://crrev.com/84614a2f295cd7f64a192bf02a4a70a09b4ec5e0/ios/chrome/browser/providers/chromium_browser_provider.mm [modify] https://crrev.com/84614a2f295cd7f64a192bf02a4a70a09b4ec5e0/ios/chrome/browser/providers/chromium_voice_search_provider.h [modify] https://crrev.com/84614a2f295cd7f64a192bf02a4a70a09b4ec5e0/ios/chrome/browser/providers/chromium_voice_search_provider.mm
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/f34fca5f8e14ebd611e64a7a0fdd25f192b9b139 commit f34fca5f8e14ebd611e64a7a0fdd25f192b9b139 Author: rohitrao <rohitrao@google.com> Date: Thu Nov 24 16:01:58 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09fd6245fae38d10caa8cff99d777b95f22b909a commit 09fd6245fae38d10caa8cff99d777b95f22b909a Author: rohitrao <rohitrao@chromium.org> Date: Mon Nov 28 14:07:32 2016 [ios] Adds signin resources and styled text fields to ChromiumBrowserProvider. These additions prevent crashes when running the signin tests and when trying to edit a bookmark. BUG= 666375 Review-Url: https://codereview.chromium.org/2529203002 Cr-Commit-Position: refs/heads/master@{#434649} [modify] https://crrev.com/09fd6245fae38d10caa8cff99d777b95f22b909a/ios/chrome/browser/providers/BUILD.gn [modify] https://crrev.com/09fd6245fae38d10caa8cff99d777b95f22b909a/ios/chrome/browser/providers/chromium_browser_provider.h [modify] https://crrev.com/09fd6245fae38d10caa8cff99d777b95f22b909a/ios/chrome/browser/providers/chromium_browser_provider.mm [add] https://crrev.com/09fd6245fae38d10caa8cff99d777b95f22b909a/ios/chrome/browser/providers/signin/BUILD.gn [add] https://crrev.com/09fd6245fae38d10caa8cff99d777b95f22b909a/ios/chrome/browser/providers/signin/chromium_signin_resources_provider.h [add] https://crrev.com/09fd6245fae38d10caa8cff99d777b95f22b909a/ios/chrome/browser/providers/signin/chromium_signin_resources_provider.mm [add] https://crrev.com/09fd6245fae38d10caa8cff99d777b95f22b909a/ios/chrome/browser/providers/ui/BUILD.gn [add] https://crrev.com/09fd6245fae38d10caa8cff99d777b95f22b909a/ios/chrome/browser/providers/ui/chromium_styled_text_field.h [add] https://crrev.com/09fd6245fae38d10caa8cff99d777b95f22b909a/ios/chrome/browser/providers/ui/chromium_styled_text_field.mm
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/878ddb3376df183142a85d40b08b5de93185993c commit 878ddb3376df183142a85d40b08b5de93185993c Author: rohitrao <rohitrao@google.com> Date: Tue Nov 29 00:53:34 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/5c9a67187d5a1a29c4254016f4ea3cf486705815 commit 5c9a67187d5a1a29c4254016f4ea3cf486705815 Author: rohitrao <rohitrao@google.com> Date: Tue Dec 06 03:08:15 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/b4b6a14eb0953f96962671024fe043a6f8e6a074 commit b4b6a14eb0953f96962671024fe043a6f8e6a074 Author: rohitrao <rohitrao@google.com> Date: Tue Dec 06 13:59:58 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f4aa595a1e6d9ba2c93916fb3f79a8adf0c18e4 commit 2f4aa595a1e6d9ba2c93916fb3f79a8adf0c18e4 Author: rohitrao <rohitrao@chromium.org> Date: Thu Dec 15 02:53:24 2016 [ios] Safely handle non-existent plists in OmniboxGeolocationConfig. This CL adds an early return rather than DCHECKing when the plist is missing. BUG= 666375 Review-Url: https://codereview.chromium.org/2551423002 Cr-Commit-Position: refs/heads/master@{#438719} [modify] https://crrev.com/2f4aa595a1e6d9ba2c93916fb3f79a8adf0c18e4/ios/chrome/browser/geolocation/omnibox_geolocation_config.mm
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/ecdf1fd4265bf4802d8373b244c37c0fac8712ab commit ecdf1fd4265bf4802d8373b244c37c0fac8712ab Author: sdefresne <sdefresne@google.com> Date: Fri Dec 16 10:43:17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/737df8713d8ff987eeed283dfc357a616f45ef07 commit 737df8713d8ff987eeed283dfc357a616f45ef07 Author: sdefresne <sdefresne@chromium.org> Date: Fri Dec 16 16:24:57 2016 Remove target that cause ambiguity with downstream targets. BUG= 666375 Review-Url: https://codereview.chromium.org/2582033002 Cr-Commit-Position: refs/heads/master@{#439120} [modify] https://crrev.com/737df8713d8ff987eeed283dfc357a616f45ef07/ios/BUILD.gn [modify] https://crrev.com/737df8713d8ff987eeed283dfc357a616f45ef07/ios/chrome/app/BUILD.gn [delete] https://crrev.com/4b93a7628e18e3c93cce9e0107bbd5573b1c9248/ios/showcase/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1fccb0ab39474f8d297201a443db7d93bba7a9d5 commit 1fccb0ab39474f8d297201a443db7d93bba7a9d5 Author: sdefresne <sdefresne@chromium.org> Date: Mon Dec 19 08:10:53 2016 Add knowledge of EarlGrey test files to PRESUBMIT.py. EarlGrey is the framework used for integration tests on iOS and the corresponding test files are by convention named *_egtest.mm. Add the pattern to PRESUBMIT.py so that no warning is printed if there is code calling test functions in those files. Remove knowledge about KIF test files as this is no longer used. BUG= 666375 Review-Url: https://codereview.chromium.org/2582223002 Cr-Commit-Position: refs/heads/master@{#439432} [modify] https://crrev.com/1fccb0ab39474f8d297201a443db7d93bba7a9d5/PRESUBMIT.py
Comment 1 by bugdroid1@chromium.org
, Nov 17 2016