New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666373 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

PropertyConverter unit tests are leaking (LSAN/ASAN)

Project Member Reported by est...@chromium.org, Nov 17 2016

Issue description

test added in crrev.com/4f5e732f00545db86e

bot: https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/17732

e.g.,
Direct leak of 16 byte(s) in 1 object(s) allocated from:
    #0 0x525afb in operator new(unsigned long) (/b/swarm_slave/w/irUt5llM/out/Release/aura_unittests+0x525afb)
    #1 0x18d240c in aura::PropertyConverter::SetPropertyFromTransportValue(aura::Window*, std::string const&, std::vector<unsigned char, std::allocator<unsigned char> > const*) ui/aura/mus/property_converter.cc:117:48
    #2 0x679d21 in aura::PropertyConverterTest_RectProperty_Test::TestBody() ui/aura/mus/property_converter_unittest.cc:161:22
    #3 0x17c935b in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2458:12
    #4 0x17c935b in testing::Test::Run() testing/gtest/src/gtest.cc:2474
    #5 0x17cb46b in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2656:11
    #6 0x17cc226 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2774:28
    #7 0x17dff96 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4647:43
    #8 0x17df5d7 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2458:12
    #9 0x17df5d7 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4255
    #10 0xc186a8 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2237:46
    #11 0xc186a8 in base::TestSuite::Run() base/test/test_suite.cc:246
    #12 0xc1baba in Run base/callback.h:64:12
    #13 0xc1baba in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, int, int, bool, base::Callback<void (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:211
    #14 0xc1b71e in base::LaunchUnitTests(int, char**, base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:453:10
    #15 0x6d9805 in main ui/aura/test/run_all_unittests.cc:37:10
    #16 0x7f37d10967ec in __libc_start_main /build/eglibc-oqps9y/eglibc-2.15/csu/libc-start.c:226
 

Comment 1 by msw@chromium.org, Nov 17 2016

Status: Started (was: Assigned)
Thanks, I'll get on it.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8235f068aa3a3396085d425908f57789ebcbc910

commit 8235f068aa3a3396085d425908f57789ebcbc910
Author: msw <msw@chromium.org>
Date: Thu Nov 17 22:30:31 2016

Fix PropertyConverter test leak.

Mark test props as window-owned.

BUG= 666373 
TEST=automated
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2511823002
Cr-Commit-Position: refs/heads/master@{#432996}

[modify] https://crrev.com/8235f068aa3a3396085d425908f57789ebcbc910/ui/aura/mus/property_converter_unittest.cc

Comment 3 by msw@chromium.org, Nov 17 2016

Status: Fixed (was: Started)

Comment 4 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 5 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 6 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 7 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 8 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment