The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f99dc049b44da99478c2d714834960a859afbff

commit 8f99dc049b44da99478c2d714834960a859afbff
Author: vasilii <vasilii@chromium.org>
Date: Tue Nov 22 09:43:12 2016

Refactor CredentialManagerImpl::RequireUserMediation method.

CredentialManagerImpl shouldn't use PasswordStore::GetAutofillableLogins. It's not effective. Instead
GetLogins() should be used like in the PasswordFormManager.

BUG= 666340 

Review-Url: https://codereview.chromium.org/2513033002
Cr-Commit-Position: refs/heads/master@{#433826}

[modify] https://crrev.com/8f99dc049b44da99478c2d714834960a859afbff/components/password_manager/content/browser/credential_manager_impl.cc
[modify] https://crrev.com/8f99dc049b44da99478c2d714834960a859afbff/components/password_manager/content/browser/credential_manager_impl.h
[modify] https://crrev.com/8f99dc049b44da99478c2d714834960a859afbff/components/password_manager/core/browser/credential_manager_pending_require_user_mediation_task.cc
[modify] https://crrev.com/8f99dc049b44da99478c2d714834960a859afbff/components/password_manager/core/browser/credential_manager_pending_require_user_mediation_task.h
[modify] https://crrev.com/8f99dc049b44da99478c2d714834960a859afbff/components/password_manager/core/browser/test_password_store.cc
[modify] https://crrev.com/8f99dc049b44da99478c2d714834960a859afbff/ios/chrome/browser/passwords/credential_manager.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abcf35aa714af18959364b626d5929975768f66a

commit abcf35aa714af18959364b626d5929975768f66a
Author: vasilii <vasilii@chromium.org>
Date: Wed Nov 23 11:46:36 2016

Refactor CredentialManagerImpl::Get. It should use PasswordStore::GetLogins().

The PSL matches are filtered out.
The decision to filter the Android federated credentials in PasswordStore was taken in https://codereview.chromium.org/1385563007. It was wrong for the long term.

BUG= 666340 

Review-Url: https://codereview.chromium.org/2517993004
Cr-Commit-Position: refs/heads/master@{#434147}

[modify] https://crrev.com/abcf35aa714af18959364b626d5929975768f66a/components/password_manager/content/browser/credential_manager_impl.cc
[modify] https://crrev.com/abcf35aa714af18959364b626d5929975768f66a/components/password_manager/content/browser/credential_manager_impl.h
[modify] https://crrev.com/abcf35aa714af18959364b626d5929975768f66a/components/password_manager/content/browser/credential_manager_impl_unittest.cc
[modify] https://crrev.com/abcf35aa714af18959364b626d5929975768f66a/components/password_manager/core/browser/credential_manager_pending_request_task.cc
[modify] https://crrev.com/abcf35aa714af18959364b626d5929975768f66a/components/password_manager/core/browser/credential_manager_pending_request_task.h
[modify] https://crrev.com/abcf35aa714af18959364b626d5929975768f66a/components/password_manager/core/browser/form_fetcher_impl_unittest.cc
[modify] https://crrev.com/abcf35aa714af18959364b626d5929975768f66a/components/password_manager/core/browser/password_store.cc
[modify] https://crrev.com/abcf35aa714af18959364b626d5929975768f66a/components/password_manager/core/browser/password_store.h
[modify] https://crrev.com/abcf35aa714af18959364b626d5929975768f66a/components/password_manager/core/browser/password_store_unittest.cc
[modify] https://crrev.com/abcf35aa714af18959364b626d5929975768f66a/ios/chrome/browser/passwords/credential_manager.h
[modify] https://crrev.com/abcf35aa714af18959364b626d5929975768f66a/ios/chrome/browser/passwords/credential_manager.mm
[modify] https://crrev.com/abcf35aa714af18959364b626d5929975768f66a/ios/chrome/browser/passwords/credential_manager_unittest.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47514a069de8bf885e6d0bcdb6585ad69b5cb9ed

commit 47514a069de8bf885e6d0bcdb6585ad69b5cb9ed
Author: vasilii <vasilii@chromium.org>
Date: Thu Nov 24 16:36:06 2016

Show PSL-matched credentials in the account chooser.

They are shown only when there is nothing else to show. PSL matches are never returned without user mediation.

BUG= 666340 

Review-Url: https://codereview.chromium.org/2523593006
Cr-Commit-Position: refs/heads/master@{#434345}

[modify] https://crrev.com/47514a069de8bf885e6d0bcdb6585ad69b5cb9ed/components/password_manager/content/browser/credential_manager_impl_unittest.cc
[modify] https://crrev.com/47514a069de8bf885e6d0bcdb6585ad69b5cb9ed/components/password_manager/core/browser/credential_manager_pending_request_task.cc
[modify] https://crrev.com/47514a069de8bf885e6d0bcdb6585ad69b5cb9ed/components/password_manager/core/browser/test_password_store.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fbb8593200ef0defadc83add39b18d01650b41e

commit 9fbb8593200ef0defadc83add39b18d01650b41e
Author: vasilii <vasilii@chromium.org>
Date: Fri Nov 25 15:29:15 2016

Hide PSL matches in the password bubble after the account chooser.

The PSL matches can be shown in the account chooser. The "Manage passwords" bubble can appear after the dialog was dismissed. It should be empty because the PSL matches aren't saved for the current site.

BUG= 666340 

Review-Url: https://codereview.chromium.org/2529093002
Cr-Commit-Position: refs/heads/master@{#434508}

[modify] https://crrev.com/9fbb8593200ef0defadc83add39b18d01650b41e/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
[modify] https://crrev.com/9fbb8593200ef0defadc83add39b18d01650b41e/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
[modify] https://crrev.com/9fbb8593200ef0defadc83add39b18d01650b41e/chrome/browser/ui/views/passwords/manage_password_items_view.cc

Linux

Deleted: Screenshot from 2016-11-29 15:31:08.png 24.1 KB

	Screenshot from 2016-11-29 15:31:08.png 24.1 KB View Download

Android

Deleted: No_PSL_Match_Android.png 224 KB

	No_PSL_Match_Android.png 224 KB View Download

Deleted: PSL_Match_Android.png 225 KB

	PSL_Match_Android.png 225 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b35160455293212a373c044cf84494ca4ea75d58

commit b35160455293212a373c044cf84494ca4ea75d58
Author: vasilii <vasilii@chromium.org>
Date: Thu Dec 01 15:27:18 2016

Show an info icon with a tooltip for PSL-matches in the account chooser on Views.

The actual icon is taken from LOCATION_BAR_HTTP.

BUG= 666340 

Review-Url: https://codereview.chromium.org/2532313003
Cr-Commit-Position: refs/heads/master@{#435613}

[modify] https://crrev.com/b35160455293212a373c044cf84494ca4ea75d58/chrome/browser/ui/passwords/manage_passwords_view_utils.h
[modify] https://crrev.com/b35160455293212a373c044cf84494ca4ea75d58/chrome/browser/ui/views/passwords/credentials_item_view.cc
[modify] https://crrev.com/b35160455293212a373c044cf84494ca4ea75d58/chrome/browser/ui/views/passwords/credentials_item_view.h

Android Screenshots for Code Review.

Deleted: UI_Spec.png 277 KB

	UI_Spec.png 277 KB View Download

Deleted: LTR_Example.png 216 KB

	LTR_Example.png 216 KB View Download

Deleted: RTL_Example.png 217 KB

	RTL_Example.png 217 KB View Download

Android Screenshots for Code Review.

Deleted: Regular_PSL.png 219 KB

	Regular_PSL.png 219 KB View Download

Deleted: Left_Elide.png 252 KB

	Left_Elide.png 252 KB View Download

Deleted: RTL.png 220 KB

	RTL.png 220 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/875df60ed3a8b3e1dd89043953b3f8aa00cf70d6

commit 875df60ed3a8b3e1dd89043953b3f8aa00cf70d6
Author: jdoerrie <jdoerrie@chromium.org>
Date: Fri Dec 16 14:08:50 2016

Add Information Tooltip for Public Suffix List Matches

Similarly as done for Desktop this change adds an information tooltip for PSL
matches. This tooltip shows the origin URL when tapped on.

BUG= 666340 
R=bauerb@chromium.org,vasilii@chromium.org
CC=vabr@chromium.org,melandory@chromium.org

Review-Url: https://codereview.chromium.org/2541693004
Cr-Commit-Position: refs/heads/master@{#439098}

[add] https://crrev.com/875df60ed3a8b3e1dd89043953b3f8aa00cf70d6/chrome/android/java/res/drawable/material_tooltip_background.xml
[modify] https://crrev.com/875df60ed3a8b3e1dd89043953b3f8aa00cf70d6/chrome/android/java/res/layout/account_chooser_dialog_item.xml
[add] https://crrev.com/875df60ed3a8b3e1dd89043953b3f8aa00cf70d6/chrome/android/java/res/layout/material_tooltip.xml
[modify] https://crrev.com/875df60ed3a8b3e1dd89043953b3f8aa00cf70d6/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/875df60ed3a8b3e1dd89043953b3f8aa00cf70d6/chrome/android/java/src/org/chromium/chrome/browser/password_manager/AccountChooserDialog.java
[modify] https://crrev.com/875df60ed3a8b3e1dd89043953b3f8aa00cf70d6/chrome/android/java/src/org/chromium/chrome/browser/password_manager/Credential.java
[modify] https://crrev.com/875df60ed3a8b3e1dd89043953b3f8aa00cf70d6/chrome/browser/password_manager/credential_android.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2dc41cfe18693c87dfafcb351975be768919ae06

commit 2dc41cfe18693c87dfafcb351975be768919ae06
Author: vasilii <vasilii@chromium.org>
Date: Thu Dec 22 09:40:52 2016

Fix RTL mode for the account picker on Mac.

The avatar icon should be on the right side in the RTL mode.

BUG= 666340 

Review-Url: https://codereview.chromium.org/2590123004
Cr-Commit-Position: refs/heads/master@{#440371}

[modify] https://crrev.com/2dc41cfe18693c87dfafcb351975be768919ae06/chrome/browser/ui/cocoa/passwords/credential_item_button.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05f484a7a00ceeab63c137d3ebf686c57e9ad130

commit 05f484a7a00ceeab63c137d3ebf686c57e9ad130
Author: vasilii <vasilii@chromium.org>
Date: Thu Dec 22 18:23:19 2016

Fix the title alignment for the password bubble on Mac.

It should be right aligned for RTL text. Only two bubbles have a bug - manage passwords and generation confirmation.

BUG= 666340 

Review-Url: https://codereview.chromium.org/2601513003
Cr-Commit-Position: refs/heads/master@{#440452}

[modify] https://crrev.com/05f484a7a00ceeab63c137d3ebf686c57e9ad130/chrome/browser/ui/cocoa/passwords/base_passwords_content_view_controller.mm
[modify] https://crrev.com/05f484a7a00ceeab63c137d3ebf686c57e9ad130/chrome/browser/ui/cocoa/passwords/confirmation_password_saved_view_controller.mm
[modify] https://crrev.com/05f484a7a00ceeab63c137d3ebf686c57e9ad130/chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1e08bf72eed1cf156d0c549e846c899237dee61

commit a1e08bf72eed1cf156d0c549e846c899237dee61
Author: jdoerrie <jdoerrie@chromium.org>
Date: Fri Dec 23 10:09:14 2016

Suppress save and update bubbles when storing a PSL matched credential

The "PSL credentials for YOLO" design doc suggests suppressing the UI prompt
when the user selects a PSL match in the account chooser. This CL implements
this feature and introduces relevant tests.

BUG= 666340 
R=vabr@chromium.org,vasilii@chromium.org

Review-Url: https://codereview.chromium.org/2598003002
Cr-Commit-Position: refs/heads/master@{#440611}

[modify] https://crrev.com/a1e08bf72eed1cf156d0c549e846c899237dee61/chrome/browser/password_manager/credential_manager_browsertest.cc
[modify] https://crrev.com/a1e08bf72eed1cf156d0c549e846c899237dee61/components/password_manager/content/browser/credential_manager_impl.cc
[modify] https://crrev.com/a1e08bf72eed1cf156d0c549e846c899237dee61/components/password_manager/content/browser/credential_manager_impl_unittest.cc

Mac

Deleted: Screen Shot 2016-12-23 at 15.03.42.png 26.6 KB

	Screen Shot 2016-12-23 at 15.03.42.png 26.6 KB View Download

Deleted: Screen Shot 2016-12-23 at 15.04.59.png 27.8 KB

	Screen Shot 2016-12-23 at 15.04.59.png 27.8 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e67335f4b7a36e8e64735e6fb1cf81da6e9376e

commit 0e67335f4b7a36e8e64735e6fb1cf81da6e9376e
Author: vasilii <vasilii@chromium.org>
Date: Fri Dec 23 14:47:54 2016

Show an info icon with a tooltip for PSL-matches in the account chooser on Mac.

The screenshots are attached to the bug.

BUG= 666340 

Review-Url: https://codereview.chromium.org/2601613002
Cr-Commit-Position: refs/heads/master@{#440630}

[modify] https://crrev.com/0e67335f4b7a36e8e64735e6fb1cf81da6e9376e/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm
[modify] https://crrev.com/0e67335f4b7a36e8e64735e6fb1cf81da6e9376e/chrome/browser/ui/cocoa/passwords/credential_item_button.mm

TODO: retrieve federated PSL matches from the password store (https://codereview.chromium.org/2606493002)

Jan, please take the task from the comment #19. It's the last to do for this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e92e9a9d5c688c348a8260c6bcdea2214755014d

commit e92e9a9d5c688c348a8260c6bcdea2214755014d
Author: jdoerrie <jdoerrie@chromium.org>
Date: Thu Jan 19 09:26:44 2017

Fetch federated PSL-matches from the password store.

This change adds the possibility to apply PSL matches to federated logins. In
order to do so it adds a PSL matching helper method and modifies the SQL
statement used.

BUG= 666340 
R=vasilii@chromium.org

Review-Url: https://codereview.chromium.org/2634163002
Cr-Commit-Position: refs/heads/master@{#444689}

[modify] https://crrev.com/e92e9a9d5c688c348a8260c6bcdea2214755014d/components/password_manager/core/browser/login_database.cc
[modify] https://crrev.com/e92e9a9d5c688c348a8260c6bcdea2214755014d/components/password_manager/core/browser/login_database_unittest.cc
[modify] https://crrev.com/e92e9a9d5c688c348a8260c6bcdea2214755014d/components/password_manager/core/browser/psl_matching_helper.cc
[modify] https://crrev.com/e92e9a9d5c688c348a8260c6bcdea2214755014d/components/password_manager/core/browser/psl_matching_helper.h
[modify] https://crrev.com/e92e9a9d5c688c348a8260c6bcdea2214755014d/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb90def05df40c3aebf65c5a65c6376baf779f61

commit bb90def05df40c3aebf65c5a65c6376baf779f61
Author: jdoerrie <jdoerrie@chromium.org>
Date: Fri Jan 27 10:24:20 2017

Implement Federated PSL Matches in Native Backends

In a follow-up to http://crrev.com/2634163002 this change implements the feature
to fetch federated PSL matches in the native backends as well.

BUG= 666340 
R=vasilii@chromium.org

Review-Url: https://codereview.chromium.org/2652243002
Cr-Commit-Position: refs/heads/master@{#446634}

[modify] https://crrev.com/bb90def05df40c3aebf65c5a65c6376baf779f61/chrome/browser/password_manager/native_backend_gnome_x.cc
[modify] https://crrev.com/bb90def05df40c3aebf65c5a65c6376baf779f61/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
[modify] https://crrev.com/bb90def05df40c3aebf65c5a65c6376baf779f61/chrome/browser/password_manager/native_backend_libsecret.cc
[modify] https://crrev.com/bb90def05df40c3aebf65c5a65c6376baf779f61/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
[modify] https://crrev.com/bb90def05df40c3aebf65c5a65c6376baf779f61/components/password_manager/core/browser/login_database.cc
[modify] https://crrev.com/bb90def05df40c3aebf65c5a65c6376baf779f61/components/password_manager/core/browser/psl_matching_helper.cc
[modify] https://crrev.com/bb90def05df40c3aebf65c5a65c6376baf779f61/components/password_manager/core/browser/psl_matching_helper.h
[modify] https://crrev.com/bb90def05df40c3aebf65c5a65c6376baf779f61/components/password_manager/core/browser/psl_matching_helper_unittest.cc

I request merge of r446634 into branch 2987 (M57).

Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aac9e7fe87fc45200239196772588dc99b041cdd

commit aac9e7fe87fc45200239196772588dc99b041cdd
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Fri Jan 27 15:27:37 2017

Implement Federated PSL Matches in Native Backends

In a follow-up to http://crrev.com/2634163002 this change implements the feature
to fetch federated PSL matches in the native backends as well.

BUG= 666340 
R=vasilii@chromium.org

Review-Url: https://codereview.chromium.org/2652243002
Cr-Commit-Position: refs/heads/master@{#446634}
(cherry picked from commit bb90def05df40c3aebf65c5a65c6376baf779f61)

Review-Url: https://codereview.chromium.org/2658093006 .
Cr-Commit-Position: refs/branch-heads/2987@{#144}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/aac9e7fe87fc45200239196772588dc99b041cdd/chrome/browser/password_manager/native_backend_gnome_x.cc
[modify] https://crrev.com/aac9e7fe87fc45200239196772588dc99b041cdd/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
[modify] https://crrev.com/aac9e7fe87fc45200239196772588dc99b041cdd/chrome/browser/password_manager/native_backend_libsecret.cc
[modify] https://crrev.com/aac9e7fe87fc45200239196772588dc99b041cdd/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
[modify] https://crrev.com/aac9e7fe87fc45200239196772588dc99b041cdd/components/password_manager/core/browser/login_database.cc
[modify] https://crrev.com/aac9e7fe87fc45200239196772588dc99b041cdd/components/password_manager/core/browser/psl_matching_helper.cc
[modify] https://crrev.com/aac9e7fe87fc45200239196772588dc99b041cdd/components/password_manager/core/browser/psl_matching_helper.h
[modify] https://crrev.com/aac9e7fe87fc45200239196772588dc99b041cdd/components/password_manager/core/browser/psl_matching_helper_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/514f1d76b3f3340ff16fde2eb75ff485abee776d

commit 514f1d76b3f3340ff16fde2eb75ff485abee776d
Author: jdoerrie <jdoerrie@chromium.org>
Date: Mon Jan 30 16:48:35 2017

Only apply federated matches on HTTPS

Prior to this change federated matches were applied regardless of the scheme.
This change modifies the success condition to that HTTPS is required.

BUG= 666340 
R=vasilii@chromium.org

Review-Url: https://codereview.chromium.org/2664763002
Cr-Commit-Position: refs/heads/master@{#447001}

[modify] https://crrev.com/514f1d76b3f3340ff16fde2eb75ff485abee776d/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
[modify] https://crrev.com/514f1d76b3f3340ff16fde2eb75ff485abee776d/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
[modify] https://crrev.com/514f1d76b3f3340ff16fde2eb75ff485abee776d/components/password_manager/core/browser/psl_matching_helper.cc
[modify] https://crrev.com/514f1d76b3f3340ff16fde2eb75ff485abee776d/components/password_manager/core/browser/psl_matching_helper_unittest.cc