New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666334 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Create an Android backup when a version of Chrome that supports backup is first installed.

Project Member Reported by aber...@chromium.org, Nov 17 2016

Issue description

Chrome, from M55 on, supports Android backups; but new backups are only created when a signin or sync preference changes (which happens rarely). As such, we need to force a new backup when the user first installs a version that supports backups.

It looks as if the simplest way to do this is to add an Android preference that remembers whether Chrome has ever done a backup, and to do a backup on startup if not.
 
Labels: -Pri-3 M-55 Pri-2
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05d89a7436af1e995d74a7ef8fa5a97ed4d8873f

commit 05d89a7436af1e995d74a7ef8fa5a97ed4d8873f
Author: aberent <aberent@chromium.org>
Date: Thu Nov 17 17:48:00 2016

Force first backup

If, at startup, Chrome has never been backed (on Android backup) force
an immediate backup

BUG= 666334 

Review-Url: https://codereview.chromium.org/2508173002
Cr-Commit-Position: refs/heads/master@{#432905}

[modify] https://crrev.com/05d89a7436af1e995d74a7ef8fa5a97ed4d8873f/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupWatcher.java

Labels: Merge-Request-55

Comment 4 by dimu@chromium.org, Nov 17 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)

Comment 5 by ew...@chromium.org, Nov 21 2016

Anthony - since we're not targeting M55 for B&R anymore, this no longer needs to be merged, correct?

Did this make it in time for 56 branch, though?
Labels: -Merge-Approved-55
Yes, it did make M56.  I'm removing the approval, please re-request explicitly and e-mail me if a merge is still required.
Status: Fixed (was: Started)

Sign in to add a comment