MD Bookmarks: Disable 'open in new incognito window' for bookmarks to chrome:// pages |
|||
Issue descriptionVersion: 55.0.2883.54/8872.54.0 Beta-channel Mighty,Daisy,Cyan and Candy OS: Chrome What steps will reproduce the problem? (1)Sign into User -> Go to chrome://settings page and Bookmark it (2)Now go to Bookmark manager (Hit ctrl+shift+O) and right click on settings Bookmark and observe 'Open in Incognito window' option in context menu (Please refer Video) Expected:'Open in Incognito window' option should be disabled in context menu Actual: Instead 'Open in Incognito window' option is seen enabled in context menu of bookmarked Settings page This is Non-Regression Issue seen from M-34 Note: Issue is also seen on Linux and Windows OS
,
Mar 8 2017
This isn't going to change in the old bookmark manager, so repurposing as an MD Bookmarks bug.
,
May 10 2017
I investigated this a little bit yesterday. This works correctly in Native bookmark menus (like the bookmarks bar). The code that powers it is here: https://cs.chromium.org/chromium/src/chrome/browser/ui/browser_navigator.cc?type=cs&l=625 This has an explicit blacklist of chrome:// and chrome-search:// URLs which aren't openable in Incognito. We don't want to reproduce that whole blacklist, the best option is probably to unconditionally block all chrome:// and chrome-search:// URLs from Incognito in the JS front-end. We could potentially also make a new bookmarkManagerPrivate API call to call into that native function with the specific blacklist, but that would add a lot of complexity for little benefit.
,
Sep 8 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by tbuck...@chromium.org
, Jan 19 2017Status: Assigned (was: Untriaged)