New issue
Advanced search Search tips

Issue 666270 link

Starred by 6 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

ChromeOS 3 finger gestures makes the first tab open when in full screen mode

Reported by miketin...@gmail.com, Nov 17 2016

Issue description

UserAgent: Mozilla/5.0 (X11; CrOS x86_64 8872.44.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.42 Safari/537.36
Platform: 8872.44.0 (Official Build) beta-channel samus

Steps to reproduce the problem:
1. Open multiple tabs (>=2) 
2. Maximise the screen (F4/maximise function key)
3. Use either the 3 finger swipe up to bring the address bar down, or a 3 finger slide to change tab
4. The first/leftmost tab will open regardless of which tab you had open

What is the expected behavior?
A small 3 finger swipe down should bring the address bar down.
A 3 finger slide should select the tab to the left or right depending on the users gesture

What went wrong?
N/A

Did this work before? Yes ChromeOS 54

Chrome version: 55.0.2883.42  Channel: beta
OS Version: 8872.44.0
Flash Version: Shockwave Flash 23.0 r0
 
Owner: afakhry@chromium.org
Status: Assigned (was: Unconfirmed)
@afakhry, could you help triage?
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd5f0695c7ad98bbec8accb74a26d30f345dd3bc

commit bd5f0695c7ad98bbec8accb74a26d30f345dd3bc
Author: afakhry <afakhry@chromium.org>
Date: Mon Feb 06 22:44:16 2017

Fix the TabScrubber always starting from the first tab in full screen mode.

The unrevealed fullscreened-browser's top view used to have the wrong bounds.
That was fixed in the CL: https://codereview.chromium.org/2640433004/. This CL
adds a test to prevent regressions.

BUG= 666270 
TEST=interactive_ui_tests --gtest_filter=TabScrubberTest.FullScreenBrowser

Review-Url: https://codereview.chromium.org/2656983005
Cr-Commit-Position: refs/heads/master@{#448421}

[modify] https://crrev.com/bd5f0695c7ad98bbec8accb74a26d30f345dd3bc/chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc
[modify] https://crrev.com/bd5f0695c7ad98bbec8accb74a26d30f345dd3bc/chrome/browser/ui/views/frame/immersive_mode_controller.h
[modify] https://crrev.com/bd5f0695c7ad98bbec8accb74a26d30f345dd3bc/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
 Issue 675277  has been merged into this issue.
Cc: afakhry@chromium.org
Issue 717007 has been merged into this issue.

Sign in to add a comment