Issue metadata
Sign in to add a comment
|
Regression : Unnecessarily hover effect is seen in omnibox even when the 'Zoom' icon is not present.
Reported by
yfulgaon...@etouch.net,
Nov 17 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version : 56.0.2923.0 (Official Build) 455f3cce3da21f8e677100b0c0abd8d35e24876e-refs/heads/master@{#432704} 64-bit OS : Mac(10.11.6, 10.12.1, 10.12) What steps will reproduce the problem? 1. Launch chrome, open NTP and hit ‘Cmd ++’ to zoom in the page. 2. Click on ‘Zoom’ icon in omnibox and click on ‘Reset’ (‘zoom’ icon disappears from omnibox). 3. Now immediately hover on the left side of ‘Bookmark’ icon in omnibox and observe the hover effect. (Please review an attached screen cast) Actual : Unnecessarily hover effect is seen on mouse hover even when ‘zoom’ icon is not there in omnibox. Expected : Hover effect should not be seen when the ‘zoom’ icon is not there in omnibox. This is a regression issue broken in ‘M-56’, below is the Manual Regression range and will soon update other info. Good Build : 56.0.2919.0 Bad Build : 56.0.2920.0 Note : This is Mac specific issue and the same is working fine on Windows & Linux OS.
,
Nov 22 2016
Can confirm that this is caused by my change. The zoom decoration shouldn't be there in the first place, looks like my change exposes that
,
Jan 2 2017
Just to update on the issue, still able to reproduce this issue on Mac 10.12.2 using latest canary #57.0.2969.0. spqchan@ - Gentle Ping...!! Could you please have a look into this issue. Thanks...!!
,
Jan 3 2017
,
Jan 3 2017
FYI: Your bug is labelled as Stable Release Block, please make sure to land the fix and get it merged into the release branch ASAP so we can take it for next week's Beta release for Desktop. Thank you!
,
Jan 4 2017
Able to reproduce the issue on Mac 10.12.1 using chrome version 57.0.2971.0. spqchan@ Please look into this stable blocker issue. Thanks,
,
Jan 10 2017
Still able to reproduce this issue on Mac 10.12.2 using latest canary #57.0.2977.0. spqchan@ - Could you please have a look into this issue as it has been marked as release block stable. Thanks...!!
,
Jan 10 2017
Since this is a minor UI bug , punting to M57 and reducing the priority.
,
Jan 10 2017
,
Jan 11 2017
The issue is happening because the decoration is still there when the zoom is set to the default. It just doesn't have a vector icon, since there's no MD icon for the default zoom. I'm going to fix this by hiding the Zoom UI when it's set to the default zoom, similar to the tooltip's behavior. Adding shrike@ since he had worked on the zoom decoration
,
Jan 13 2017
,
Jan 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5a7a73975d123369dab9784b2897467a31b0ab8 commit d5a7a73975d123369dab9784b2897467a31b0ab8 Author: spqchan <spqchan@chromium.org> Date: Fri Jan 13 22:13:39 2017 [Mac] Hide Zoom Decoration for Default Zoom The new zoom decoration has no icon for the default zoom setting. As a result, it should be set as invisible when the zoom is at the default value. BUG= 666266 Review-Url: https://codereview.chromium.org/2628703002 Cr-Commit-Position: refs/heads/master@{#443694} [modify] https://crrev.com/d5a7a73975d123369dab9784b2897467a31b0ab8/chrome/browser/ui/cocoa/location_bar/zoom_decoration.h [modify] https://crrev.com/d5a7a73975d123369dab9784b2897467a31b0ab8/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm [modify] https://crrev.com/d5a7a73975d123369dab9784b2897467a31b0ab8/chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm [modify] https://crrev.com/d5a7a73975d123369dab9784b2897467a31b0ab8/chrome/browser/ui/cocoa/location_bar/zoom_decoration_unittest.mm
,
Jan 17 2017
Verified on Mac OS 10.12.2 using chrome dev M57 #57.0.2984.0 and issue is fixed. Hover effect is not seen when the ‘zoom’ icon is not there in omnibox. Attaching screencast for reference. Adding TE-Verified Labels. Thanks!
,
Jan 17 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by jmukthavaram@chromium.org
, Nov 17 2016Labels: hasbisect-per-revision
Owner: spqc...@chromium.org
Status: Assigned (was: Unconfirmed)