New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666266 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Unnecessarily hover effect is seen in omnibox even when the 'Zoom' icon is not present.

Reported by yfulgaon...@etouch.net, Nov 17 2016

Issue description

Chrome Version : 56.0.2923.0 (Official Build) 455f3cce3da21f8e677100b0c0abd8d35e24876e-refs/heads/master@{#432704} 64-bit
OS : Mac(10.11.6, 10.12.1, 10.12)

What steps will reproduce the problem?
1. Launch chrome, open NTP and hit ‘Cmd ++’ to zoom in the page.
2. Click on ‘Zoom’ icon in omnibox and click on ‘Reset’ (‘zoom’ icon disappears from omnibox).
3. Now immediately hover on the left side of ‘Bookmark’ icon in omnibox and observe the hover effect. (Please review an attached screen cast)

Actual : Unnecessarily hover effect is seen on mouse hover even when ‘zoom’ icon is not there in omnibox.
Expected : Hover effect should not be seen when the ‘zoom’ icon is not there in omnibox.

This is a regression issue broken in ‘M-56’, below is the Manual Regression range and will soon update other info.
Good Build : 56.0.2919.0
Bad Build : 56.0.2920.0

Note : This is Mac specific issue and the same is working fine on Windows & Linux OS.

 
Act_Exp_Zoom.png
27.0 KB View Download
Actual_Zoom_HoverEffect.mov
3.9 MB Download
Expected_zoom_HoverEffect.mov
4.9 MB Download
Cc: jmukthavaram@chromium.org
Labels: hasbisect-per-revision
Owner: spqc...@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on  Mac 10.11.6 using chrome latest canary  56.0.2923.0.

Please find the bisect information as below

Narrow Bisect::

Good Build : 56.0.2919.0—431801

Bad Build : 56.0.2920.0—432057

You are probably looking for a change made after 431907 (known good), but no later than 431908 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspectas some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/97bd029159326fcd0792045a451b99cf9b20c913..2edc6f9145d91684f2151462fa20873c29b87b62

Possible suspect::
https://chromium.googlesource.com/chromium/src/+/2edc6f9145d91684f2151462fa20873c29b87b62

spqchan@ could you please look into this issue if it is related to your change,else please route this to an appropriate dev person.

Thanks,
Can confirm that this is caused by my change. The zoom decoration shouldn't be there in the first place, looks like my change exposes that
Just to update on the issue, still able to reproduce this issue on Mac 10.12.2 using latest canary #57.0.2969.0.

spqchan@ - Gentle Ping...!!

Could you please have a look into this issue.

Thanks...!!
Labels: ReleaseBlock-Stable
FYI: Your bug is labelled as Stable Release Block, please make sure to land the fix and get it merged into the release branch ASAP so we can take it for next week's Beta release for Desktop. Thank you!
Able to reproduce the issue on Mac 10.12.1 using chrome version 57.0.2971.0.

spqchan@ Please look into this stable blocker issue.

Thanks,
Still able to reproduce this issue on Mac 10.12.2 using latest canary #57.0.2977.0.

spqchan@ - Could you please have a look into this issue as it has been marked as release block stable.

Thanks...!!
Labels: -Pri-1 -M-56 M-57 Pri-2
Since this is a minor UI bug , punting to M57 and reducing the priority.
Status: Started (was: Assigned)
Cc: shrike@chromium.org
The issue is happening because the decoration is still there when the zoom is set to the default. It just doesn't have a vector icon, since there's no MD icon for the default zoom. 

I'm going to fix this by hiding the Zoom UI when it's set to the default zoom, similar to the tooltip's behavior. Adding shrike@ since he had worked on the zoom decoration
Labels: TE-Verified-57.0.2984.0 TE-Verified-M57
Verified on Mac OS 10.12.2 using chrome dev M57 #57.0.2984.0 and issue is fixed.

Hover effect is not seen when the ‘zoom’ icon is not there in omnibox.

Attaching screencast for reference.

Adding TE-Verified Labels.

Thanks!


666266.mp4
709 KB View Download
Status: Fixed (was: Started)

Sign in to add a comment