Desktop shortcut doesn't disappear even after disabling 'show desktop shortcut' option.
Reported by
jshan...@etouch.net,
Nov 17 2016
|
||||
Issue descriptionChrome Version: 56.0.2922.0 (Official Build) 4793d9335b9ce611e2deb40863793fa785773200-refs/heads/master@{#432511} (32/64 Bit) OS:Windows (7,8,10) What steps will reproduce the problem? (1)Launch chrome and navigate to chrome://md-settings/ (2)Click on profile icon and click on 'show desktop shortcut' button,observe the desktop. (3)Now again click on 'show desktop shortcut' button to disable and press 'F5' to refresh the desktop,observe. Actual: Desktop shortcut doesn't disappear even after disabling 'show desktop shortcut' option. Expected: Desktop shorcut should diappear after disabling 'show desktop shortcut' option. This is a Non-Regression issue seen from 'M56' series i.e. from chrome version 56.0.2922.0 Note: Issue not seen on Mac & Linux OS.
,
Nov 21 2016
pretty sure this was fixed recently, please try on canary
,
Nov 22 2016
I tested this on my shiny new Windows machine, and can confirm there is a problem. For the single-profile case, the Profile Icons don't work right, and the control is hidden in Old Options: https://codesearch.chromium.org/chromium/src/chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc?sq=package:chromium&l=191 We need to add some code to hide the control for the single-profile case in MD Settings too. I'll take care of this and get it merged into 56.
,
Nov 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8171ffd98a17ea9944d346994065b9e8050ca183 commit 8171ffd98a17ea9944d346994065b9e8050ca183 Author: tommycli <tommycli@chromium.org> Date: Wed Nov 23 23:44:21 2016 MD Settings: Hide Profile Shortcut switch for single-profile machines. The Profile Shortcut switch should be hidden for single-profile machines. This is a regression from Old Options. BUG= 666264 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2525783002 Cr-Commit-Position: refs/heads/master@{#434280} [modify] https://crrev.com/8171ffd98a17ea9944d346994065b9e8050ca183/chrome/browser/resources/settings/people_page/manage_profile.html [modify] https://crrev.com/8171ffd98a17ea9944d346994065b9e8050ca183/chrome/browser/resources/settings/people_page/manage_profile.js [modify] https://crrev.com/8171ffd98a17ea9944d346994065b9e8050ca183/chrome/browser/resources/settings/people_page/manage_profile_browser_proxy.js [modify] https://crrev.com/8171ffd98a17ea9944d346994065b9e8050ca183/chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc [modify] https://crrev.com/8171ffd98a17ea9944d346994065b9e8050ca183/chrome/browser/ui/webui/settings/settings_manage_profile_handler.h [modify] https://crrev.com/8171ffd98a17ea9944d346994065b9e8050ca183/chrome/test/data/webui/settings/people_page_manage_profile_test.js
,
Nov 23 2016
Fixed. Please verify on Monday's Canary. We decided we don't need to merge this to 56. It's a P3. |
||||
►
Sign in to add a comment |
||||
Comment 1 by msrchandra@chromium.org
, Nov 17 2016Status: Untriaged (was: Unconfirmed)