New issue
Advanced search Search tips

Issue 666231 link

Starred by 1 user
Status: Verified
Owner:
nya@chromium.org
Closed: Dec 2016
Cc:
yusukes@chromium.org
hashimoto@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

arc: Move file system related IPC methods from intent_helper.mojom to file_system.mojom

Project Member Reported by nya@chromium.org, Nov 17 2016 
Recently several new file system related IPC methods were introduced for content: URL support ( crbug.com/654684 ). Unfortunately, they were put in intent_helper.mojom (kitchen sink) rather than file_system.mojom for some reasons.

I'm planning to add more file system related methods to file_system.mojom, and it would be odd if several related methods were still in intent_helper.mojom. Let's move them to file_system.mojom.

Comment 1 by nya@chromium.org, Nov 17 2016

Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b3835940eb71e1e9b3bfe2a7f60f381bcf63238

commit 9b3835940eb71e1e9b3bfe2a7f60f381bcf63238
Author: nya <nya@chromium.org>
Date: Mon Nov 28 04:36:17 2016

Move FS related mojo methods to ArcFileSystemInstance.

Existing methods are suffixed with "Deprecated". Note that
new methods will be soon implemented in Android side but
they are not available at this moment.

BUG= chromium:666231 
TEST=unit_tests --gtest_filter='ArcContentFileSystem*'

Review-Url: https://codereview.chromium.org/2505993005
Cr-Commit-Position: refs/heads/master@{#434603}

[modify] https://crrev.com/9b3835940eb71e1e9b3bfe2a7f60f381bcf63238/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_async_file_util_unittest.cc
[modify] https://crrev.com/9b3835940eb71e1e9b3bfe2a7f60f381bcf63238/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader_unittest.cc
[modify] https://crrev.com/9b3835940eb71e1e9b3bfe2a7f60f381bcf63238/chrome/browser/chromeos/arc/fileapi/intent_helper_util.cc
[modify] https://crrev.com/9b3835940eb71e1e9b3bfe2a7f60f381bcf63238/chrome/browser/chromeos/arc/fileapi/intent_helper_util.h
[modify] https://crrev.com/9b3835940eb71e1e9b3bfe2a7f60f381bcf63238/components/arc/common/file_system.mojom
[modify] https://crrev.com/9b3835940eb71e1e9b3bfe2a7f60f381bcf63238/components/arc/common/intent_helper.mojom
[modify] https://crrev.com/9b3835940eb71e1e9b3bfe2a7f60f381bcf63238/components/arc/test/fake_intent_helper_instance.cc
[modify] https://crrev.com/9b3835940eb71e1e9b3bfe2a7f60f381bcf63238/components/arc/test/fake_intent_helper_instance.h
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cf19023ea53f77727741812143b7306bfed94be

commit 3cf19023ea53f77727741812143b7306bfed94be
Author: nya <nya@chromium.org>
Date: Wed Nov 30 08:20:01 2016

Use ArcFileSystemInstance to access files on ARC.

No functionality should change.

BUG= chromium:666231 
TEST=unit_tests --gtest_filter='ArcContentFileSystem*'
TEST=Open a PDF file from Android storage viewer.

Review-Url: https://codereview.chromium.org/2511973003
Cr-Commit-Position: refs/heads/master@{#435161}

[modify] https://crrev.com/3cf19023ea53f77727741812143b7306bfed94be/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/3cf19023ea53f77727741812143b7306bfed94be/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_async_file_util.cc
[modify] https://crrev.com/3cf19023ea53f77727741812143b7306bfed94be/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_async_file_util_unittest.cc
[modify] https://crrev.com/3cf19023ea53f77727741812143b7306bfed94be/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader.cc
[modify] https://crrev.com/3cf19023ea53f77727741812143b7306bfed94be/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader_unittest.cc
[rename] https://crrev.com/3cf19023ea53f77727741812143b7306bfed94be/chrome/browser/chromeos/arc/fileapi/arc_file_system_instance_util.cc
[add] https://crrev.com/3cf19023ea53f77727741812143b7306bfed94be/chrome/browser/chromeos/arc/fileapi/arc_file_system_instance_util.h
[delete] https://crrev.com/19411d493637cf2a9efb1d0ede01968458f5ffb2/chrome/browser/chromeos/arc/fileapi/intent_helper_util.h
[modify] https://crrev.com/3cf19023ea53f77727741812143b7306bfed94be/components/arc/BUILD.gn
[add] https://crrev.com/3cf19023ea53f77727741812143b7306bfed94be/components/arc/test/fake_file_system_instance.cc
[add] https://crrev.com/3cf19023ea53f77727741812143b7306bfed94be/components/arc/test/fake_file_system_instance.h

Comment 4 by nya@chromium.org, Dec 2 2016

Status: Fixed (was: Started)

Comment 5 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 6 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 7 by sdantul...@chromium.org, May 8 2017

Labels: code-change
Status: Verified (was: Fixed)
►

Sign in to add a comment