Reupload

Deleted: correct.png 7.1 KB

	correct.png 7.1 KB View Download

Tested in chrome stable #54.0.2840.98 and canary #56.0.2924.0 on Mac 10.11.6 & Retina 10.12.1 and not able to reproduce the issue.Please find the screen shots for your reference.

@ alexandermeissner:

Could you please let me know if i have missed anything and if possible, provide us with a sample test cases / URL of the issue which would help us to triage the issue further.

Thanks in Advance.

Deleted: 666228.png 106 KB

	666228.png 106 KB View Download

I just figured out that it only happens when running from a command line (not when started by using the Finder GUI).

Might be related to the last bug I reported, which also only occurred on the command line as it was connected to the locale settings swapping '.' and ',' in float serialization (just an idea, no other evidence): 
https://bugs.chromium.org/p/v8/issues/detail?id=5551

Google Chrome	56.0.2924.0 (Offizieller Build) canary (64-Bit)
Überarbeitung	3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Betriebssystem	Mac OS X 
JavaScript	V8 5.6.329
Flash		24.0.0.154
User-Agent	Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.0 Safari/537.36
/Applications/Developer/Google Chrome Canary.app/Contents/MacOS/Google Chrome Canary --flag-switches-begin --flag-switches-end

@rbasuvula:

My suspicion is true, changing the environment variables related to the locale changes the occurrence of this issue.

# Everything is alright
export LC_ALL=en_US.UTF-8
export LANG=en_US.UTF-8
export LANGUAGE=en_US.UTF-8

# Bug occurs
export LC_ALL=de_DE.UTF-8
export LANG=de_DE.UTF-8
export LANGUAGE=de_DE.UTF-8

I think this is caused by the localization of floats to strings, like described here:
http://stackoverflow.com/questions/27245824/float-to-stdstring-conversion-and-localization

As this is the same cause as the last bug I reported, it seems to me, that this issue is spread over the entire code and could be hidden in more places.

Thank you for providing more feedback. Adding requester "rbasuvula@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Tested as per comment #4 in latest chrome canary #57.0.2938.0 on Mac 10.11.6 & Retina 10.12.1 and not able to reproduce the issue.Please find the screen shot for reference.

@ alexandermeissner:

Could you please let me know if i have missed anything. Please upgrade to latest version of chrome #57.0.2938.0 and create new profile without extensions, Recheck once and let us know the observation.Which would help us to triage the issue further.

Thanks in Advance.

Deleted: 666228.png 122 KB

	666228.png 122 KB View Download

You have to run it from a command line.
This is with all options completely reset:

Deleted: Bildschirmfoto 2016-12-01 um 14.06.37.png 646 KB

	Bildschirmfoto 2016-12-01 um 14.06.37.png 646 KB View Download

So interestingly, this isn't impacted by the system locale, so somehow the:

export LC_ALL=de_DE.UTF-8
export LANG=de_DE.UTF-8
export LANGUAGE=de_DE.UTF-8

does more than the OS does when the user changes languages in system preferences.

It seems like the minimum change necessary to get the issue is:

export LC_NUMERIC=de_DE.UTF-8

Now it got even worse,
crashing the entire tab when trying to render the filter.

bsalomon@, it appears that certain system language modifications can lead to Ganesh shader generation failures (if floats are printed with a "," separator rather than a "."). It seems like Skia should probably print shaders in a way that isn't impacted by these settings? WDYT?

Definitely

The following revision refers to this bug:
  https://skia.googlesource.com/skia.git/+/4d5e65d19a82bf993e95f9986ce1d2b84cf22ff7

commit 4d5e65d19a82bf993e95f9986ce1d2b84cf22ff7
Author: Brian Salomon <bsalomon@google.com>
Date: Thu Jan 05 15:37:24 2017

Use nullptr to indicate C locale when using xlocale

BUG= chromium:666228 

Change-Id: I951102eba2b79ddaa5eb134834471a4a3ec8aed7
Reviewed-on: https://skia-review.googlesource.com/6603
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>

[modify] https://crrev.com/4d5e65d19a82bf993e95f9986ce1d2b84cf22ff7/src/gpu/GrAutoLocaleSetter.h

I believe this is now fixed. There was an issue where we weren't setting the "C" locale correctly on Mac before generating shader code.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66899c8261aba2b41c40fa91396fdd249a247e0d

commit 66899c8261aba2b41c40fa91396fdd249a247e0d
Author: skia-deps-roller <skia-deps-roller@chromium.org>
Date: Thu Jan 05 19:26:43 2017

Roll src/third_party/skia/ ac1f09d53..08d57e6ae (5 commits).

https://skia.googlesource.com/skia.git/+log/ac1f09d53bfe..08d57e6ae651

$ git log ac1f09d53..08d57e6ae --date=short --no-merges --format='%ad %ae %s'
2017-01-05 fmalita Remove SK_SUPPORT_LEGACY_EVAL_CUBIC-guarded code
2017-01-05 bsalomon Use nullptr to indicate C locale when using xlocale
2017-01-05 djsollen Add tools to support gdb and simpleperf for android executables.
2017-01-05 benjaminwagner Remove Perf-Android-Clang-NexusPlayer-CPU-Moorefield-x86-Release-Android.
2017-01-05 mtklein GN: add test_app template

BUG= 666228 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=csmartdalton@google.com

Review-Url: https://codereview.chromium.org/2615893002
Cr-Commit-Position: refs/heads/master@{#441725}

[modify] https://crrev.com/66899c8261aba2b41c40fa91396fdd249a247e0d/DEPS