New issue
Advanced search Search tips

Issue 666223 link

Starred by 1 user
Status: Fixed
Owner:
yangguo@chromium.org
Closed: Dec 2016
Cc:
machenb...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Function source of JS builtins in C++ installed by blink are bogus.

Project Member Reported by yangguo@chromium.org, Nov 17 2016 
The function source returned by v8::internal::JSFunction::ToString for builtins installed by blink have been "function () {}" until now, since they use the internal empty function. The script is marked as native, but not as hidden, so we don't end up with "function () { [native code] }". Now that we are refactoring this [0] and removing the "hidden" flag, this will change.

Affected tests are:

fast/workers/constructor-proto.html
http/tests/w3c/webperf/approved/navigation-timing/html/idlharness.html
imported/wpt/WebIDL/ecmascript-binding/es-exceptions/constructor-object.html
imported/wpt/dom/interfaces.html
inspector/sources/debugger-ui/watch-expressions-preserve-expansion.html
virtual/sharedarraybuffer/fast/workers/constructor-proto.html

[0] https://codereview.chromium.org/2505853003/
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8ad7835b9311d05d39a66c121cb9300e8121ee0

commit e8ad7835b9311d05d39a66c121cb9300e8121ee0
Author: yangguo <yangguo@chromium.org>
Date: Thu Nov 17 08:53:42 2016

LayoutTests: prepare test expectations for V8 change.

Function source of built-in functions implemented in C++ and installed
by blink will switch from "function() {}" to "function() { [native code] }".
The latter is in line with C++ built-ins installed by V8 itself.

R=machenbach@chromium.org
BUG= 666223 
NOTRY=true

Review-Url: https://codereview.chromium.org/2510823004
Cr-Commit-Position: refs/heads/master@{#432819}

[modify] https://crrev.com/e8ad7835b9311d05d39a66c121cb9300e8121ee0/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d280c8b299474080baefe4219718b1cdfd2f3503

commit d280c8b299474080baefe4219718b1cdfd2f3503
Author: yangguo <yangguo@chromium.org>
Date: Wed Dec 21 14:37:48 2016

LayoutTests: mark tests affected by recent V8 changes for rebaseline.

R=machenbach@chromium.org
BUG= 666223 

Review-Url: https://codereview.chromium.org/2589193004
Cr-Commit-Position: refs/heads/master@{#440095}

[modify] https://crrev.com/d280c8b299474080baefe4219718b1cdfd2f3503/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2bbdf76a5337ed29786760244daed3ac76c56b4

commit a2bbdf76a5337ed29786760244daed3ac76c56b4
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Wed Dec 21 19:49:19 2016

Auto-rebaseline for r440095

https://chromium.googlesource.com/chromium/src/+/d280c8b299474

BUG= 666223 
TBR=yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2591293002 .
Cr-Commit-Position: refs/heads/master@{#440188}

[modify] https://crrev.com/a2bbdf76a5337ed29786760244daed3ac76c56b4/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/a2bbdf76a5337ed29786760244daed3ac76c56b4/third_party/WebKit/LayoutTests/fast/workers/constructor-proto-expected.txt
[modify] https://crrev.com/a2bbdf76a5337ed29786760244daed3ac76c56b4/third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/idlharness-expected.txt
[modify] https://crrev.com/a2bbdf76a5337ed29786760244daed3ac76c56b4/third_party/WebKit/LayoutTests/imported/wpt/WebIDL/ecmascript-binding/es-exceptions/constructor-object-expected.txt
[modify] https://crrev.com/a2bbdf76a5337ed29786760244daed3ac76c56b4/third_party/WebKit/LayoutTests/imported/wpt/dom/interfaces-expected.txt
[modify] https://crrev.com/a2bbdf76a5337ed29786760244daed3ac76c56b4/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-preserve-expansion-expected.txt

Comment 4 by yangguo@chromium.org, Dec 22 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment