Dispatch it on the following events instead: - OnResponseStarted - OnRequestRedirected - OnCompletedRequest https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaGFQ/edit#heading=h.cq4slq8hi7q7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab7cdd7f214d3a625ab737dc17b977c89021d786 commit ab7cdd7f214d3a625ab737dc17b977c89021d786 Author: yhirano <yhirano@chromium.org> Date: Tue Nov 29 03:50:22 2016 Remove ResourceLoaderInfo::encodedDataLength It is redundant as we have the field in ResourceResponse. BUG= 666217 Review-Url: https://codereview.chromium.org/2521483002 Cr-Commit-Position: refs/heads/master@{#434875} [modify] https://crrev.com/ab7cdd7f214d3a625ab737dc17b977c89021d786/content/child/web_url_loader_impl.cc [modify] https://crrev.com/ab7cdd7f214d3a625ab737dc17b977c89021d786/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp [modify] https://crrev.com/ab7cdd7f214d3a625ab737dc17b977c89021d786/third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp [modify] https://crrev.com/ab7cdd7f214d3a625ab737dc17b977c89021d786/third_party/WebKit/Source/platform/exported/WebHTTPLoadInfo.cpp [modify] https://crrev.com/ab7cdd7f214d3a625ab737dc17b977c89021d786/third_party/WebKit/Source/platform/network/ResourceLoadInfo.h [modify] https://crrev.com/ab7cdd7f214d3a625ab737dc17b977c89021d786/third_party/WebKit/public/platform/WebHTTPLoadInfo.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48f3e047d17e5f78543bb0bec1c421ba3a69cb79 commit 48f3e047d17e5f78543bb0bec1c421ba3a69cb79 Author: yhirano <yhirano@chromium.org> Date: Fri Dec 09 02:19:17 2016 Dispatch encoded_data_length separately in content/child This CL removes dispatching encoded_data_length from RequestPeer::ReceivedData. Instead, it is dispatched via RequestPeer::OnTransferSizeUpdated. BUG= 666217 Review-Url: https://codereview.chromium.org/2540023003 Cr-Commit-Position: refs/heads/master@{#437433} [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/chrome/renderer/extensions/extension_localization_peer.cc [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/chrome/renderer/extensions/extension_localization_peer.h [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/chrome/renderer/extensions/extension_localization_peer_unittest.cc [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/chrome/renderer/security_filter_peer.cc [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/chrome/renderer/security_filter_peer.h [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/content/child/ftp_directory_listing_response_delegate.cc [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/content/child/resource_dispatcher.cc [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/content/child/resource_dispatcher_unittest.cc [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/content/child/shared_memory_data_consumer_handle.cc [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/content/child/shared_memory_data_consumer_handle_unittest.cc [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/content/child/shared_memory_received_data_factory.cc [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/content/child/shared_memory_received_data_factory.h [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/content/child/shared_memory_received_data_factory_unittest.cc [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/content/child/url_response_body_consumer.cc [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/content/child/url_response_body_consumer_unittest.cc [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/content/child/web_url_loader_impl.cc [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/content/child/web_url_loader_impl_unittest.cc [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/content/public/child/fixed_received_data.cc [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/content/public/child/fixed_received_data.h [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/content/public/child/request_peer.h [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/content/renderer/fetchers/resource_fetcher_impl.cc [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/third_party/WebKit/LayoutTests/http/tests/inspector/tracing/resources/anImage.png [add] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/third_party/WebKit/LayoutTests/http/tests/inspector/tracing/resources/anotherImage.png [rename] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/third_party/WebKit/LayoutTests/http/tests/inspector/tracing/resources/timeline-network-resource.js [rename] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/third_party/WebKit/LayoutTests/http/tests/inspector/tracing/timeline-network-received-data-expected.txt [rename] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/third_party/WebKit/LayoutTests/http/tests/inspector/tracing/timeline-network-received-data.html [rename] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/third_party/WebKit/LayoutTests/http/tests/inspector/tracing/timeline-receive-response-event-expected.txt [rename] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/third_party/WebKit/LayoutTests/http/tests/inspector/tracing/timeline-receive-response-event.html [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details.html [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-expected.txt [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource.html [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/third_party/WebKit/Source/core/fetch/ResourceFetcher.h [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/third_party/WebKit/Source/core/fetch/ResourceLoader.h [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/third_party/WebKit/Source/core/loader/PingLoader.cpp [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/third_party/WebKit/Source/platform/exported/WebURLLoaderTestDelegate.cpp [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/third_party/WebKit/Source/platform/testing/weburl_loader_mock.cc [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/third_party/WebKit/Source/web/tests/DocumentLoaderTest.cpp [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/third_party/WebKit/Source/web/tests/WebFrameTest.cpp [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/third_party/WebKit/Source/web/tests/sim/SimNetwork.cpp [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/third_party/WebKit/Source/web/tests/sim/SimNetwork.h [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/third_party/WebKit/Source/web/tests/sim/SimRequest.cpp [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/third_party/WebKit/public/platform/WebURLLoaderClient.h [modify] https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79/third_party/WebKit/public/platform/WebURLLoaderTestDelegate.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4abbfe190c2692147bcea746c5cadc3d13b979a8 commit 4abbfe190c2692147bcea746c5cadc3d13b979a8 Author: yhirano <yhirano@chromium.org> Date: Mon Dec 12 01:48:11 2016 Deflake http/tests/inspector/tracing/timeline-receive-response-event.html As a follow-up for [1], this CL fixes the flakiness of timeline-receive-response-event.html by dumping only the first ResourceReceivedData event for each request. 1: https://crrev.com/48f3e047d17e5f78543bb0bec1c421ba3a69cb79 BUG= 666217 Review-Url: https://codereview.chromium.org/2563613004 Cr-Commit-Position: refs/heads/master@{#437810} [modify] https://crrev.com/4abbfe190c2692147bcea746c5cadc3d13b979a8/third_party/WebKit/LayoutTests/http/tests/inspector/tracing/timeline-receive-response-event-expected.txt [modify] https://crrev.com/4abbfe190c2692147bcea746c5cadc3d13b979a8/third_party/WebKit/LayoutTests/http/tests/inspector/tracing/timeline-receive-response-event.html
Apologies, applied the wrong component in bulk.
Comment 1 by bugdroid1@chromium.org
, Nov 29 2016